Re: Configure(still?) broken on OS X

2016-01-14 Thread Erik Joelsson
I believe freetype is needed on Macosx so if that is missing in README-builds.html, that's a bug. I'm not a regular Macosx user so I might remember this wrong, but you can get freetype from different sources. One is to install XQuartz. Another is to get it from homebrew. There was some issue w

Re: javac server: No port file values materialized. on AIX

2016-01-14 Thread Erik Joelsson
There is a bug for that as we see the same thing on Solaris from time to time, as I see you know. Andreas, who is the main engineer working on sjavac, is currently on vacation. We don't currently know the cause of this issue. Any help would be appreciated. /Erik On 2016-01-14 08:29, Thomas St

Re: RFR: JDK-8146403: Windows build can be faster

2016-01-14 Thread Erik Joelsson
Hello, Thinking more about the new bootstrap logic, I feel that I don't like the solution. Here is a new patch where I only changed that part. I reverted to using the -include mechanism to trigger generation of module-deps.gmk, but still in a separate makefile that is only included by Main.gm

Re: RFR: JDK-8146403: Windows build can be faster

2016-01-14 Thread Magnus Ihse Bursie
On 2016-01-14 11:43, Erik Joelsson wrote: Hello, Thinking more about the new bootstrap logic, I feel that I don't like the solution. Here is a new patch where I only changed that part. I reverted to using the -include mechanism to trigger generation of module-deps.gmk, but still in a separate

Re: RFR: JDK-8146403: Windows build can be faster

2016-01-14 Thread Erik Joelsson
On 2016-01-14 11:53, Magnus Ihse Bursie wrote: On 2016-01-14 11:43, Erik Joelsson wrote: Hello, Thinking more about the new bootstrap logic, I feel that I don't like the solution. Here is a new patch where I only changed that part. I reverted to using the -include mechanism to trigger gener

RFR: JDK-8147086: Excluding of copy files broken after JDK-8144226

2016-01-14 Thread Erik Joelsson
Since JDK-8144226, the java.desktop module is including more resource files than it used to. This is caused by a small bug in SetupJavaCompilation.gmk that fails to apply exclude patterns on files to be copied. The fix is simple: diff -r 4b01ea6c12c3 make/common/JavaCompilation.gmk --- a/make/

Re: Is there any valid reason that a debug or fastdebug build should define PRODUCT and not ASSERT during compiles?

2016-01-14 Thread Magnus Ihse Bursie
On 2016-01-08 23:07, Derek White wrote: [This is likely a bug, but thought I'd ask it as a question first]. I'm new to jdk builds on windows, and have spent way more time than I'd like to admit on figuring out why my fastdebug builds did not have asserts turned on. The TL;DR; answer is that

Re: RFR: JDK-8146403: Windows build can be faster

2016-01-14 Thread Magnus Ihse Bursie
On 2016-01-14 12:01, Erik Joelsson wrote: On 2016-01-14 11:53, Magnus Ihse Bursie wrote: On 2016-01-14 11:43, Erik Joelsson wrote: Hello, Thinking more about the new bootstrap logic, I feel that I don't like the solution. Here is a new patch where I only changed that part. I reverted to us

Re: RFR: JDK-8147086: Excluding of copy files broken after JDK-8144226

2016-01-14 Thread Magnus Ihse Bursie
On 2016-01-14 12:06, Erik Joelsson wrote: Since JDK-8144226, the java.desktop module is including more resource files than it used to. This is caused by a small bug in SetupJavaCompilation.gmk that fails to apply exclude patterns on files to be copied. The fix is simple: diff -r 4b01ea6c12c3

RFR: JDK-8147091 Remove debug output in basics.m4

2016-01-14 Thread Magnus Ihse Bursie
Unfortunately a piece of debug output slipped into basics.m4 some time ago. That it hasn't been discovered until now is probably proof that nobody reads the output from configure. :-& Bug: https://bugs.openjdk.java.net/browse/JDK-8147091 Diff inline: diff --git a/common/autoconf/basics.m4 b/c

Re: javac server: No port file values materialized. on AIX

2016-01-14 Thread Andreas Lundblad
On Thu, Jan 14, 2016 at 09:06:56AM +0100, Erik Joelsson wrote: > There is a bug for that as we see the same thing on Solaris from > time to time, as I see you know. Andreas, who is the main engineer > working on sjavac, is currently on vacation. We don't currently know > the cause of this issue. An

Re: RFR: JDK-8147091 Remove debug output in basics.m4

2016-01-14 Thread Erik Joelsson
Looks good. /Erik On 2016-01-14 13:00, Magnus Ihse Bursie wrote: Unfortunately a piece of debug output slipped into basics.m4 some time ago. That it hasn't been discovered until now is probably proof that nobody reads the output from configure. :-& Bug: https://bugs.openjdk.java.net/browse

Re: javac server: No port file values materialized. on AIX

2016-01-14 Thread Thomas Stüfe
Thanks, Andreas, well, we do have a workaround. I'll wait until you find out more. Have a nice rest-of-vacation! Kind Regards, Thomas On Thu, Jan 14, 2016 at 1:23 PM, Andreas Lundblad < andreas.lundb...@oracle.com> wrote: > On Thu, Jan 14, 2016 at 09:06:56AM +0100, Erik Joelsson wrote: > > Ther

Re: RFR: JDK-8145549 Add support for Visual Studio 2015 Community edition

2016-01-14 Thread Magnus Ihse Bursie
On 2015-12-18 15:11, Wang Weijun wrote: Hi Vinnie I take a look and it includes a change for src/jdk.crypto.mscapi/windows/native/libsunmscapi/security.cpp in the Java_sun_security_mscapi_KeyStore_getKeyLength() function. It seems there is no sun.security.mscapi.KeyStore#getKeyLength on the j

Re: Configure(still?) broken on OS X

2016-01-14 Thread Scott Palmer
I installed XQuartz, rebooted, and re-ran configure. Got the exact same error. Seems the path to freetype in XQuartz is not fixed. Scott On Thu, Jan 14, 2016 at 3:01 AM, Erik Joelsson wrote: > I believe freetype is needed on Macosx so if that is missing in > README-builds.html, that's a bug.

Re: RFR: JDK-8145549 Add support for Visual Studio 2015 Community edition

2016-01-14 Thread Magnus Ihse Bursie
On 2016-01-05 03:25, Kim Barrett wrote: On Dec 18, 2015, at 7:41 PM, Kim Barrett wrote: On Dec 16, 2015, at 8:50 AM, Magnus Ihse Bursie wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8145549 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8145549-vs2015-community-edition/webrev.01 /Magn

Re: Configure(still?) broken on OS X

2016-01-14 Thread Magnus Ihse Bursie
On 2016-01-14 15:59, Scott Palmer wrote: I installed XQuartz, rebooted, and re-ran configure. Got the exact same error. Seems the path to freetype in XQuartz is not fixed. How did you install XQuartz? Can you check that you indeed have freetype installed on the system, and let us know where

Re: RFR: 8146985: Change output directory for hotspot's jtreg tets to build/conf/hotspot/testoutput

2016-01-14 Thread Erik Helin
On 2016-01-14, David Holmes wrote: > Sorry I don't understand the change. AFAICS ALT_OUTPUTDIR could be anything > - no guarantee that it already contains the "CONF" directory. > > Any why only change one path: > > ifdef ALT_OUTPUTDIR > ! ABS_BUILD_ROOT = $(ALT_OUTPUTDIR)/hotspot > else >

Re: RFR: 8146985: Change output directory for hotspot's jtreg tets to build/conf/hotspot/testoutput

2016-01-14 Thread Erik Helin
On 2016-01-13, Mikael Vidstedt wrote: > The logic in this file (hotspot/test/Makefile) is very similar to that of > jdk/test/Makefile, as a matter of fact some of it has been copy pasted. The benefit is that if you learn one of the Makefiles, you can quickly pick learn the other one ;) On 2016-01

Re: Configure(still?) broken on OS X

2016-01-14 Thread Scott Palmer
On Thu, Jan 14, 2016 at 10:07 AM, Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > On 2016-01-14 15:59, Scott Palmer wrote: > >> I installed XQuartz, rebooted, and re-ran configure. Got the exact same >> error. Seems the path to freetype in XQuartz is not fixed. >> > > How did you in

Build errors on OS X "Failed module access verification"

2016-01-14 Thread Scott Palmer
I managed to get configure working by installing freetype via XQuartz and forcing it to be found with ./configure --with-freetype=/opt/X11 I'm building on OS X 10.11.2. The table in Appendix C: Build Environments or the README-builds.html file says "Xcode 6.3 or newer", but Xcode 7 resulted in a

Re: Build errors on OS X "Failed module access verification"

2016-01-14 Thread Magnus Ihse Bursie
On 2016-01-14 19:32, Scott Palmer wrote: I managed to get configure working by installing freetype via XQuartz and forcing it to be found with ./configure --with-freetype=/opt/X11 I'm building on OS X 10.11.2. The table in Appendix C: Build Environments or the README-builds.html file says "Xcod

Re: RFR: JDK-8145549 Add support for Visual Studio 2015 Community edition

2016-01-14 Thread Wang Weijun
> On Jan 14, 2016, at 11:00 PM, Magnus Ihse Bursie > wrote: > > On 2015-12-18 15:11, Wang Weijun wrote: >> Hi Vinnie >> >> I take a look and it includes a change for >> src/jdk.crypto.mscapi/windows/native/libsunmscapi/security.cpp in the >> Java_sun_security_mscapi_KeyStore_getKeyLength() f

Re: RFR: 8146985: Change output directory for hotspot's jtreg tets to build/conf/hotspot/testoutput

2016-01-14 Thread David Holmes
On 15/01/2016 2:03 AM, Erik Helin wrote: On 2016-01-14, David Holmes wrote: Sorry I don't understand the change. AFAICS ALT_OUTPUTDIR could be anything - no guarantee that it already contains the "CONF" directory. Any why only change one path: ifdef ALT_OUTPUTDIR ! ABS_BUILD_ROOT = $(ALT_