Re: P1 RFR of build fix (extra small): JDK-8153303

2016-04-04 Thread Erik Joelsson
Looks good, thanks Tim! /Erik On 2016-04-01 20:41, Tim Bell wrote: Please review this build fix. One ',' was omitted in the JDK-8153257 changes. Bug report: https://bugs.openjdk.java.net/browse/JDK-8153303 Webrev: http://cr.openjdk.java.net/~tbell/8153303/webrev.00/index.html This is

Re: Configuration script unable to detect boot JDK's modules support

2016-04-04 Thread Erik Joelsson
Yes, we do, if you don't mind. /Erik On 2016-04-02 13:38, Filipp Zhinkin wrote: Hi Erik, thanks for reply. Do we need a JBS's ticket to track this issue? Thanks, Filipp. On Thu, Mar 31, 2016 at 5:23 PM, Erik Joelsson wrote: It seems the test is indeed incorrect at this point. When I added

Re: Provide zipped javadoc archive from make

2016-04-04 Thread Erik Joelsson
Hello, There is still an mkdir instead of $(MKDIR). The comments don't read very well, here is a suggestion. "Optional target which bundles all generated javadocs into a zip archive. The dependency on docs is handled in Main.gmk. Incremental building of docs is currently broken so if you invo

Re: RFR [9] 8153286: Move sun.misc.GC to java.rmi ( sun.rmi.transport )

2016-04-04 Thread Chris Hegarty
[ including build-dev ] sun.misc.GC is not "Critical APIs", as defined by JEP 260, so should be moved out of sun.misc and placed into a more appropriate package, where it can be encapsulated. Since GC is only used by RMI, I proposed to move it to the java.rmi module. Since it has a native compo

Re: RFR [9] 8153286: Move sun.misc.GC to java.rmi ( sun.rmi.transport )

2016-04-04 Thread Erik Joelsson
Makefile looks good. If you move Java_sun_rmi_transport_GC_maxObjectInspectionAge out of libjava, should you also remove it from the mapfile for libjava? /Erik On 2016-04-04 12:26, Chris Hegarty wrote: [ including build-dev ] sun.misc.GC is not "Critical APIs", as defined by JEP 260, so sh

Re: RFR [9] 8153286: Move sun.misc.GC to java.rmi ( sun.rmi.transport )

2016-04-04 Thread Alan Bateman
On 04/04/2016 12:04, Erik Joelsson wrote: Makefile looks good. If you move Java_sun_rmi_transport_GC_maxObjectInspectionAge out of libjava, should you also remove it from the mapfile for libjava? Yes, libjava/mapfile-vers will need to be updated too. It otherwise looks okay to me, just a p

RFR: JDK-8153243: JShell: make docs --- should generate JShell API docs

2016-04-04 Thread Jan Lahoda
Hi, Bug: https://bugs.openjdk.java.net/browse/JDK-8153243 Javadoc for JShell API should be part of the "make docs". Changes to the top-level repository: http://cr.openjdk.java.net/~jlahoda/8153243/webrev.00/top-level/ Small tweaks to the langtools repository (JShell API javadoc) to avoid erro

Re: RFR: JDK-8153243: JShell: make docs --- should generate JShell API docs

2016-04-04 Thread Erik Joelsson
Looks good to me. /Erik On 2016-04-04 13:36, Jan Lahoda wrote: Hi, Bug: https://bugs.openjdk.java.net/browse/JDK-8153243 Javadoc for JShell API should be part of the "make docs". Changes to the top-level repository: http://cr.openjdk.java.net/~jlahoda/8153243/webrev.00/top-level/ Small twea

Re: RFR [9] 8153286: Move sun.misc.GC to java.rmi ( sun.rmi.transport )

2016-04-04 Thread Chris Hegarty
On 04/04/16 12:34, Alan Bateman wrote: > On 04/04/2016 12:04, Erik Joelsson wrote: >> Makefile looks good. >> >> If you move Java_sun_rmi_transport_GC_maxObjectInspectionAge out of >> libjava, should you also remove it from the mapfile for libjava? >> > Yes, libjava/mapfile-vers will need to be up

Re: [8u-dev] Request for review and approval for bug 8147807: crash in libkcms.so on linux-sparc

2016-04-04 Thread Alexey Ivanov
Thanks to everyone for reviewing. I've pushed the fix today. Regards, Alexey On 17.03.2016 21:23, Phil Race wrote: +1 -phil. On 02/15/2016 01:02 AM, Erik Joelsson wrote: Looks good. /Erik On 2016-02-12 10:15, Seán Coffey wrote: Approved for jdk8u-dev once you have a peer code review. Reg