Re: RFR: JDK-8156018: Hotspot visual studio project generation broken

2016-05-09 Thread Erik Joelsson
Friendly reminder. If at least someone who cares about VS projects could try it out and stamp this, that should be enough I think? /Erik On 2016-05-04 11:24, Erik Joelsson wrote: With the new hotspot build, there was supposed to be support for creating a visual studio project, as was possible

RE: RFR: JDK-8156018: Hotspot visual studio project generation broken

2016-05-09 Thread Markus Gronlund
Hi Erik, I was just trying this out - end results looks good. Thanks for doing this! Markus -Original Message- From: Erik Joelsson Sent: den 9 maj 2016 12:09 To: build-dev; hotspot-dev developers Subject: Re: RFR: JDK-8156018: Hotspot visual studio project generation broken Friendly

Re: RFR: JDK-8156018: Hotspot visual studio project generation broken

2016-05-09 Thread Christian Tornqvist
Hi Erik, Looks good, thanks for fixing this! Thanks, Christian > On May 9, 2016, at 6:09 AM, Erik Joelsson wrote: > > Friendly reminder. If at least someone who cares about VS projects could > try it out and stamp this, that should be enough I think? > > /Erik > >> On 2016-05-04 11:24, Erik

RFR: JDK-8153685: Parfait integration missing in the new tools (jmod and jlink)

2016-05-09 Thread Erik Joelsson
Hello, These are open changes necessary for running the build with an Oracle internal tool. This patch moves the definitions of the make variables JLINK and JMOD to configure so that custom configure logic may override and change them. I also moved the order of javac flags around so that if

Re: RFR: JDK-8153685: Parfait integration missing in the new tools (jmod and jlink)

2016-05-09 Thread Alan Bateman
On 09/05/2016 12:50, Erik Joelsson wrote: Hello, These are open changes necessary for running the build with an Oracle internal tool. This patch moves the definitions of the make variables JLINK and JMOD to configure so that custom configure logic may override and change them. I also mov

Fwd: Having problem building jdk9-dev

2016-05-09 Thread Jim Laskey (Oracle)
Forwarding from jdk9-dev. > Begin forwarded message: > > From: "Jim Laskey (Oracle)" > Subject: Re: Having problem building jdk9-dev > Date: May 9, 2016 at 11:07:15 AM ADT > To: jdk9-dev , jigsaw-dev > > > Mac OS X - reproducible with a fresh repo. > > >> On May 9, 2016, at 10:08 AM, Jim La

Re: RFR: JDK-8153685: Parfait integration missing in the new tools (jmod and jlink)

2016-05-09 Thread Mandy Chung
> On May 9, 2016, at 4:50 AM, Erik Joelsson wrote: > > Hello, > > These are open changes necessary for running the build with an Oracle > internal tool. > > This patch moves the definitions of the make variables JLINK and JMOD to > configure so that custom configure logic may override and ch

Re: Having problem building jdk9-dev

2016-05-09 Thread Jim Laskey (Oracle)
Boot JDK - got to stop installing EA > On May 9, 2016, at 11:11 AM, Jim Laskey (Oracle) > wrote: > > Forwarding from jdk9-dev. > >> Begin forwarded message: >> >> From: "Jim Laskey (Oracle)" > > >> Subject: Re: Having problem building jdk9-dev >> Date: May 9, 2

RFR: 8156560: Remove AddJsum

2016-05-09 Thread Claes Redestad
Hi, AddJsum is no longer needed/used and could be removed. Webrev: http://cr.openjdk.java.net/~redestad/8156560/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8156560 Thanks /Claes

Re: RFR: 8156560: Remove AddJsum

2016-05-09 Thread Alan Bateman
On 09/05/2016 18:12, Claes Redestad wrote: Hi, AddJsum is no longer needed/used and could be removed. Webrev: http://cr.openjdk.java.net/~redestad/8156560/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8156560 Looks fine.

RFR: JDK-8136777: Introduce bundle targets

2016-05-09 Thread Erik Joelsson
Hello, This change introduces bundle targets for the OpenJDK build, which creates the same tar.gz and zip bundles as the full OracleJDK build does today. The motivation for this is to have one place where this happens, in a part of the build that is always being built by all our configurations

Re: RFR: 8156560: Remove AddJsum

2016-05-09 Thread Erik Joelsson
Looks good to me. /Erik On 2016-05-09 19:12, Claes Redestad wrote: Hi, AddJsum is no longer needed/used and could be removed. Webrev: http://cr.openjdk.java.net/~redestad/8156560/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8156560 Thanks /Claes

Re: RFR: 8156560: Remove AddJsum

2016-05-09 Thread Claes Redestad
Erik, Alan, thanks for reviewing! /Claes On 2016-05-09 19:23, Erik Joelsson wrote: Looks good to me. /Erik On 2016-05-09 19:12, Claes Redestad wrote: Hi, AddJsum is no longer needed/used and could be removed. Webrev: http://cr.openjdk.java.net/~redestad/8156560/webrev.01/ Bug: https://bugs

Re: RFR: JDK-8136777: Introduce bundle targets

2016-05-09 Thread Tim Bell
Erik: This change introduces bundle targets for the OpenJDK build, which creates the same tar.gz and zip bundles as the full OracleJDK build does today. The motivation for this is to have one place where this happens, in a part of the build that is always being built by all our configurations

Mac build failing

2016-05-09 Thread Pete Brunet
Am running into a build problem on Mac. Creating libjvm.dylib from 771 file(s) In file included from /Users/petebrunet/JDK9/JDK-8145207/client/hotspot/src/share/vm/precompiled/precompiled.hpp:30: In file included from /Users/petebrunet/JDK9/JDK-8145207/client/hotspot/src/share/vm/asm/assembler.inl

Re: Mac build failing

2016-05-09 Thread Phil Race
https://bugs.openjdk.java.net/browse/JDK-8152856 -phil. On 05/09/2016 12:20 PM, Pete Brunet wrote: Am running into a build problem on Mac. Creating libjvm.dylib from 771 file(s) In file included from /Users/petebrunet/JDK9/JDK-8145207/client/hotspot/src/share/vm/precompiled/precompiled.hpp:30:

Re: Mac build failing

2016-05-09 Thread Pete Brunet
Thanks Phil, I asked in the bug but will ask here too - is there a workaround until the issue is resolved? In my case I have 6.2 and 7.3.1. Pete On 5/9/16 2:29 PM, Phil Race wrote: > https://bugs.openjdk.java.net/browse/JDK-8152856 > > -phil. > > On 05/09/2016 12:20 PM, Pete Brunet wrote: >> Am

Re: Mac build failing

2016-05-09 Thread Phil Race
The usual one --disable-warnings-as-errors when running configure. -phil. On 05/09/2016 01:11 PM, Pete Brunet wrote: Thanks Phil, I asked in the bug but will ask here too - is there a workaround until the issue is resolved? In my case I have 6.2 and 7.3.1. Pete On 5/9/16 2:29 PM, Phil Race w

Re: Mac build failing

2016-05-09 Thread Pete Brunet
Thanks. That worked. On 5/9/16 3:07 PM, Phil Race wrote: > The usual one --disable-warnings-as-errors when running configure. > > -phil. > > On 05/09/2016 01:11 PM, Pete Brunet wrote: >> Thanks Phil, I asked in the bug but will ask here too - is there a >> workaround until the issue is resolved?

Re: Mac build failing

2016-05-09 Thread Pete Brunet
Further along I got this (after using --disable-warnings-as-errors): ... Compiling 15 files for jdk.naming.dns ld: warning: object file (/Users/petebrunet/JDK9/JDK-8145207/client/build/macosx-x86_64-normal-server-release/support/native/java.base//libfdlibm.a) was built for newer OSX version (10.9)

Re: Mac build failing

2016-05-09 Thread Pete Brunet
Going back to 6.2. Hopefully 7.3.1 won't force install itself this time. On 5/9/16 3:30 PM, Pete Brunet wrote: > Further along I got this (after using --disable-warnings-as-errors): > > ... > Compiling 15 files for jdk.naming.dns > ld: warning: object file > (/Users/petebrunet/JDK9/JDK-8145207/cl

Re: RFR: JDK-8136777: Introduce bundle targets

2016-05-09 Thread Magnus Ihse Bursie
Looks good to me. Just fix the indentation in MakeBase.gmk that got messed up. /Magnus > 9 maj 2016 kl. 19:18 skrev Erik Joelsson : > > Hello, > > This change introduces bundle targets for the OpenJDK build, which creates > the same tar.gz and zip bundles as the full OracleJDK build does toda

Re: Mac build failing

2016-05-09 Thread Pete Brunet
Back on 6.2 but now getting Creating jjs from 1 file(s) strip: error: unable to find utility "strip", not a developer tool or in PATH make[3]: *** [/Users/petebrunet/JDK9/JDK-8145207/client/build/macosx-x86_64-normal-server-release/support/modules_cmds-stripped/jdk.jlink/jimage] Error 72 Config o

Re: Mac build failing

2016-05-09 Thread Pete Brunet
Installing the xcode command line tools resolved that issue. xcode-select --install On 5/9/16 5:26 PM, Pete Brunet wrote: > Back on 6.2 but now getting > > Creating jjs from 1 file(s) > strip: error: unable to find utility "strip", not a developer tool or in > PATH > make[3]: *** > [/Users/petebr