Re: RFR: JDK-8155786: Determine modules depending on upgradeable modules directly and indirectly

2016-05-23 Thread Ivan Krylov
(perhaps this question belongs to the jigsaw-dev list..) How upgradable modules are defined. JEP-261 uses this term but does not define it AFAICS. Thanks, Ivan On 19/05/2016 16:15, Alan Bateman wrote: On 18/05/2016 15:39, Erik Joelsson wrote: This patch replaces the list of indirectly upgradeab

Re: RFR: JDK-8155786: Determine modules depending on upgradeable modules directly and indirectly

2016-05-23 Thread Alan Bateman
On 23/05/2016 13:27, Ivan Krylov wrote: (perhaps this question belongs to the jigsaw-dev list..) How upgradable modules are defined. JEP-261 uses this term but does not define it AFAICS. make/commons/Modules.gmk defines the list of upgradeable modules, look for UPGRADEABLE_MODULES. A module is u

RFR: JDK-8157574: Mac fastdebug bundles have wrong directory layout

2016-05-23 Thread Erik Joelsson
Hello, In JDK-8136777 I introduced the new bundle targets which creates .tar.gz bundles of all the images. The naming and layout of these bundles were based on how Oracle has created such bundles internally before. Except in one case, where I missed: Macosx debug. As I see it, there is no re

Re: RFR: JDK-8157574: Mac fastdebug bundles have wrong directory layout

2016-05-23 Thread Mandy Chung
Looks okay to me. Mandy > On May 23, 2016, at 7:00 AM, Erik Joelsson wrote: > > Hello, > > In JDK-8136777 I introduced the new bundle targets which creates .tar.gz > bundles of all the images. The naming and layout of these bundles were based > on how Oracle has created such bundles internal

RFR: 8157605 Can't set both CONCURRENCY and EXTRA_JTREG_OPTIONS when running tests

2016-05-23 Thread Staffan Larsen
This does not work: $ cd test $ make jtreg_tests CONCURRENCY=10 EXTRA_JTREG_OPTIONS=-k:\!headful I can specify either CONCURRENCY or EXTRA_JTREG_OPTIONS, but not both. Please review the fix below: bug: https://bugs.openjdk.java.net/browse/JDK-8157605

Re: RFR: 8157605 Can't set both CONCURRENCY and EXTRA_JTREG_OPTIONS when running tests

2016-05-23 Thread Tim Bell
Staffan: This does not work: $ cd test $ make jtreg_tests CONCURRENCY=10 EXTRA_JTREG_OPTIONS=-k:\!headful I can specify either CONCURRENCY or EXTRA_JTREG_OPTIONS, but not both. Please review the fix below: bug: https://bugs.openjdk.java.net/browse/JDK-8157605

Re: RFR: 8157605 Can't set both CONCURRENCY and EXTRA_JTREG_OPTIONS when running tests

2016-05-23 Thread Jonathan Gibbons
It seems anomalous that langtools is missing, but perhaps that's a different problem. -- Jon On 05/23/2016 11:14 AM, Staffan Larsen wrote: This does not work: $ cd test $ make jtreg_tests CONCURRENCY=10 EXTRA_JTREG_OPTIONS=-k:\!headful I can specify either CONCURRENCY or EXTRA_JTREG_OPTIONS,

Re: RFR: 8157605 Can't set both CONCURRENCY and EXTRA_JTREG_OPTIONS when running tests

2016-05-23 Thread Staffan Larsen
Thanks Tim! > On 24 maj 2016, at 03:46, Tim Bell wrote: > > Staffan: > >> This does not work: >> >> $ cd test >> $ make jtreg_tests CONCURRENCY=10 EXTRA_JTREG_OPTIONS=-k:\!headful >> >> I can specify either CONCURRENCY or EXTRA_JTREG_OPTIONS, but not both. >> >> Please review the fix below:

Re: RFR: 8157605 Can't set both CONCURRENCY and EXTRA_JTREG_OPTIONS when running tests

2016-05-23 Thread Staffan Larsen
> On 24 maj 2016, at 04:04, Jonathan Gibbons > wrote: > > It seems anomalous that langtools is missing, but perhaps that's a different > problem. Langtools is already doing things this way. That was the only place things worked! > > -- Jon > > On 05/23/2016 11:14 AM, Staffan Larsen wrote: