Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

The fix looks good to me. Thanks, Alexandr. On 6/9/2016 8:58 PM, Daniil Titov wrote: Thank you, Mandy! The long line is corrected. Webrev: http://cr.openjdk.java.net/~dtitov/8156960/jdk/webrev.03 http://cr.openjdk.java.net/~dtitov/8156960/webrev.03 Bug: https://bugs.openjdk.java.net

Re: RFR: JDK-8055735: JDK_FILTER is broken

On 2016-06-09 16:32, Tim Bell wrote: Erik: Looks good to me as well. make/common/JavaCompilation.gmk - this file looks fine, but I am puzzled by the large numbers reported by webrev: 285 lines changed: 91 ins; 86 del; 108 mod; 292 unchg Did you do some whitespace cleanup? I had to

Re: RFR: JDK-8159186: jdk/test/Makefile: allow users to set verbosity

Looks good. The big cleanup of the test makefiles is something we hope to attack at some point, but it's not yet planned. /Erik On 2016-06-09 20:17, Dan Smith wrote: I'd like to make a simple tweak to jdk/test/Makefile in order to support control over the "-v" verbosity option sent to jtreg

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

Looks good. /Erik On 2016-06-09 19:58, Daniil Titov wrote: Thank you, Mandy! The long line is corrected. Webrev: http://cr.openjdk.java.net/~dtitov/8156960/jdk/webrev.03 http://cr.openjdk.java.net/~dtitov/8156960/webrev.03 Bug: https://bugs.openjdk.java.net/browse/JDK-8156960 Best

Re: RFR 8144278 [TESTBUG] hotspot/runtime/StackGuardPages/testme.sh should use native library build support

Hi Everyone, I have address Erik's, Dmitry's and David's concerns in a new webrev: Bug: https://bugs.openjdk.java.net/browse/JDK-8144278 JDK Webrev: http://cr.openjdk.java.net/~gthornbr/8144278/jdk-webrev.01/ Hotspot Webrev: ht

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

Hi, sorry I had missed this earlier. It's surprising if forRemoval=true were to be added to this API when the rest of the Applet API has forRemoval=false. Is it the intent, for example, to have JSObject.getWindow() removed from JDK 10 but to have the rest of the Applet API remain? My underst

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

That was also my understanding. I'm a bit surprised this is coming up since I thought we'd settled that when deprecating Applet... -DrD- > Hi, sorry I had missed this earlier. > > It's surprising if forRemoval=true were to be added to this API when the rest > of the Applet API has forRemoval=

RE: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

Thank you, Stuart! Please review the new version of the patch that has "forRemoval=true" removed. Webrev: http://cr.openjdk.java.net/~dtitov/8156960/jdk/webrev.04/ http://cr.openjdk.java.net/~dtitov/8156960/webrev.04/ Bug:https://bugs.openjdk.java.net/browse/JDK-8156960 Best rega

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

This method is about the fate of plugin support in a future regardless of the presence of java.applet.Applet API. The @deprecated note may cause the confusion. What I understand from the past discussion with Kevin and Dave, we want this method to be removed in a future release - the earliest po

Re: Review Request: 8156960 Deprecate JSObject.getWindow(Applet) method

Yes, ultimately the decision is up to Kevin and Dave (or whoever is in charge of technical decision-making in this area). I wanted to provide some clarity on the use of forRemoval=true. The specification is fairly neutral, saying only that there is "intent to remove" the API "in a future versi

Issue 8152856 Xcode 7.3 -Wshift-negative-value compile failure on Mac OS X, Still not fixed

Release notes for 9u122-ea indicate: 50b6bc2ac9e5 8152856 Xcode 7.3 -Wshift-negative-value compile failure on Mac OS X However I just updated, ran configure, make c