RFR: 8160825 Update minimum Solaris Studio compiler version to 5.13

2016-07-07 Thread Stefan Anzinger
This is a small change, to update the ckeck in configure to warn if the required Solaris Studio Compiler 5.13 is not available (As stated in the README-builds.html). http://cr.openjdk.java.net/~sanzinger/8160825/webrev.00/ Stefan

Re: RFR: 8160825 Update minimum Solaris Studio compiler version to 5.13

2016-07-07 Thread Tim Bell
Hello Stefan: This is a small change, to update the ckeck in configure to warn if the required Solaris Studio Compiler 5.13 is not available (As stated in the README-builds.html). http://cr.openjdk.java.net/~sanzinger/8160825/webrev.00/ Looks good. Sun Studio 12.4 contains the C++ 5.13 co

Re: [RFR] JDK-8156980: Hotspot build doesn't have -std=gnu++98 gcc option

2016-07-07 Thread Andrew Hughes
snip... > > > I'm also now seeing a problem with GCC 6 only that is unique to the > > > latest > > > OpenJDK 9 > > > and what looks like the gtest code. It seems to be the result of the > > > header > > > changes > > > also documented in [0] which were introduced in January [1] (and so > > > proba

RE: [9] Fix for JDK-8074824: Resolve disabled warnings for libawt_xawt

2016-07-07 Thread Ajit Ghaisas
Thanks Phil for the review. Please find my answers below. Semyon, can you please comment on Phil's question below? Regards, Ajit -Original Message- From: Phil Race Sent: Wednesday, July 06, 2016 2:02 AM To: Ajit Ghaisas Cc: Sergey Bylokhov; Erik Joelsson; 2d-dev; awt-...@openjdk.java.ne

Re: [9] Fix for JDK-8074824: Resolve disabled warnings for libawt_xawt

2016-07-07 Thread Semyon Sadetsky
On 7/7/2016 7:48 PM, Ajit Ghaisas wrote: Thanks Phil for the review. Please find my answers below. Semyon, can you please comment on Phil's question below? I agree with this change. The check is not needed. --Semyon Regards, Ajit -Original Message- From: Phil Race Sent: Wednesday,

Re: [RFR] JDK-8156980: Hotspot build doesn't have -std=gnu++98 gcc option

2016-07-07 Thread Andrew Hughes
snip... > > > Revised webrevs: > > > > http://cr.openjdk.java.net/~andrew/8156980/webrev.04/root > > http://cr.openjdk.java.net/~andrew/8156980/webrev.04/hotspot > > These look good to me. > Minor revision: http://cr.openjdk.java.net/~andrew/8156980/webrev.05/root http://cr.openjdk.java.net/

Building JDK8 fails on OS X El Capitan: clang process gets stuck

2016-07-07 Thread Robin Stevens
Hello, if you follow the build instructions to the letter ( http://hg.openjdk.java.net/jdk8u/jdk8u-dev/file/817d9fb584ba/README-builds.html), and try building JDK with XCode version 4.5.2 on El Capitan, the build never ends. At a certain point, you have a number of "clang" processes each consumin

Building JDK9 fails on OS X El Capitan

2016-07-07 Thread Robin Stevens
Hello, it is currently not possible to build JDK9 on OS X El Capitan. The problem is the line #include in files jdk/src/java.desktop/macosx/native/libawt_lwawt/font/CGGlyphImages.m jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/ImageSurfaceData.m On OS X El Capitan, the Accelerate.h fil

Re: Building JDK9 fails on OS X El Capitan

2016-07-07 Thread Phil Race
I expect this is the SDK version you are using more than the OS version. 10.9 is the supported SDK. Any changes to this particular code should be discussed on 2d-...@openjdk.java.net since they would not be build changes But that might not be sufficient .. you could encounter other issues that

Re: [RFR] JDK-8156980: Hotspot build doesn't have -std=gnu++98 gcc option

2016-07-07 Thread Kim Barrett
> On Jul 7, 2016, at 1:48 PM, Andrew Hughes wrote: >>> Revised webrevs: >>> >>> http://cr.openjdk.java.net/~andrew/8156980/webrev.04/root >>> http://cr.openjdk.java.net/~andrew/8156980/webrev.04/hotspot >> >> These look good to me. >> > > Minor revision: > > http://cr.openjdk.java.net/~andrew

Re: [9] Fix for JDK-8074824: Resolve disabled warnings for libawt_xawt

2016-07-07 Thread Phil Race
On 07/07/2016 10:25 AM, Semyon Sadetsky wrote: On 7/7/2016 7:48 PM, Ajit Ghaisas wrote: Thanks Phil for the review. Please find my answers below. Semyon, can you please comment on Phil's question below? I agree with this change. The check is not needed. Ok. so the fix overall seems fine in

[8u112] Request for review & approval for CR8151841: Build needs additional flags to compile with GCC 6

2016-07-07 Thread Andrew Hughes
Webrev: http://cr.openjdk.java.net/~andrew/8u/8151841/webrev.01/ Bug: https://bugs.openjdk.java.net/browse/JDK-8151841 This is a backport of the original fix to support building OpenJDK with GCC 6. It was necessary to cherry-pick parts of a number of earlier fixes to make this work with the build

Re: [RFR] JDK-8156980: Hotspot build doesn't have -std=gnu++98 gcc option

2016-07-07 Thread Andrew Hughes
- Original Message - > > On Jul 7, 2016, at 1:48 PM, Andrew Hughes wrote: > >>> Revised webrevs: > >>> > >>> http://cr.openjdk.java.net/~andrew/8156980/webrev.04/root > >>> http://cr.openjdk.java.net/~andrew/8156980/webrev.04/hotspot > >> > >> These look good to me. > >> > > > > Mino

Re: [RFR] JDK-8156980: Hotspot build doesn't have -std=gnu++98 gcc option

2016-07-07 Thread Erik Joelsson
Hello, This looks good except for the change in toolchain.m4, which looks like it might actually break cross compilation by overriding the value for compiler version for the build compiler using the target compiler. With this change we basically have: if cross compilation TOOLCHAIN_PREPARE

Re: [8u112] Request for review & approval for CR8151841: Build needs additional flags to compile with GCC 6

2016-07-07 Thread Erik Joelsson
Hello, It looks like TOOLCHAIN_CXX_COMPILER_CHECK_ARGUMENTS is always returning yes and TOOLCHAIN_C_COMPILER_CHECK_ARGUMENTS still does both the C and C++ checks. /Erik On 2016-07-07 22:21, Andrew Hughes wrote: Webrev: http://cr.openjdk.java.net/~andrew/8u/8151841/webrev.01/ Bug: https://bu