Re: RFR: JDK-8164402 key word 'requires' appearing in comment causing a build failure

2016-08-19 Thread Erik Joelsson
Looks good. /Erik On 2016-08-19 08:05, Tim Bell wrote: Hello Earlier today a javadoc change surprised us by causing JDK 9 builds to fail on all platforms, due to a modules 'requires' statement error. The fix is to have make/common/Modules.gmk be more selective when processing 'requires', s

Re: RFR: JDK-8164402 key word 'requires' appearing in comment causing a build failure

2016-08-19 Thread David Holmes
Hi Tim, Fix seems reasonable but this seems a rather crude way to determine dependencies. Thanks, David On 19/08/2016 4:05 PM, Tim Bell wrote: Hello Earlier today a javadoc change surprised us by causing JDK 9 builds to fail on all platforms, due to a modules 'requires' statement error. Th

Re: RFR: JDK-8164402 key word 'requires' appearing in comment causing a build failure

2016-08-19 Thread Erik Joelsson
Hello, It is indeed crude, but the alternative is to have the bootstrap make process compile a java program that parses the files. We used to have that before when the dependency information was in modules.xml, and it confused people when things went wrong. It also makes the build appear quit

Re: PING: [8u112] Request for review & approval for CR8151841: Build needs additional flags to compile with GCC 6

2016-08-19 Thread Seán Coffey
Haven't forgotten about this one. Hope to get to it today. Regards, Sean. On 05/08/2016 16:12, Andrew Hughes wrote: - Original Message - I'm seeing this patch fail across all platforms on internal builds. Please hold off any push for now. Maybe other config changes are needed on our b

jdk9 client build problem in linux

2016-08-19 Thread Prasanta Sadhukhan
Hi All, I have tried to checkout fresh jdk9-client repo today in ubuntu 32 bit linux and build but experiencing a failure */export/WorkSpaces/jdk9/client-jigsaw/build/linux-x86-normal-server-fastdebug/support/test/hotspot/jtreg/native/support/exeinvoke/exeinvoke.o: In function `main':** **/expo

Re: jdk9 client build problem in linux

2016-08-19 Thread Erik Joelsson
Hello Prasanta, Yes, it's https://bugs.openjdk.java.net/browse/JDK-8164297. I'm about to push the fix to jdk9/hs. The problem goes away if you use the Oracle internal official devkit. /Erik On 2016-08-19 15:21, Prasanta Sadhukhan wrote: Hi All, I have tried to checkout fresh jdk9-client r