Re: RFR: JDK-8166202: Tracefile gensrc cannot handle closed src dir in different location

2016-09-19 Thread David Holmes
Hi Erik, On 17/09/2016 12:51 AM, Erik Joelsson wrote: The xml/xsl source files used to generate sources for trace in hotspot have hard coded relative paths in them that make assumptions on where the oracle closed files are located. The source files should not make these kind of assumptions since

Re: [9] RFR[XS] 8166096: variable tracking size limit exceeded in jvmciCompilerToVM.cpp

2016-09-19 Thread Erik Joelsson
Looks ok to me. /Erik On 2016-09-17 03:17, Vladimir Kozlov wrote: https://bugs.openjdk.java.net/browse/JDK-8166096 +++ b/make/lib/JvmOverrideFiles.gmkFri Sep 16 18:14:06 2016 -0700 @@ -31,6 +31,7 @@ ifeq ($(TOOLCHAIN_TYPE), gcc) BUILD_LIBJVM_vmStructs.cpp_CXXFLAGS := -fno-var-tracki

Re: RFR: JDK-8166202: Tracefile gensrc cannot handle closed src dir in different location

2016-09-19 Thread Erik Gahlin
Looks good. Erik The xml/xsl source files used to generate sources for trace in hotspot have hard coded relative paths in them that make assumptions on where the oracle closed files are located. The source files should not make these kind of assumptions since that makes it difficult to change

Re: RFR: JDK-8166202: Tracefile gensrc cannot handle closed src dir in different location

2016-09-19 Thread Tim Bell
Erik: The xml/xsl source files used to generate sources for trace in hotspot have hard coded relative paths in them that make assumptions on where the oracle closed files are located. The source files should not make these kind of assumptions since that makes it difficult to change the repositor

Re: [9] RFR[XS] 8166096: variable tracking size limit exceeded in jvmciCompilerToVM.cpp

2016-09-19 Thread Vladimir Kozlov
Thank you, David, for review. I don't think we can do anything more here. It is number of intrinsics which overflow some internal buffer related to var-tracking-assignments in gcc during compilation: VM_INTRINSICS_DO(VM_INTRINSIC_INFO, VM_SYMBOL_IGNORE, VM_SYMBOL_IGNORE, VM_SYMBOL_IGNORE, V

Re: [9] RFR[XS] 8166096: variable tracking size limit exceeded in jvmciCompilerToVM.cpp

2016-09-19 Thread Vladimir Kozlov
Thank you, Erik Vladimir On 9/19/16 12:58 AM, Erik Joelsson wrote: Looks ok to me. /Erik On 2016-09-17 03:17, Vladimir Kozlov wrote: https://bugs.openjdk.java.net/browse/JDK-8166096 +++ b/make/lib/JvmOverrideFiles.gmkFri Sep 16 18:14:06 2016 -0700 @@ -31,6 +31,7 @@ ifeq ($(TOOLCHAIN_

Re: RFR for JDK-8165482 java in ldoms, with cpu-arch=generic has problems

2016-09-19 Thread David Holmes
Hi Martin, Build changes must be reviewed by the build team - now cc'd On 20/09/2016 12:16 AM, Martin Walsh wrote: Could I get a code review for the following bug: JDK-8165482 java in ldoms, with cpu-arch=generic has problems Webrev of the changes is available here: http://cr.openjdk.java.ne