Re: RFR: 8166790: Add stress test GCBasher

2016-10-07 Thread Thomas Schatzl
Hi, On Thu, 2016-10-06 at 16:38 +0200, Erik Helin wrote: > David, Dmitry, > > below you will find new patches: > - incremental: http://cr.openjdk.java.net/~ehelin/8166790/hotspot/02- > 03/ > - full: http://cr.openjdk.java.net/~ehelin/8166790/hotspot/03/ > > I've fixed the indentation of the comm

RFR: JDK-8166648,,jib make run-test for langtools results in intermittent failures on windows-x86

2016-10-07 Thread Tim Bell
Hello The change of HotSpot runtimes on 32-bit Windows [1] has been a source of langtools test failures due to memory space exhaustion. On our Windows build/test clients, the combination of the C2 runtime and parallel GC causes about 20 extra threads to be started in each VM. These added thr

Re: RFR: JDK-8166648,,jib make run-test for langtools results in intermittent failures on windows-x86

2016-10-07 Thread Erik Joelsson
Hello Tim, Assuming this is the webrev: http://cr.openjdk.java.net/~tbell/8166648/webrev/ It looks ok to me. /Erik On 2016-10-07 15:40, Tim Bell wrote: Hello The change of HotSpot runtimes on 32-bit Windows [1] has been a source of langtools test failures due to memory space exhaustion.

Re: RFR: JDK-8166648,,jib make run-test for langtools results in intermittent failures on windows-x86

2016-10-07 Thread Tim Bell
Again with the review link .. see below: On 10/07/16 06:40, Tim Bell wrote: Hello The change of HotSpot runtimes on 32-bit Windows [1] has been a source of langtools test failures due to memory space exhaustion. On our Windows build/test clients, the combination of the C2 runtime and parallel

Re: RFR: JDK-8166648,,jib make run-test for langtools results in intermittent failures on windows-x86

2016-10-07 Thread Jonathan Gibbons
Tim, The problem only appears on 32-bit Windows, but the fix appears to be across the board. Does this penalize or otherwise adversely affect test runs on other platforms? -- Jon On 10/07/2016 07:15 AM, Tim Bell wrote: Again with the review link .. see below: On 10/07/16 06:40, Tim Bell wr

Re: RFR: JDK-8166648,,jib make run-test for langtools results in intermittent failures on windows-x86

2016-10-07 Thread Tim Bell
Hi Jon On 10/07/16 15:48, Jonathan Gibbons wrote: Tim, The problem only appears on 32-bit Windows, but the fix appears to be across the board. Does this penalize or otherwise adversely affect test runs on other platforms? Good point. Here is an updated webrev where serialGC is requested only

Re: RFR: JDK-8166648,,jib make run-test for langtools results in intermittent failures on windows-x86

2016-10-07 Thread Jonathan Gibbons
Looks good to me. FWIW, I recommend developers using -Xmx512 for these tests, but I think it is a good idea to be somewhat more lax/generous on automated build platforms, to avoid spurious failures. -- Jon On 10/07/2016 06:34 PM, Tim Bell wrote: Hi Jon On 10/07/16 15:48, Jonathan Gibbons w

Re: RFR: JDK-8166648,,jib make run-test for langtools results in intermittent failures on windows-x86

2016-10-07 Thread Tim Bell
Hi Jon Looks good to me. Thank you. FWIW, I recommend developers using -Xmx512 for these tests, but I think it is a good idea to be somewhat more lax/generous on automated build platforms, to avoid spurious failures. I agree. I was not able to get test runs to pass consistently in our au