Re: RFR: JDK-8167387: libjimage.so has a bad runpath

2016-10-11 Thread Magnus Ihse Bursie
On 2016-10-10 18:00, Erik Joelsson wrote: On Solaris libjimage.so has a weird extra runpath set, pointing into the install directory of Solaris Studio. JDK-8160630 changed libjimage to be compiled as C++ library as it should be. I forgot to add the linker flags LDFLAGS_CXX_JDK to the LDFLAGS

RFR: JDK-8167424 Stop adding missing newline to manifest files

2016-10-11 Thread Magnus Ihse Bursie
Due to a piece of broken internal code, a workaround was added to JarArchive to handle misformed manifest files. The root cause have now been fixed, and the workaround should be removed and the original code restored. Bug: https://bugs.openjdk.java.net/browse/JDK-8158181 Patch inline: diff --

Re: RFR: JDK-8167424 Stop adding missing newline to manifest files

2016-10-11 Thread Erik Joelsson
Looks ok. What happens in the build if a malformed manifest file is introduced again? Will it fail? /Erik On 2016-10-11 10:52, Magnus Ihse Bursie wrote: Due to a piece of broken internal code, a workaround was added to JarArchive to handle misformed manifest files. The root cause have now

Re: RFR: JDK-8167424 Stop adding missing newline to manifest files

2016-10-11 Thread Magnus Ihse Bursie
On 2016-10-11 11:07, Erik Joelsson wrote: Looks ok. What happens in the build if a malformed manifest file is introduced again? Will it fail? If I remember correctly, the result of that would not be a failure during the build process, but instead a malformed manifest file will be generated in

Re: RFR: JDK-8062810: Examine src.zip in JDK image and decide if source classes should be organized by module

2016-10-11 Thread Magnus Ihse Bursie
On 2016-10-10 15:55, Erik Joelsson wrote: Hello, Please review this change, which reorganizes src.zip into modules directories. It also includes the source of any imported modules into src.zip. If an imported modules contains both sources and classes, the java sources are not recompiled, ex

RFR: JDK-8167479: arm 32/64 slowdebug fails to build on unpack200

2016-10-11 Thread Erik Joelsson
Hello, After the cleanup of C++ linking with the GCC toolchain. We missed updating one instance with the correct TOOLCHAIN configuration. This leads to build failures for arm ports with slowdebug. I have no idea why it only happens there, but correcting the TOOLCHAIN configuration (so that g+

RFR: JDK-8166937: [Solaris] Missing libjvm_db.so and libjvm_dtrace.so from JDK 9 b138

2016-10-11 Thread Erik Joelsson
On Solaris, we used to always add /usr/sbin to the global PATH early in configure since some tools we need are found there. In JDK-8165161 that was removed. This had the consequence that configure no longer found dtrace unless the user had /usr/sbin in the PATH. When configure doesn't find dtra

RFR: JDK-8167488: Race condition in build with new exploded-image-optimize target

2016-10-11 Thread Erik Joelsson
When introducing the exploded-image-optimize target, I tried to fix all the dependencies so that the module-info.class files would not be used by any other target at the same time as the optimization was happening. It seems I forgot about one class of such uses. Any java compilation target that

Re: RFR: JDK-8167488: Race condition in build with new exploded-image-optimize target

2016-10-11 Thread Tim Bell
Hello Erik: When introducing the exploded-image-optimize target, I tried to fix all the dependencies so that the module-info.class files would not be used by any other target at the same time as the optimization was happening. It seems I forgot about one class of such uses. Any java compilation

Re: RFR: JDK-8167479: arm 32/64 slowdebug fails to build on unpack200

2016-10-11 Thread David Holmes
On 11/10/2016 7:41 PM, Erik Joelsson wrote: Hello, After the cleanup of C++ linking with the GCC toolchain. We missed updating one instance with the correct TOOLCHAIN configuration. This leads to build failures for arm ports with slowdebug. I have no idea why it only happens there, but correctin