The -KPIC flag was deprecated in Solaris Studio 12.3 for sparc code. It
should be changed to -xcode=pic32. This is an old bug, originally
deferred from jdk8, where we still used 12.1.
Bug: https://bugs.openjdk.java.net/browse/JDK-7164925
WebRev:
http://cr.openjdk.java.net/~ihse/JDK-7164925-sol
Build changes look good.
/Erik
On 2016-11-22 22:07, Mandy Chung wrote:
This patch moves src.zip and jrt-fs.jar from the top-level into
the `lib` directory in the run-time image as we proposed [1].
Webrev:
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8169816/webrev.00/
thanks
Mandy
[1] h
Looks good.
/Erik
On 2016-11-23 10:14, Magnus Ihse Bursie wrote:
The -KPIC flag was deprecated in Solaris Studio 12.3 for sparc code.
It should be changed to -xcode=pic32. This is an old bug, originally
deferred from jdk8, where we still used 12.1.
Bug: https://bugs.openjdk.java.net/browse/J
After JDK-8167354, when a test fails in jtreg, the langtools
test/Makefile ignores the result and exits with 0. This causes (at
least) JPRT jobs to not fail when langtools tests fail. The reason for
this is the added "| tee" construct which overrides the exit value from
jtreg.
Bug: https://bu
On 23/11/2016 12:29, Erik Joelsson wrote:
After JDK-8167354, when a test fails in jtreg, the langtools
test/Makefile ignores the result and exits with 0. This causes (at
least) JPRT jobs to not fail when langtools tests fail. The reason for
this is the added "| tee" construct which overrides t
On 22/11/2016 21:07, Mandy Chung wrote:
This patch moves src.zip and jrt-fs.jar from the top-level into
the `lib` directory in the run-time image as we proposed [1].
Webrev:
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8169816/webrev.00/
This looks good. A minor point in SystemImage.fi
Hi Gustavo,
thanks a lot for tracking this down!
The change looks good and I a can sponsor it once you get another
review from the build group and the FC Extension Request was approved.
In general I'd advise to sign the OCTLA [1] to get access to the Java
SE TCK [2] as this contains quite a lot
For a long time, a lot of people have been wanting the JDK classes to be
compiled with debug symbols enabled by default. I believe the reason we
haven't so far is to keep footprint down for the JRE image. The usecase
for debug information is mainly in the JDK image, which is used for
developmen
Build changes look ok.
In CoreLibraries.gmk, I think it would have been ok to keep the
conditional checking (OPENJDK_TARGET_CPU_ARCH, ppc), but this certainly
works too.
/Erik
On 2016-11-22 01:43, Gustavo Romero wrote:
Hi,
Could the following change be reviewed, please?
webrev 1/2: http:
After the hotspot makefile rewrite and the elimination of the hotspot
dist output directory, it's now time to create more fine granular top
level make targets for building hotspot. This will enable better
granularity in between hotspot build steps and the rest of the build.
Building native libr
It was pointed out that the changes to Images.gmk could be made simpler.
Here is a new webrev:
http://cr.openjdk.java.net/~erikj/8170280/webrev.top.02
/Erik
On 2016-11-23 15:25, Erik Joelsson wrote:
For a long time, a lot of people have been wanting the JDK classes to
be compiled with debug
Similarly for the closed images, new webrev:
http://javaweb.us.oracle.com/~ejoelsso/webrev/8170280/webrev.closed.02/
/Erik
On 2016-11-23 15:25, Erik Joelsson wrote:
For a long time, a lot of people have been wanting the JDK classes to
be compiled with debug symbols enabled by default. I believ
Please disregard this email, replied to the wrong one.
/Erik
On 2016-11-23 16:11, Erik Joelsson wrote:
Similarly for the closed images, new webrev:
http://javaweb.us.oracle.com/~ejoelsso/webrev/8170280/webrev.closed.02/
/Erik
On 2016-11-23 15:25, Erik Joelsson wrote:
For a long time, a lot o
Erik:
After JDK-8167354, when a test fails in jtreg, the langtools
test/Makefile ignores the result and exits with 0. This causes (at
least) JPRT jobs to not fail when langtools tests fail. The reason for
this is the added "| tee" construct which overrides the exit value from
jtreg.
Bug: https:
Hi Volker,
On 23-11-2016 12:05, Volker Simonis wrote:
> thanks a lot for tracking this down!
Happy to contribute :)
> The change looks good and I a can sponsor it once you get another
> review from the build group and the FC Extension Request was approved.
Thanks a lot for sponsoring it!
> I
Hi Martin,
On 23-11-2016 12:38, Doerr, Martin wrote:
> Hi Gustavo,
>
> thanks for providing the webrevs.
>
> I have ran the StrictMath jck tests which fail when building with -O3 and
> without -ffp-contract=off:
> FailedTests:
> api/java_lang/StrictMath/desc.html#acos
> javasoft.sqe.tests.api.
Hi Gustavo,
thanks for providing the webrevs.
I have ran the StrictMath jck tests which fail when building with -O3 and
without -ffp-contract=off:
FailedTests:
api/java_lang/StrictMath/desc.html#acos
javasoft.sqe.tests.api.java.lang.StrictMath.acos_test
api/java_lang/StrictMath/desc.html#asin
Hi Erik,
On 23-11-2016 12:29, Erik Joelsson wrote:
> Build changes look ok.
>
> In CoreLibraries.gmk, I think it would have been ok to keep the conditional
> checking (OPENJDK_TARGET_CPU_ARCH, ppc), but this certainly works too.
Thanks a lot for reviewing the change.
Regards,
Gustavo
Hi Erik,
the Java developers out there will love you for this change!
And yet another feature where you catch up with the SAP JVM :)
The change looks good, thumbs up from me.
Regards,
Volker
On Wed, Nov 23, 2016 at 4:10 PM, Erik Joelsson wrote:
> It was pointed out that the changes to Images.
Erik:
Looks good to me.
/Tim
On 11/23/16 07:10, Erik Joelsson wrote:
It was pointed out that the changes to Images.gmk could be made simpler.
Here is a new webrev:
http://cr.openjdk.java.net/~erikj/8170280/webrev.top.02
/Erik
On 2016-11-23 15:25, Erik Joelsson wrote:
For a long time, a lo
Erik:
After the hotspot makefile rewrite and the elimination of the hotspot
dist output directory, it's now time to create more fine granular top
level make targets for building hotspot. This will enable better
granularity in between hotspot build steps and the rest of the build.
Building native
Discovered an issue with cross compiling configurations. In
buildjdk-spec.gmk.in, need to also override the new variable
JVM_VARIANTS_MAIN. New webrev:
http://cr.openjdk.java.net/~erikj/8170284/webrev.02/
/Erik
On 2016-11-23 16:05, Erik Joelsson wrote:
After the hotspot makefile rewrite and t
Looks good.
Mandy
> On Nov 23, 2016, at 4:29 AM, Erik Joelsson wrote:
>
> After JDK-8167354, when a test fails in jtreg, the langtools test/Makefile
> ignores the result and exits with 0. This causes (at least) JPRT jobs to not
> fail when langtools tests fail. The reason for this is the adde
> On Nov 23, 2016, at 6:05 AM, Alan Bateman wrote:
>
>
>
> On 22/11/2016 21:07, Mandy Chung wrote:
>> This patch moves src.zip and jrt-fs.jar from the top-level into
>> the `lib` directory in the run-time image as we proposed [1].
>>
>> Webrev:
>> http://cr.openjdk.java.net/~mchung/jdk9/web
Erik:
Looks good.
Tim
Discovered an issue with cross compiling configurations. In
buildjdk-spec.gmk.in, need to also override the new variable
JVM_VARIANTS_MAIN. New webrev:
http://cr.openjdk.java.net/~erikj/8170284/webrev.02/
/Erik
On 2016-11-23 16:05, Erik Joelsson wrote:
After the hots
On 24/11/2016 1:10 AM, Erik Joelsson wrote:
It was pointed out that the changes to Images.gmk could be made simpler.
Here is a new webrev:
http://cr.openjdk.java.net/~erikj/8170280/webrev.top.02
Looks good! So JRE images (incl compact profiles) are stripped and JDK
images has full debug!
Th
Hi Erik,
On 24/11/2016 2:28 AM, Erik Joelsson wrote:
Discovered an issue with cross compiling configurations. In
buildjdk-spec.gmk.in, need to also override the new variable
JVM_VARIANTS_MAIN. New webrev:
http://cr.openjdk.java.net/~erikj/8170284/webrev.02/
Seems reasonable but I don't unders
27 matches
Mail list logo
