Re: RFR: JDK-8171548: JDK bundles changes sym links incorrectly in the legal directory

2016-12-22 Thread Erik Joelsson
On 2016-12-21 18:00, Mandy Chung wrote: On Dec 21, 2016, at 8:52 AM, Erik Joelsson wrote: On 2016-12-21 17:11, Mandy Chung wrote: On Dec 21, 2016, at 4:43 AM, Erik Joelsson wrote: Hello, Please review this very small fix in the bundle creation. The tar --transform parameter, which we u

RFR: JDK-8171859: Configure check for modular boot jdk needs to be updated

2016-12-22 Thread Erik Joelsson
Hello, Configure has a check to see if the boot jdk is module aware/enabled. Like many others, the build needs to adapt its behavior when using such a boot jdk. The current check is no longer compatible with the latest JDK 9 builds: java -version --patch-module foo=bar WARNING: Unknown modul

RFR: libawt_xawt and libawt_headless should not set rpath to $ORIGIN/..

2016-12-22 Thread Erik Joelsson
Hello, The recent removal of the lib/$ARCH directory uncovered an old bug in the building of libawt_xawt and libawt_headless (on Solaris and Linux). Historically, in JDK 7, these two libraries were shipped in a subdir. For them to be able to load additional libraries, an rpath of $ORIGIN/..

Re: RFR: libawt_xawt and libawt_headless should not set rpath to $ORIGIN/..

2016-12-22 Thread Claes Redestad
+1 /Claes On 2016-12-22 14:46, Erik Joelsson wrote: Hello, The recent removal of the lib/$ARCH directory uncovered an old bug in the building of libawt_xawt and libawt_headless (on Solaris and Linux). Historically, in JDK 7, these two libraries were shipped in a subdir. For them to be able to

Re: RFR: libawt_xawt and libawt_headless should not set rpath to $ORIGIN/..

2016-12-22 Thread Tim Bell
Erik: Looks good to me as well. Tim The recent removal of the lib/$ARCH directory uncovered an old bug in the building of libawt_xawt and libawt_headless (on Solaris and Linux). Historically, in JDK 7, these two libraries were shipped in a subdir. For them to be able to load additional librar

Re: RFR: JDK-8171859: Configure check for modular boot jdk needs to be updated

2016-12-22 Thread Mandy Chung
Using —-patch-module is one option. Alternatively, you can use other new options such as: $ java --dry-run -m jdk.compiler/com.sun.tools.javac.Main This stops before invoking the main method. or $ java —-list-modules This lists the observable modules in the image. Mandy > On Dec 22, 201

Re: RFR: JDK-8171859: Configure check for modular boot jdk needs to be updated

2016-12-22 Thread Erik Joelsson
Hello, Thanks for the suggestions. The way the test is currently implemented is using a framework for finding valid JVM parameters. It basically runs: java $ArgToTest -version and parses the output for warnings and verifies that the version was printed. After looking at this more closely, I

Re: RFR: JDK-8171859: Configure check for modular boot jdk needs to be updated

2016-12-22 Thread Erik Joelsson
Here is a new patch, using --list-mods instead, seems cleaner to me. diff -r 84c58139cbd3 common/autoconf/boot-jdk.m4 --- a/common/autoconf/boot-jdk.m4 +++ b/common/autoconf/boot-jdk.m4 @@ -305,9 +305,8 @@ BOOT_JDK_SOURCETARGET="-source 8 -target 8" AC_SUBST(BOOT_JDK_SOURCETARGET) - ADD_J

Re: RFR: JDK-8171859: Configure check for modular boot jdk needs to be updated

2016-12-22 Thread Mandy Chung
+1 Mandy > On Dec 22, 2016, at 8:53 AM, Erik Joelsson wrote: > > Here is a new patch, using --list-mods instead, seems cleaner to me. > > diff -r 84c58139cbd3 common/autoconf/boot-jdk.m4 > --- a/common/autoconf/boot-jdk.m4 > +++ b/common/autoconf/boot-jdk.m4 > @@ -305,9 +305,8 @@ > BOOT_JDK_