RFR: JDK-8172241: Cleanup mistakes in jib publish support change

2017-01-09 Thread Erik Joelsson
Hello, This is a small followup fix for JDK-8170741. It addresses the following: * The new run-test-prebuilt profile is missing the JT_HOME environment variable from boot_jdk. * There are no compact profiles bundles to publish. I have created a new top level target to create these bundles an

Re: RFR: JDK-8172241: Cleanup mistakes in jib publish support change

2017-01-09 Thread Tim Bell
Erik: This is a small followup fix for JDK-8170741. It addresses the following: * The new run-test-prebuilt profile is missing the JT_HOME environment variable from boot_jdk. * There are no compact profiles bundles to publish. I have created a new top level target to create these bundles and e

RFR: JDK-8171932: unresolved macro in javadoc command

2017-01-09 Thread Erik Joelsson
Hello, In the new Javadoc.gmk, there is a problem with a make variable, $(HASH), that doesn't get resolved properly into # in the final html files. My conclusion is that the # character is problematic when being passed inside an argument to one of our named parameter macros. I have fixed this

RFR: JDK-8170862: VarDeps breaks when a file with overridden CFLAGS has the same name as the library

2017-01-09 Thread Erik Joelsson
Hello, VarDeps breaks when a file with overridden CFLAGS has the same name as the library. SetupNativeCompilation(FOO, LIBRARY:=foo, foo_CFLAGS := -DmakeItBreak) We then get the vardeps file for linking the library and the vardeps file for the specific CFLAGS ending up with the same

Re: RFR: JDK-8171932: unresolved macro in javadoc command

2017-01-09 Thread Tim Bell
Erik: In the new Javadoc.gmk, there is a problem with a make variable, $(HASH), that doesn't get resolved properly into # in the final html files. My conclusion is that the # character is problematic when being passed inside an argument to one of our named parameter macros. I have fixed this by

Re: RFR: JDK-8170862: VarDeps breaks when a file with overridden CFLAGS has the same name as the library

2017-01-09 Thread Tim Bell
Hello Erik: VarDeps breaks when a file with overridden CFLAGS has the same name as the library. SetupNativeCompilation(FOO, LIBRARY:=foo, foo_CFLAGS := -DmakeItBreak) We then get the vardeps file for linking the library and the vardeps file for the specific CFLAGS ending up with the sa

Using hard links for debug builds

2017-01-09 Thread Ioi Lam
Hi, libjvm.so gets copied a few times during the build. I usually build slowdebug builds with --with-native-debug-symbols=internal (to make it easier with gdb). This gives me 8 libjvm.so files: ./support/interim-image/lib/server/libjvm.so ./support/modules_libs/java.base/server/libjvm.so ./ho

Re: Using hard links for debug builds

2017-01-09 Thread Kim Barrett
> On Jan 9, 2017, at 3:40 PM, Ioi Lam wrote: > > Hi, > > libjvm.so gets copied a few times during the build. I usually build slowdebug > builds with --with-native-debug-symbols=internal (to make it easier with > gdb). This gives me 8 libjvm.so files: > > ./support/interim-image/lib/server/lib