RFR: JDK-8174064 Tab expansion broken for make

2017-02-07 Thread Magnus Ihse Bursie
With recent versions of the standard bash completion scripts for make, tab expansion targets are extracted using make -pq, while the code only checks for -qp. This fix makes the test more robust to handle both cases. Bug: https://bugs.openjdk.java.net/browse/JDK-8174064 Patch inline: diff --git

Re: RFR: JDK-8174064 Tab expansion broken for make

2017-02-07 Thread Erik Joelsson
Looks good. /Erik On 2017-02-07 09:02, Magnus Ihse Bursie wrote: With recent versions of the standard bash completion scripts for make, tab expansion targets are extracted using make -pq, while the code only checks for -qp. This fix makes the test more robust to handle both cases. Bug: htt

RFR: JDK-8174069 Verify that bash is at least version 3.2

2017-02-07 Thread Magnus Ihse Bursie
The build system uses features in make that was not present before 3.2. Bash 3.2 was released in 2007 so only very old systems is on 3.1 or older. However, we fail with strange error messages on such old systems, so we should check the version in configure. Bug: https://bugs.openjdk.java.net/b

Re: RFR: JDK-8174069 Verify that bash is at least version 3.2

2017-02-07 Thread Erik Joelsson
Looks good. /Erik On 2017-02-07 11:09, Magnus Ihse Bursie wrote: The build system uses features in make that was not present before 3.2. Bash 3.2 was released in 2007 so only very old systems is on 3.1 or older. However, we fail with strange error messages on such old systems, so we should c

Re: make doesn't create failure-logs directory

2017-02-07 Thread Magnus Ihse Bursie
On 2017-01-30 16:28, Mike Burton wrote: While looking at JDK-8173375 I found that `make` does not create the directory `build/linux-x86_64-normal-server-release/make-support/failure-logs` during a failed build. I couldn’t find reference to this in build-dev archives so maybe a new bug? Mike B

Re: make doesn't create failure-logs directory

2017-02-07 Thread Mike Burton
No I can’t reproduce it, not sure why it failed before, sorry to have bothered you. Mike > On 7 Feb 2017, at 14:05, Magnus Ihse Bursie > wrote: > > On 2017-01-30 16:28, Mike Burton wrote: >> While looking at JDK-8173375 I found that `make` does not create the >> directory >> `build/linux-x