Re: RFR: JDK-8176785 Add build support to generate PNG file from .dot file

2017-04-10 Thread Erik Joelsson
On 2017-04-08 00:14, Mandy Chung wrote: Can I build OpenJDK with the docs with module graphs when I have Graphviz installed? I would think we need a configure option to specify my local path to `dot` that will enable the module graph build. Is it possible? Yes, it is possible. Configure will lo

Re: RFR: 8173801 Remove non-client demos and samples

2017-04-10 Thread Erik Joelsson
Hello, CompileDemos.gmk: 270: The $(call install-file) line shouldn't be removed make/Bundles.gmk: 186: Since the client demos are still in there, they still need to be filtered out of the image when creating the JDK bundle. Otherwise this looks ok. /Erik On 2017-04-07 23:05, Alexandre (Sh

Re: RFR: JDK-8176785 Add build support to generate PNG file from .dot file

2017-04-10 Thread Mandy Chung
> On Apr 10, 2017, at 12:07 AM, Erik Joelsson wrote: > > > On 2017-04-08 00:14, Mandy Chung wrote: >> Can I build OpenJDK with the docs with module graphs when I >> have Graphviz installed? I would think we need a configure >> option to specify my local path to `dot` that will enable >> the mod