Re: [jdk10 & jdk8u] Request for Review: 8173654

2017-06-07 Thread Erik Joelsson
The 8u change looks good. In JKD 10 (as well as 9) we have created a macro to handle this so please use something like this: # Hook to include the corresponding custom file, if present. $(eval $(call IncludeCustomExtension, jdk, lib/CoreLibraries.gmk)) /Erik On 2017-06-06 19:01, Rob McKenna w

Re: Cannot link against memset_with_concurrent_readers_sparc.cpp

2017-06-07 Thread Severin Gehwolf
Hi, On Wed, 2017-06-07 at 02:10 +0200, John Paul Adrian Glaubitz wrote: > Hi! > > I'm still working on fixing OpenJDK-9 on Linux/sparc64 and I'm currently > running into something which should be a trivial Makefile issue which > is a linker problem (see for the paste below, full log in [1]). > >

Re: Cannot link against memset_with_concurrent_readers_sparc.cpp

2017-06-07 Thread John Paul Adrian Glaubitz
On Wed, Jun 07, 2017 at 11:29:39AM +0200, Severin Gehwolf wrote: > > Does anyone who is more familiar with the build system have an idea > > where to look? > > This is likely a question for build-dev (CC). They might have some > pointers. Ok, thanks, I'll ask over there. Adrian -- .''`. John

Re: Cannot link against memset_with_concurrent_readers_sparc.cpp

2017-06-07 Thread Erik Joelsson
Hello John, If the cpp file is compiled for libjvm.so, the object file should automatically end up on the link command line. I found your build log in the original email. The link command line is: /usr/bin/sparc64-linux-gnu-g++-6 -Wl,-z,defs -Wl,-z,noexecstack -Wl,-O1 -Wl,-z,relro -shared -X

Re: Cannot link against memset_with_concurrent_readers_sparc.cpp

2017-06-07 Thread John Paul Adrian Glaubitz
On Wed, Jun 07, 2017 at 12:05:26PM +0200, Erik Joelsson wrote: > Can you check the contents of this file to verify that the object file in > question is actually missing: > > /<>/build-zero/hotspot/variant-zero/libjvm/objs/_BUILD_LIBJVM_objectfilenames.txt Yes, it's missing, see [1]. Adrian > [

Re: Cannot link against memset_with_concurrent_readers_sparc.cpp

2017-06-07 Thread Mikael Gerdin
Hi, On 2017-06-07 13:05, John Paul Adrian Glaubitz wrote: On Wed, Jun 07, 2017 at 12:05:26PM +0200, Erik Joelsson wrote: Can you check the contents of this file to verify that the object file in question is actually missing: /<>/build-zero/hotspot/variant-zero/libjvm/objs/_BUILD_LIBJVM_objectf

Re: Cannot link against memset_with_concurrent_readers_sparc.cpp

2017-06-07 Thread John Paul Adrian Glaubitz
On Wed, Jun 07, 2017 at 01:42:47PM +0200, Mikael Gerdin wrote: > I think the problem is that your build configuration is ZERO but the file > memset_with_concurrent_readers_sparc.cpp is in the cpu/sparc directory and > will only be visible if building a native (non-zero) SPARC config. That's a *ver

Re: [jdk10 & jdk8u] Request for Review: 8173654

2017-06-07 Thread Rob McKenna
Ack, its there already. Didn't notice it. Thanks Erik, -Rob On 07/06/17 09:16, Erik Joelsson wrote: > The 8u change looks good. In JKD 10 (as well as 9) we have created a macro > to handle this so please use something like this: > > # Hook to include the corresponding custom file, if present

Re: [jdk10 & jdk8u] Request for Review: 8173654

2017-06-07 Thread Erik Joelsson
Right, it is, I missed it too. /Erik On 2017-06-07 14:30, Rob McKenna wrote: Ack, its there already. Didn't notice it. Thanks Erik, -Rob On 07/06/17 09:16, Erik Joelsson wrote: The 8u change looks good. In JKD 10 (as well as 9) we have created a macro to handle this so please use somet

RFR: JDK-8178064: OpenJDK RI binary should include the license file for freetype

2017-06-07 Thread Erik Joelsson
Hello, Please review this late change for JDK 9. It adds a new configure parameter --with-freetype-license, which can optionally be set to point to a license file for freetype. If freetype bundling is enabled, this license file will be included in the java.desktop.jmod file and subsequently i

Re: RFR: JDK-8178064: OpenJDK RI binary should include the license file for freetype

2017-06-07 Thread Tim Bell
Erik: Please review this late change for JDK 9. It adds a new configure parameter --with-freetype-license, which can optionally be set to point to a license file for freetype. If freetype bundling is enabled, this license file will be included in the java.desktop.jmod file and subsequently in th

RFR: JDK10: JDK-8180334: Unable to build jaotc launcher on windows

2017-06-07 Thread Kumar Srinivasan
Hello, Please review the changes to fix JDK-8180334, essentially -DJAVA_ARGS exceeds a Visual Studio C++ compiler limit, and this fix provides a way to specify very long string literals, by the build system. This also includes some minor and subtle simplifications and cleanups wrt. the JAVA

RFR: 8086005: Define __STDC_xxx_MACROS config macros globally via build system

2017-06-07 Thread Kim Barrett
Please review this change to the build of hotspot to globally define the __STDC_xxx_MACROS macros via the command line, rather than via #defines scattered through several header files. CR: https://bugs.openjdk.java.net/browse/JDK-8086005 Webrev: http://cr.openjdk.java.net/~kbarrett/8086005/hs.00/

Re: RFR: JDK10: JDK-8180334: Unable to build jaotc launcher on windows

2017-06-07 Thread Mandy Chung
> On Jun 7, 2017, at 2:58 PM, Kumar Srinivasan > wrote: > > Hello, > > Please review the changes to fix JDK-8180334, essentially -DJAVA_ARGS > exceeds > a Visual Studio C++ compiler limit, and this fix provides a way to specify > very long string literals, by the build system. > > This al

Re: RFR: JDK10: JDK-8180334: Unable to build jaotc launcher on windows

2017-06-07 Thread Erik Joelsson
Hello, Build changes look good with Mandy's correction. I would also like a comment sentence explaining the reason for EXTRA_JAVA_ARGS in LauncherCommon.gmk. Otherwise we risk cleaning this away in the future. /Erik On 2017-06-08 03:12, Mandy Chung wrote: On Jun 7, 2017, at 2:58 PM, Kumar

Re: RFR: 8086005: Define __STDC_xxx_MACROS config macros globally via build system

2017-06-07 Thread Erik Joelsson
Build changes look good to me. /Erik On 2017-06-08 01:51, Kim Barrett wrote: Please review this change to the build of hotspot to globally define the __STDC_xxx_MACROS macros via the command line, rather than via #defines scattered through several header files. CR: https://bugs.openjdk.java.n