RFR: JDK-8181776 Move specs again

2017-06-08 Thread Magnus Ihse Bursie
We need to move back spacs to closed due to legal considerations. Here is the open part. Bug: https://bugs.openjdk.java.net/browse/JDK-8181776 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8181776-move-back-specs/webrev.01 /Magnus

Re: RFR: JDK-8178064: OpenJDK RI binary should include the license file for freetype

2017-06-08 Thread Magnus Ihse Bursie
Erik, My only concern is that when doing the bundling, we assume that FREETYPE_LICENSE is set, but no verification of this is done in configure. That is, either should the SetupCopyFiles block be conditional on the license file existing, or the code in LIB_SETUP_FREETYPE should verify that we

Re: RFR: JDK-8181776 Move specs again

2017-06-08 Thread Erik Joelsson
Looks good. /Erik On 2017-06-08 10:50, Magnus Ihse Bursie wrote: We need to move back spacs to closed due to legal considerations. Here is the open part. Bug: https://bugs.openjdk.java.net/browse/JDK-8181776 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8181776-move-back-specs/webrev.01 /M

Re: RFR: JDK-8178064: OpenJDK RI binary should include the license file for freetype

2017-06-08 Thread Erik Joelsson
Hello, On 2017-06-08 10:56, Magnus Ihse Bursie wrote: Erik, My only concern is that when doing the bundling, we assume that FREETYPE_LICENSE is set, but no verification of this is done in configure. That is, either should the SetupCopyFiles block be conditional on the license file existing,

Re: RFR: 8086005: Define __STDC_xxx_MACROS config macros globally via build system

2017-06-08 Thread Kim Barrett
> On Jun 8, 2017, at 2:28 AM, Erik Joelsson wrote: > > Build changes look good to me. Thanks. > /Erik > > > On 2017-06-08 01:51, Kim Barrett wrote: >> Please review this change to the build of hotspot to globally define >> the __STDC_xxx_MACROS macros via the command line, rather than >> via

Re: RFR: JDK-8178064: OpenJDK RI binary should include the license file for freetype

2017-06-08 Thread Magnus Ihse Bursie
On 2017-06-08 11:28, Erik Joelsson wrote: Hello, On 2017-06-08 10:56, Magnus Ihse Bursie wrote: Erik, My only concern is that when doing the bundling, we assume that FREETYPE_LICENSE is set, but no verification of this is done in configure. That is, either should the SetupCopyFiles block be

RFR: JDK-8181788: Unable to build JDK10 on SPARC-M8 machines

2017-06-08 Thread Erik Joelsson
The default boot jdk for jdk10 is still 8GA. This jdk is known not to run on newer sparc hardware, which was addressed for generation 7 in JDK-8176271 and JDK-8162354. Now we need to run on the gen 8 chips and are facing the same issue. Bug: https://bugs.openjdk.java.net/browse/JDK-8181788 Pa

Re: RFR: JDK-8181788: Unable to build JDK10 on SPARC-M8 machines

2017-06-08 Thread Tim Bell
Erik: The default boot jdk for jdk10 is still 8GA. This jdk is known not to run on newer sparc hardware, which was addressed for generation 7 in JDK-8176271 and JDK-8162354. Now we need to run on the gen 8 chips and are facing the same issue. Bug: https://bugs.openjdk.java.net/browse/JDK-818178

Re: RFR: JDK-8181788: Unable to build JDK10 on SPARC-M8 machines

2017-06-08 Thread Magnus Ihse Bursie
On 2017-06-08 14:50, Erik Joelsson wrote: The default boot jdk for jdk10 is still 8GA. This jdk is known not to run on newer sparc hardware, which was addressed for generation 7 in JDK-8176271 and JDK-8162354. Now we need to run on the gen 8 chips and are facing the same issue. Bug: https://

Re: RFR: JDK10: JDK-8180334: Unable to build jaotc launcher on windows

2017-06-08 Thread Kumar Srinivasan
1. Added a comment in the LauncherCommon.gmk, fixed typo 2. Added checks for spurious EXTRA_JAVA_ARGS, both as compile time and runtime check, the latter for a good measure. Thanks Kumar PS: Mandy, could you please file a RFE for the jlink requirements and assign it to me. On Jun 7, 20

Re: RFR: JDK10: JDK-8180334: Unable to build jaotc launcher on windows

2017-06-08 Thread Kumar Srinivasan
Oops here are the webrevs: Delta webrev: http://cr.openjdk.java.net/~ksrini/8180334/webrev.01/webrev.delta/ Full webrev: http://cr.openjdk.java.net/~ksrini/8180334/webrev.01/ Kumar 1. Added a comment in the LauncherCommon.gmk, fixed typo 2. Added checks for spurious EXTRA_JAVA_ARGS, both as

Re: RFR: JDK10: JDK-8180334: Unable to build jaotc launcher on windows

2017-06-08 Thread Erik Joelsson
Looks good to me. /Erik On 2017-06-08 17:17, Kumar Srinivasan wrote: Oops here are the webrevs: Delta webrev: http://cr.openjdk.java.net/~ksrini/8180334/webrev.01/webrev.delta/ Full webrev: http://cr.openjdk.java.net/~ksrini/8180334/webrev.01/ Kumar 1. Added a comment in the LauncherCom

Re: RFR: 8086005: Define __STDC_xxx_MACROS config macros globally via build system

2017-06-08 Thread Gerard Ziemski
hi Kim, My understanding is that to enable c++11, for example, we need to do 2 things (at least on Mac OS X): #1 For the compilation phase we need to add “-std=c++11 -stdlib=libc++”, where “-std=c++11” selects the language model, and “-stdlib=libc++” selects the corresponding headers. #2 For