Hi Erik!
On Thu, Jul 06, 2017 at 02:55:53PM +0200, Erik Helin wrote:
> >Yes, you now have two reviewers. But for these changes (hotspot) you
> >need a sponsor, which needs to be an Oracle employee, which I am not.
> >
> >Maybe Eric could sponsor the change?
>
> Yep, I can shepherd the patches in
After Simons question , I checked that the jdk10 builds still works with
gcc 4.7 on linux x86_64 as well .
And created a new webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8184338.1/
- check adjusted to minimum gcc 4.7
- common/doc/building.mdadjusted (the part talking about
On 07/14/2017 11:23 AM, John Paul Adrian Glaubitz wrote:
Hi Erik!
On Thu, Jul 06, 2017 at 02:55:53PM +0200, Erik Helin wrote:
Yes, you now have two reviewers. But for these changes (hotspot) you
need a sponsor, which needs to be an Oracle employee, which I am not.
Maybe Eric could sponsor the
Looks good to me.
/Erik
On 2017-07-14 13:47, Baesken, Matthias wrote:
After Simons question , I checked that the jdk10 builds still works with
gcc 4.7 on linux x86_64 as well .
And created a new webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8184338.1/
- check adjusted to minim
This looks good to me.
/Erik
On 2017-07-14 13:47, Baesken, Matthias wrote:
After Simons question , I checked that the jdk10 builds still works with
gcc 4.7 on linux x86_64 as well .
And created a new webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8184338.1/
- check adjusted to
Hi Matthias,
Thanks very much for making this change.
Best regards,
Simon
On 14/07/2017 12:47, Baesken, Matthias wrote:
After Simons question , I checked that the jdk10 builds still works with
gcc 4.7 on linux x86_64 as well .
And created a new webrev :
http://cr.openjdk.java.net/~mbaes
I realized I spoke too soon. I won't be able to sponsor this anytime
soon as I'm about to leave on vacation now. Hopefully someone else will
be able to pick this up for you.
/Erik
On 2017-07-14 08:53, Erik Joelsson wrote:
This looks good to me. Never mind the regexps, they are fine.
I can s
Thanks , can you push it ( as far as I know someone from Oracle needs to push
it because generated-configure.sh is changed ) ?
Best regards, Matthias
-Original Message-
From: Erik Joelsson [mailto:erik.joels...@oracle.com]
Sent: Freitag, 14. Juli 2017 14:43
To: Baesken, Matthias ; Si
I can pick this up and sponsor it, but as Erik wrote, I'll be pushing to
jdk10/jdk10.
Tim
On 07/14/17 07:02, Erik Joelsson wrote:
I realized I spoke too soon. I won't be able to sponsor this anytime
soon as I'm about to leave on vacation now. Hopefully someone else will
be able to pick this up
No problem, and thanks for picking this up. And thanks, Erik, for the review
and advice.
Paul
On 7/14/17, 9:04 AM, "Tim Bell" wrote:
I can pick this up and sponsor it, but as Erik wrote, I'll be pushing to
jdk10/jdk10.
Tim
On 07/14/17 07:02, Erik Joelsson wrote:
Hi Nishit,
I haven't seen any comments in the past month...
From the code perspective, this looks ok.
It should have a build Reviewer too.
Thanks, Roger
On 6/13/2017 12:57 PM, Nishit Jain wrote:
Hi,
Please review the fix for JDK-8176583
Bug: https://bugs.openjdk.java.net/browse/JDK-8176583
Hi Baesken,
Thank you for making the changes.
Related to the change in universe_init() (universe.cpp), the 'if
(DumpSharedSpaces)’ block at line 715 is also CDS only. To be consistent, you
might want to include it under #if INCLUDE_CDS as well.
--- 695,716
Universe::_loader_addClass_ca
12 matches
Mail list logo
