Nice work so far and good luck with trying to fix the real issues!
/Erik
On 2017-10-07 10:14, Peter Budai wrote:
The configure of OpenJDK overwrites the SHELL. Actually it is using
bash, but for the arguments it was using “-e -o pipefail”. I have
figured that for MSYS2 bash what is needed a
Please review my second attempt at fixing this issue. The last time a
bug in Jib caused problems on Windows. This has now been fixed so we can
apply this patch again.
Bug: https://bugs.openjdk.java.net/browse/JDK-8188910
Webrev: http://cr.openjdk.java.net/~erikj/8188910/webrev.01/
/Erik
Hi Erik,
Looks okay ... again :)
Thanks,
David
On 9/10/2017 7:59 PM, Erik Joelsson wrote:
Please review my second attempt at fixing this issue. The last time a
bug in Jib caused problems on Windows. This has now been fixed so we can
apply this patch again.
Bug: https://bugs.openjdk.java.net
After the repo consolidation, I missed updating the
IncludeCustomExtension calls for the JtregNative*.gmk files. This causes
tests to fail for us since the native libraries have not been built.
Bug: https://bugs.openjdk.java.net/browse/JDK-8188050
Webrev: http://cr.openjdk.java.net/~erikj/8188
Erik:
After the repo consolidation, I missed updating the
IncludeCustomExtension calls for the JtregNative*.gmk files. This causes
tests to fail for us since the native libraries have not been built.
Bug: https://bugs.openjdk.java.net/browse/JDK-8188050
Webrev: http://cr.openjdk.java.net/~erik
Erik-
Looks good to me as well.
/Tim
On 10/09/17 11:25, David Holmes wrote:
Hi Erik,
Looks okay ... again :)
Thanks,
David
On 9/10/2017 7:59 PM, Erik Joelsson wrote:
Please review my second attempt at fixing this issue. The last time a
bug in Jib caused problems on Windows. This has now b
