> This isn't really a question for build-dev. It should be brought to the
> component team owning that particular source. I believe in this case
> that would be 2d-dev.
> /Erik
Hi Erik,
This has been mentioned. One of my responses yesterday indicates I raised
a counterpart in 2d-dev already.
Hi All
I sent an email to the 2d-dev list yesterday, but I'll respond here as
well
so you guys know I'm not ignoring you. :)
> This is all correct, thanks David!
>
> For the official toolchains (basically what Oracle builds with), we very
> much like to keep warnings-as-errors active, because
Currently, we require all developers who modify the configure script to
run autoconf locally, to update the generated-configure.sh script, which
is then checked in. This is the only instance of checked in "compiled"
code in OpenJDK, and this has brought along several problems:
* Only a specifi
On Thu, 2018-01-18 at 14:28 +0100, Magnus Ihse Bursie wrote:
> Currently, we require all developers who modify the configure script to
> run autoconf locally, to update the generated-configure.sh script, which
> is then checked in. This is the only instance of checked in "compiled"
> code in Ope
On 1/18/18 5:28 AM, Magnus Ihse Bursie wrote:
* Only a specific version of autoconf, 2.69, can be used, to avoid
large code changes in the generated file. Unfortunately, Ubuntu ships
a version of autoconf that claims to be 2.69 but is actually heavily
patched. This requires all Ubuntu users
On 2018-01-18 07:42, Jonathan Gibbons wrote:
On 1/18/18 5:28 AM, Magnus Ihse Bursie wrote:
* Only a specific version of autoconf, 2.69, can be used, to avoid
large code changes in the generated file. Unfortunately, Ubuntu ships
a version of autoconf that claims to be 2.69 but is actually h
I tried building from the jdk repo (vs jdk10). The StringPlatformChars test
passed. The other four tests appear to have been removed.
However, I did get failures on these tests:
• MethodHandleConstants (internal error: appendix)
• JavadocHelperTest (out of memory — Java heap spac
Hello Adam,
When adding a disabled warning like this, we need to also add a clear
comment describing why it's necessary. In this case it's caused by a bug
in GCC and only affects certain versions. Otherwise, we will likely try
to remove them later and without information on why it was added, w
On 1/18/18 8:39 AM, Erik Joelsson wrote:
On 2018-01-18 07:42, Jonathan Gibbons wrote:
On 1/18/18 5:28 AM, Magnus Ihse Bursie wrote:
* Only a specific version of autoconf, 2.69, can be used, to avoid
large code changes in the generated file. Unfortunately, Ubuntu
ships a version of autoc
Hi!
On 01/18/2018 06:27 PM, Erik Joelsson wrote:
When adding a disabled warning like this, we need to also add a clear comment
describing why it's necessary. In this case it's caused by a bug in GCC and only
affects certain versions. Otherwise, we will likely try to remove them later and
without
Hello Magnus,
Nice to see this finally happening!
In building.md, when getting autoconf for Cygwin, I believe you also
need the autoconf wrapper scripts package. Perhaps it's also worth
mentioning that you can download the autoconf src and build/install from
there?
In jib-profiles.js, you n
Try again with build-dev cc'd ..
-phil.
On 01/18/2018 11:14 AM, Phil Race wrote:
I agree with what Erik said on build-dev that being specific about the
tool chain
and the reason are worthwhile and important. We've done that in
similar cases.
Also these review threads usually should have a su
I agree with what Erik said on build-dev that being specific about the
tool chain
and the reason are worthwhile and important. We've done that in similar
cases.
Also these review threads usually should have a subject like
RFR: :
which means you first need a bug id .. the patch can't be pushed
On 19/01/2018 3:20 AM, Alan Snyder wrote:
I tried building from the jdk repo (vs jdk10). The StringPlatformChars test
passed. The other four tests appear to have been removed.
However, I did get failures on these tests:
• MethodHandleConstants (internal error: appendix)
>• MethodR
On 18/01/2018 11:28 PM, Magnus Ihse Bursie wrote:
Currently, we require all developers who modify the configure script to
run autoconf locally, to update the generated-configure.sh script, which
is then checked in. This is the only instance of checked in "compiled"
code in OpenJDK, and this has
Just apply the patch and you can try it. The current version of the patch is
somewhat broken on windows though, needs another iteration.
/Erik
Sent from BlueMail
On Jan 18, 2018, 18:14, at 18:14, David Holmes wrote:
>On 18/01/2018 11:28 PM, Magnus Ihse Bursie wrote:
>> Currently, we require
On 01/18/2018 05:51 PM, David Holmes wrote:
On 19/01/2018 3:20 AM, Alan Snyder wrote:
I tried building from the jdk repo (vs jdk10). The
StringPlatformChars test passed. The other four tests appear to have
been removed.
However, I did get failures on these tests:
• MethodHandleConstant
Differing projects have come to different conclusions about whether to
include a generated configure.
But the standard seems to be to include one. The mantra is: "./configure &&
make" without an autoconf step. The number of people building openjdk is
much larger than the number of people patching
Another possibility is implementing the invariant that configure is
generated via autoconf 2.69 by a mercurial commit hook.
On Thu, Jan 18, 2018 at 10:18 PM, Martin Buchholz
wrote:
> Differing projects have come to different conclusions about whether to
> include a generated configure.
>
> But t
On 01/19/2018 07:18 AM, Martin Buchholz wrote:
Differing projects have come to different conclusions about whether to
include a generated configure.
But the standard seems to be to include one. The mantra is: "./configure &&
make" without an autoconf step.
And this is still the mantra (except
On 2018-01-19 07:18, Martin Buchholz wrote:
Differing projects have come to different conclusions about whether to
include a generated configure.
But the standard seems to be to include one. The mantra is:
"./configure && make" without an autoconf step. The number of people
building openjdk i
On 2018-01-19 08:08, Erik Helin wrote:
On 01/19/2018 07:18 AM, Martin Buchholz wrote:
Differing projects have come to different conclusions about whether to
include a generated configure.
But the standard seems to be to include one. The mantra is:
"./configure &&
make" without an autoconf ste
22 matches
Mail list logo
