RFR: JDK-8196218: [linux] libfontmanager should be linked against headless awt library

Hi, Could I please get a review for this rather small patch which originally occurred for us on JDK 8 (Fedora) which recently switched to building with "-Wl,-z,defs" linker flags. The result was a build failure, due to unresolved symbols. Indeed libfontmanager.so should have -lawt_headless in the

Re: RFR: JDK-8196218: [linux] libfontmanager should be linked against headless awt library

Hello Severin, If adding the -lawt_headless makes the code compile with -Wl,-z,defs, then I would also like to see that filtering removed in the same patch. However, I think someone from 2d needs to shed some light on the origin of this. I would assume that at some point there was a reason for

Re: [OpenJDK 2D-Dev] RFR: JDK-8196218: [linux] libfontmanager should be linked against headless awt library

When this was fixed for Solaris https://bugs.openjdk.java.net/browse/JDK-8071710 the observed problem was not building (although it could have been) but at runtime. I think you can verify what you've done with "ldd" .. This patch adds awt_headless.so, but does not remove awt.so. Perhaps the li

Re: RFR: JDK-8196218: [linux] libfontmanager should be linked against headless awt library

Hi Erik, Thanks for the feedback! On Fri, 2018-01-26 at 08:27 -0800, Erik Joelsson wrote: > Hello Severin, > > If adding the -lawt_headless makes the code compile with -Wl,-z,defs, > then I would also like to see that filtering removed in the same patch. Agreed. > However, I think someone fro

Re: [OpenJDK 2D-Dev] RFR: JDK-8196218: [linux] libfontmanager should be linked against headless awt library

On 2018-01-26 08:44, Phil Race wrote: When this was fixed for Solaris https://bugs.openjdk.java.net/browse/JDK-8071710 the observed problem was not building (although it could have been) but at runtime. I think you can verify what you've done with "ldd" .. This patch adds awt_headless.so, but

Re: [OpenJDK 2D-Dev] RFR: JDK-8196218: [linux] libfontmanager should be linked against headless awt library

On Fri, 2018-01-26 at 08:54 -0800, Erik Joelsson wrote: > On 2018-01-26 08:44, Phil Race wrote: > > When this was fixed for Solaris > > https://bugs.openjdk.java.net/browse/JDK-8071710 > > the observed problem was not building (although it could have been) > > but at runtime. > > I think you can

Re: [OpenJDK 2D-Dev] RFR: JDK-8196218: [linux] libfontmanager should be linked against headless awt library

And the SCCS history which pre-dates mercurial says it was added by Kelly O'Hair who was the JDK build lead at the time .. so not added by 2D. D 1.86.1.1 07/03/21 18:00:55 ohair 187 185 7/0/00163 6537329: Move JdbcOdbc (JDBC-ODBC Bridge) to closed https://bugs.openjdk.java.net/brow

Re: [OpenJDK 2D-Dev] RFR: JDK-8196218: [linux] libfontmanager should be linked against headless awt library

Interesting, so this was probably just Kelly trying to get things to build. /Erik On 2018-01-26 09:09, Phil Race wrote: And the SCCS history which pre-dates mercurial says it was added by Kelly O'Hair who was the JDK build lead at the time .. so not added by 2D. D 1.86.1.1 07/03/21 18:00:55

Re: [OpenJDK 2D-Dev] RFR: JDK-8196218: [linux] libfontmanager should be linked against headless awt library

On 2018-01-26 09:02, Severin Gehwolf wrote: On Fri, 2018-01-26 at 08:54 -0800, Erik Joelsson wrote: On 2018-01-26 08:44, Phil Race wrote: When this was fixed for Solaris https://bugs.openjdk.java.net/browse/JDK-8071710 the observed problem was not building (although it could have been) but at r

Re: [OpenJDK 2D-Dev] RFR: JDK-8196218: [linux] libfontmanager should be linked against headless awt library

On 01/26/2018 09:02 AM, Severin Gehwolf wrote: Any thoughts on the LDFLAGS filtering? Shouldn't this only be done on platforms that need it? solaris, linux, aix should already be fine without filtering. Only to say I really don't understand it :-) But I think it is historical baggage. Erik

Re: [OpenJDK 2D-Dev] RFR: JDK-8196218: [linux] libfontmanager should be linked against headless awt library

This patch builds on Solaris: diff -r 50cd89fe209f make/lib/Awt2dLibraries.gmk --- a/make/lib/Awt2dLibraries.gmk +++ b/make/lib/Awt2dLibraries.gmk @@ -683,15 +683,15 @@ hidevf w_novirtualdescr arrowrtn2, \ DISABLED_WARNINGS_microsoft := 4267 4244 4018 4090 4996 4146 4334 4819 4101,

Re: [OpenJDK 2D-Dev] RFR: JDK-8196218: [linux] libfontmanager should be linked against headless awt library

On Fri, 2018-01-26 at 09:18 -0800, Phil Race wrote: > > On 01/26/2018 09:02 AM, Severin Gehwolf wrote: > > Any thoughts on the LDFLAGS filtering? Shouldn't this only be done on > > platforms that need it? solaris, linux, aix should already be fine > > without filtering. > > Only to say I really d

Re: [OpenJDK 2D-Dev] RFR: JDK-8196218: [linux] libfontmanager should be linked against headless awt library

> I could not remove -lawt however. Ah yes, Erik sent me the errors and yes there are some 2D functions that are defined in libawt that fontmanager needs for text rendering support, so we can't remove that. libawt on these platforms with separate headless and xawt libraries could have more ap

RFR: 8196197 - Enable the make system to calculate concurrency for JDK tests

Please review this small change that makes the JDK make test target use the same method for calculating jtreg concurrency as Hotspot. Verified locally and in Mach5. Webrev: http://cr.openjdk.java.net/~ctornqvi/webrev/8196197/webrev.00/

Re: RFR: 8196197 - Enable the make system to calculate concurrency for JDK tests

This looks good to me. Note to other reviewers. This change only applies when concurrency isn't being set by some other entity. Other entities include the top level makefiles (typically when running "make test TEST=") or by setting CONCURRENCY= on the make command line. The reason for this ch

Re: RFR: 8196197 - Enable the make system to calculate concurrency for JDK tests

Code motion (in Makefiles)... Looks good to me as well. Tim On 01/26/18 14:49, Erik Joelsson wrote: This looks good to me. Note to other reviewers. This change only applies when concurrency isn't being set by some other entity. Other entities include the top level makefiles (typically when ru

RFR: JDK-8196108: Add build support for VS 2015/2017

Oracle is planning on changing the toolchain versions used to produce Oracle builds of OpenJDK in JDK 11. As a first step towards changing the Windows toolchain versions, I'm implementing the basic support in the build system for both recognizing the newer versions of Visual Studio as well as g