RFR: JDK-8198859 Use elfedit to silence linker warnings on solaris

Solaris builds have always produced a lot of warnings when linking, like this: ld: fatal: symbol '__JvmOffsets' has differing types:     (file /export/home/magnusi/hg/sandbox-cflags/build/solaris-sparcv9/hotspot/variant-server/libjvm/objs/JvmOffsets.o type=OBJT; file /export/home/magnusi/hg/s

jdk10 bootcycle build linux failing

Hi, I have an issue with bootcycle build. First run with external boot jdk is ok, but bootcycle phase always fails. I'm building on fedora27(local) and rhel7(VM). In case of local, build consume too much memory and kill my OS. I've tried to set `with-memory-size` but it seems like it accepts t

Problems of building JDK 10 on Windows 7 machine

Hi, I am trying to build JDK 10 from http://hg.openjdk.java.net/jdk10/jdk10 and also using JIB (JIB_SERVER=https://java.se.oracle.com/artifactory) to configure/make as the following: bash get_source.sh bash common/bin/jib.sh configure bash common/bin/jib.sh make It seems that test_json.cpp c

Re: RFR: JDK-8198859 Use elfedit to silence linker warnings on solaris

Magnus: Solaris builds have always produced a lot of warnings when linking, like this: ld: fatal: symbol '__JvmOffsets' has differing types: (file /export/home/magnusi/hg/sandbox-cflags/build/solaris-sparcv9/hotspot/variant-server/libjvm/objs/JvmOffsets.o type=OBJT; file /export/home/magnu

Re: RFR JDK-8197533 move javax.transaction.xa into its own module

> On Feb 28, 2018, at 8:29 PM, Paul Sandoz wrote: > > > >> On Feb 28, 2018, at 1:22 PM, Lance Andersen > > wrote: >> >>> >>> On Feb 28, 2018, at 2:20 PM, Lance Andersen >> > wrote: >>> >>> Hi Paul, >>> >>> Thank you for th

Re: RFR JDK-8197533 move javax.transaction.xa into its own module

+1 > On Mar 1, 2018, at 8:59 AM, Lance Andersen wrote: >> >> +1, i second Joe’s request to update package-info.java while we are >> opportunistically cleaning this area up. > > Per your and Joe’s request, please see > cr.openjdk.java.net/~lancea/8197533/webrev.02 >

Re: [urgent][jdk10] RFR: JDK-8198658 Docs still point to JDK 9 docs

On 2018-02-26 12:57, joe darcy wrote: Hi Magnus, Looks okay for now, but longer term should the version be queried from the environment some way? The problem as I understand it is that the URL is dead until the docs team creates it, which doesn't necessarily happen in sync with us bumping

Re: RFR(S) 8197453 : Add support of extra problem list

Makefile change looks good. /Erik On 2018-02-27 09:45, Ekaterina Pavlova wrote: Jon, thanks for the review. I have updated the webrev. thanks, -katya On 2/26/18 12:02 PM, Jonathan Gibbons wrote: If these new problem-list files are destined for use by jtreg, I would encourage adding a plat

Re: RFR 8198834: (ch) Enable java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java on linux-x64

On 01/03/2018 18:44, Brian Burkhalter wrote: On Feb 28, 2018, at 8:34 AM, Alan Bateman > wrote: This look okay but I think we should looking at creating this .so in the build, like we do for libDirectIO.so to create the shared library needed for the direct I/O t

Re: RFR 8198834: (ch) Enable java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java on linux-x64

On Mar 1, 2018, at 11:52 AM, Alan Bateman wrote: > The rename of Launcher.c looks a bit strange, the original name looks better > to me. The C source file beginning with “lib” is a requirement of the jtreg native test build. > I see it doesn't have a copyright header so we should fix that. Fo

Re: RFR 8198834: (ch) Enable java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java on linux-x64

On 01/03/2018 20:06, Brian Burkhalter wrote: On Mar 1, 2018, at 11:52 AM, Alan Bateman > wrote: The rename of Launcher.c looks a bit strange, the original name looks better to me. The C source file beginning with “lib” is a requirement of the jtreg native te

Re: RFR 8198834: (ch) Enable java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java on linux-x64

On Mar 1, 2018, at 12:17 PM, Alan Bateman wrote: >> The C source file beginning with “lib” is a requirement of the jtreg native >> test build. > Okay, we might have to live with it for now but hopefully it can be fixed to > be able to use sensible source file names in the future. Webrev update

Re: RFR 8198834: (ch) Enable java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java on linux-x64

On 01/03/2018 20:21, Brian Burkhalter wrote: On Mar 1, 2018, at 12:17 PM, Alan Bateman > wrote: The C source file beginning with “lib” is a requirement of the jtreg native test build. Okay, we might have to live with it for now but hopefully it can be fixed to

Re: jdk10 bootcycle build linux failing

Hello Michal, The --with-memory-size option is only used to help configure pick a more reasonable concurrency level for make. If your machine still gets overwhelmed, I would recommend manually turning down concurrency until you get it to work, using "make JOBS=X". You can check the end of the

Re: RFR 8198834: (ch) Enable java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java on linux-x64

These native test libs all need to live in the same global namespace, basically the same java.library.path directory. In this context, "libLauncher" doesn't look very unique and descriptive given that it originates from java/nio/channels/spi/SelectorProvider/inheritedChannel. Could we change it

Re: RFR 8198834: (ch) Enable java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java on linux-x64

HI Erik, You caught me just shy of checking this in. :-) I can change it to something else like “libInheritedChannelLauncher” or “libInheritedChannel.” Thanks, Brian On Mar 1, 2018, at 2:07 PM, Erik Joelsson wrote: > These native test libs all need to live in the same global namespace, > b

Re: RFR: JDK-8198859 Use elfedit to silence linker warnings on solaris

Hello Magnus, This is a nice fix! I would prefer if the shell expression wasn't executed on every re-make. In this case it can easily be fixed by changing := to =. There is only one use of DTRACE_ELFEDIT_COMMANDS so it will only be evaluated once, and since it's in a recipe line, it will only

Re: RFR: JDK-8198862 Stop doing funky compilation stuff for dtrace

Hello, I don't think you can remove the extra ( ) around the preprocessor commands. I added those to avoid race conditions in JDK-8158629. My conclusion then was that any command that redirected stdout needed to be wrapped in (). Otherwise this looks ok. /Erik On 2018-02-28 16:48, Magnus

Re: RFR 8198834: (ch) Enable java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java on linux-x64

Either works for me. Thanks! /Erik On 2018-03-01 14:09, Brian Burkhalter wrote: HI Erik, You caught me just shy of checking this in. :-) I can change it to something else like “libInheritedChannelLauncher” or “libInheritedChannel.” Thanks, Brian On Mar 1, 2018, at 2:07 PM, Erik Joelsson

Re: RFR 8198834: (ch) Enable java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java on linux-x64

I think shorter is better: http://cr.openjdk.java.net/~bpb/8198834/webrev.01/ I’ll hold off pushing until Alan comments again. Thanks, Brian On Mar 1, 2018, at 2:50 PM, Erik Joelsson wrote: > Either works for me. Thanks! > > /Erik > > > On 2018-03-01 14:09, Brian Burkhalter wrote: >> HI E

Re: RFR 8198834: (ch) Enable java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java on linux-x64

Note that you also need to update the declarations in the makefile. /Erik On 2018-03-01 14:53, Brian Burkhalter wrote: I think shorter is better: http://cr.openjdk.java.net/~bpb/8198834/webrev.01/ I’ll hold off pushing until Alan comme

Re: RFR: JDK-8198844 Clean up GensrcX11Wrappers

Hello, In xlibtypes.txt comment, should it be sizes-64.txt? Generating both 32 and 64 seems a bit outdated at this point. Surely this is a remnant of bundling 64 and 32 bit together on Solaris in the past? Perhaps someone in 2d can answer this? Would be nice to be able to clean up that part a

Re: RFR: JDK-8198751 Refactor SetupNativeCompilation to take NAME and TYPE

Looks good. /Erik On 2018-02-27 03:15, Magnus Ihse Bursie wrote: Currently, SetupNativeCompilation takes as "main" argument either LIBRARY := $name, PROGRAM := $name or STATIC_LIBRARY := $name. This confounds two distinct concepts: the name of the generated binary, and the type of binary to

Re: RFR 8198834: (ch) Enable java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java on linux-x64

D’oh! Thanks, Brian On Mar 1, 2018, at 2:57 PM, Erik Joelsson wrote: > Note that you also need to update the declarations in the makefile.

Re: RFR: JDK-8198724 Refactor FLAGS handling in configure

Hello Magnus, Nice to finally see this posted! Overall very nice improvement. On 2018-02-26 15:40, Magnus Ihse Bursie wrote: The current way we're handling FLAGS (CFLAGS/CXXFLAGS, LDFLAGS, etc) is laden with technical debt. It's a sorry mess, hard to do anything constructive about. This is t

Re: RFR JDK-8197533 move javax.transaction.xa into its own module

While running the JDK regression tests, I found a test that needed to be updated, test/langtools/tools/jdeps/modules/DotFileTest.java, due to the update to the java.sql module The updated webrev is at http://cr.openjdk.java.net/~lancea/8197533/webrev.03/

Re: RFR JDK-8197533 move javax.transaction.xa into its own module

> On Mar 1, 2018, at 4:41 PM, Lance Andersen wrote: > > While running the JDK regression tests, I found a test that needed to be > updated, test/langtools/tools/jdeps/modules/DotFileTest.java, due to the > update to the java.sql module > > The updated webrev is at > http://cr.openjdk.java.n

Re: RFR: JDK-8198862 Stop doing funky compilation stuff for dtrace

Hi Magnus, On 1/03/2018 10:48 AM, Magnus Ihse Bursie wrote: We're doing a lot of weird compilation stuff for dtrace. With this patch, most of the weirdness is removed. The remaining calls to $(CC) -E has been changed to $(CPP) to clarify that we do not compile, we just use the precompiler. O

Re: RFR 8198834: (ch) Enable java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java on linux-x64

On 01/03/2018 22:53, Brian Burkhalter wrote: I think shorter is better: http://cr.openjdk.java.net/~bpb/8198834/webrev.01/ I’ll hold off pushing until Alan comments again. libInheritedLauncher.c looks okay (although still very strange