We have a lot of odd, small files in make/lib, from an attempt to
separate libraries that predates the modularization of jigsaw. They do
not make sense to keep separate anymore.
Also, the library definitions for linux and solaris for jdk.net are
virtually identical and should be unified.
As
There's currently a lot of boilerplate code needed to setup a new native
jtreg test. This was never the way it was intended to work -- the idea
was that you basically should just add the file and then things should
work automatically, unless you had special requirements.
This patch will make i
Looks good.
/Erik
On 2018-03-15 06:01, Magnus Ihse Bursie wrote:
There's currently a lot of boilerplate code needed to setup a new
native jtreg test. This was never the way it was intended to work --
the idea was that you basically should just add the file and then
things should work automat
Looks good to me. I tried cleaning this up before but failed to find a
reasonable split, but this seems like a good split between common and
library specific.
/Erik
On 2018-03-14 18:12, Magnus Ihse Bursie wrote:
I forgot to add the client mailing lists as recipients. Sorry. (Not
sure if "sou
Looks good!
/Erik
On 2018-03-15 01:59, Magnus Ihse Bursie wrote:
We have a lot of odd, small files in make/lib, from an attempt to
separate libraries that predates the modularization of jigsaw. They do
not make sense to keep separate anymore.
Also, the library definitions for linux and sola
It is very hard to follow all the moved around files, but one thing
that sticks out is there is a "bsd" directory created and I can't
work out how the files in there are used.
If they are for a BSD port of OpenJDK where is rest of the support for
that ?
On 03/15/2018 07:20 AM, Erik Joelsson wro
Digging a bit, those files came with the initial Macosx support. It
doesn't look like they were ever used.
/Erik
On 2018-03-15 09:53, Phil Race wrote:
It is very hard to follow all the moved around files, but one thing
that sticks out is there is a "bsd" directory created and I can't
work out
I wondered if that might be the case since it was a "BSD" port .. using
X11 ..
Maybe we should be getting rid of them ?
-phil.
On 03/15/2018 10:21 AM, Erik Joelsson wrote:
Digging a bit, those files came with the initial Macosx support. It
doesn't look like they were ever used.
/Erik
On 2
It turned out that the jaas_nt/jaas_unix names were hardcoded in a test.
Following JDK-8199636, this test must also be updated.
Bug: https://bugs.openjdk.java.net/browse/JDK-8199703
Patch inline:
diff --git
a/closed/test/jdk/com/sun/security/auth/module/PlatformLoginModule/platform.policy
b/cl
Looks good.
/Erik
On 2018-03-15 11:13, Magnus Ihse Bursie wrote:
It turned out that the jaas_nt/jaas_unix names were hardcoded in a test.
Following JDK-8199636, this test must also be updated.
Bug: https://bugs.openjdk.java.net/browse/JDK-8199703
Patch inline:
diff --git
a/closed/test/jdk/c
The saproc library has historically been built in quite odd ways on
almost all platforms. When the old build system was converted, this was
not changed.
However, now the time has come to streamline this and build this library
just as any other.
The most visible change, perhaps, is that the l
Looks good to me.
The removed source files, are those some kind of tests?
/Erik
On 2018-03-15 11:22, Magnus Ihse Bursie wrote:
The saproc library has historically been built in quite odd ways on
almost all platforms. When the old build system was converted, this
was not changed.
However, n
On 2018-03-15 18:23, Phil Race wrote:
I wondered if that might be the case since it was a "BSD" port ..
using X11 ..
Maybe we should be getting rid of them ?
I agree, we should delete them. I just shuffled them around in the hope
that they would be useful for a potential future bsd port, but i
On 2018-03-15 19:39, Erik Joelsson wrote:
Looks good to me.
The removed source files, are those some kind of tests?
I don't really know; they have been excluded from the build for all
time. My guess is that the Bsd* stuff is, like in the case of the sound
libraries, bsd-based stuff that arri
On 03/15/2018 11:44, Magnus Ihse Bursie wrote:
On 2018-03-15 18:23, Phil Race wrote:
I wondered if that might be the case since it was a "BSD" port ..
using X11 ..
Maybe we should be getting rid of them ?
I agree, we should delete them. I just shuffled them around in the hope
that they woul
> As far as I know the split was made to dynamically load
ALSA/DirectSound stuff
Yes, I think it is something like that for Linux
ie if at runtime a dependent-but-not-essential .so was not
installed it was not fatal. I don't know to what extent this is no longer a
possible issue, or one that m
> 15 mars 2018 kl. 20:13 skrev Phil Race :
>
>
> > As far as I know the split was made to dynamically load ALSA/DirectSound
> > stuff
>
> Yes, I think it is something like that for Linux
> ie if at runtime a dependent-but-not-essential .so was not
> installed it was not fatal. I don't know to
Hi Magnus,
Removing boilerplate is good but the exclude mechanism seems rather
awkward compared to the previous include. It's much more obvious when
writing a platform specific native test to include it for that platform,
rather than exclude it for all other platforms. You run the risk of
hav
Hi Magnus,
Overall this seems okay.
On 16/03/2018 4:22 AM, Magnus Ihse Bursie wrote:
The saproc library has historically been built in quite odd ways on
almost all platforms. When the old build system was converted, this was
not changed.
However, now the time has come to streamline this and
19 matches
Mail list logo
