Re: RFR: 8199138: Add RISC-V support to Zero

2018-03-19 Thread Andrew Haley
On 03/18/2018 08:19 PM, Edward Nevill wrote: > Pretty much. The only atomic operation which doesn't used GCC builtins is > os::atomic_copy64. For RISC-V this just does the same as all other 64 bit > CPUs. > > *(jlong *) dst = *(const jlong *) src; That's probably wrong, but it'll do for now

Re: RFR: JDK-8199749: Debug symbols are not copied to exploded image on Mac

2018-03-19 Thread Magnus Ihse Bursie
> 17 mars 2018 kl. 00:16 skrev Erik Joelsson : > > Debug symbols are by default external and the idea is that we copy them to > the exploded image together with the native libraries, to have them available > for debugging. This logic fails on Windows and Mac due to some intricate make > depen

Re: RFR: 8199138: Add RISC-V support to Zero

2018-03-19 Thread Erik Joelsson
Build changes look ok to me. /Erik On 2018-03-17 12:02, Edward Nevill wrote: Hi, Please review the following webrev Bugid: https://bugs.openjdk.java.net/browse/JDK-8199138 Webrev: http://cr.openjdk.java.net/~enevill/8199138/webrev.00 This webrev add Zero support for RISC-V I propose to set

Re: RFR: build pragma error with gcc 4.4.7

2018-03-19 Thread Kim Barrett
> On Mar 16, 2018, at 6:48 AM, Michal Vala wrote: > > Hi, > > I've been trying to build latest jdk with gcc 4.4.7 and I hit compile error > due to pragma used in function: > > /mnt/ramdisk/openjdk/src/hotspot/os/linux/os_linux.inline.hpp:103: error: > #pragma GCC diagnostic not allowed inside