Re: RFR: 8201788: Number of make jobs wrong for bootcycle-images target

Hi Magnus, On Thu, 2018-04-19 at 20:58 +0200, Magnus Ihse Bursie wrote: > Looks good to me too. Thanks for doing it this way. Thanks for the review, pushed (jdk-submit came back clean). Cheers, Severin > /Magnus > > > 19 apr. 2018 kl. 20:08 skrev Severin Gehwolf : > > > > Hi Erik, > > > > >

[8u] RFR: 8042707: Source changes needed to build JDK 9 with Visual Studio 2013 (VS2013)

Hi, I'd like to request a review of the backport from 9 to 8u: 8042707: Source changes needed to build JDK 9 with Visual Studio 2013 (VS2013) JBS: https://bugs.openjdk.java.net/browse/JDK-8042707 9 changesets: base repo: http://hg.openjdk.java.net/jdk9/jdk9/rev/39ee0ee4f890 jdk repo: http://hg

RFR: 8201259: Fix warning with VS2017 in jdk.pack

Hello, Please review fix [1] for VS2017 to compile pack200 native header file, without warnings. Thanks Kumar [1] http://cr.openjdk.java.net/~ksrini/8201259/

Re: [8u] RFR: 8042707: Source changes needed to build JDK 9 with Visual Studio 2013 (VS2013)

The root repo changes look ok. The changes in Copy-java.base.gmk applies to jdk/make/CopyFiles.gmk. Those changes are definitely needed. /Erik On 2018-04-20 13:18, Kevin Walls wrote: Hi, I'd like to request a review of the backport from 9 to 8u: 8042707: Source changes needed to build JDK

Re: RFR: 8201259: Fix warning with VS2017 in jdk.pack

Looks good to me. /Erik On 2018-04-20 14:19, Kumar Srinivasan wrote: Hello, Please review fix [1] for VS2017 to compile pack200 native header file,  without warnings. Thanks Kumar [1] http://cr.openjdk.java.net/~ksrini/8201259/