On 04/05/2018 03:14 PM, David Holmes wrote:
Sure, but "generally unnecessary in multithreaded programs" doesn't
quite cut it when it comes to correctness. So we have a couple of
obscure cases where readdir_r may do the wrong thing and we have a
subset of cases where readdir may be thread-safe "
Thanks Erik agree with you, the changes from JDK11 you mentioned is very
similar to what I propose and that will serve the purpose.
However the patch for the second part is related to locating jvmti.html,
VM's like openj9 has it's own html specs file in different location hence
we need extensio
Hello,
On 2018-04-30 04:14, Archana Nogriya wrote:
However the patch for the second partis related to locating
jvmti.html, VM's like openj9 has it's own html specs file in different
location hence we need extension to set it appropriately.
Yes, I see the reason for the change, but my concer
Hello,
I'm re-starting this review with the original proposed patch. This
changes the required boot-JDK in configure from the set "9 10 or 11" to
"10 or 11". It also changes what Oracle uses in its automated build
environment setup from 9 GA to 10 GA.
I do this based on the proposal [1] to r
Ahh I see , some reason git diff gave this wired result :).
Right so change is only one line,
JVMTI_HTML ?=
$(HOTSPOT_OUTPUTDIR)/variant-$(JVM_VARIANT_MAIN)/gensrc/jvmtifiles/jvmti.html
adding conditional parameter and then in our extension we can set
JVMTI_HTML with openj9 specs html.
Thank
Erik:
I'm re-starting this review with the original proposed patch. This
changes the required boot-JDK in configure from the set "9 10 or 11" to
"10 or 11". It also changes what Oracle uses in its automated build
environment setup from 9 GA to 10 GA.
I do this based on the proposal [1] to retain
Thanks, both your changes have now been pushed to JDK 11.
/Erik
On 2018-04-30 08:51, Archana Nogriya wrote:
Ahh I see , some reason git diff gave this wired result :).
Right so change is only one line,
JVMTI_HTML ?=
$(HOTSPOT_OUTPUTDIR)/variant-$(JVM_VARIANT_MAIN)/gensrc/jvmtifiles/jvmti.htm
Jerry, Misha,
thank you for your review.
adding build-dev alias as the patch includes makefiles changes.
-- Igor
> On Apr 30, 2018, at 8:39 AM, mikhailo wrote:
>
> Changes look good to me,
>
> Thank you,
>
> Misha
>
>
> On 04/28/2018 07:34 AM, Gerald Thornbrugh wrote:
>> Hi Igor,
>>
>>
Build changes look good.
/Erik
On 2018-04-30 12:03, Igor Ignatyev wrote:
Jerry, Misha,
thank you for your review.
adding build-dev alias as the patch includes makefiles changes.
-- Igor
On Apr 30, 2018, at 8:39 AM, mikhailo wrote:
Changes look good to me,
Thank you,
Misha
On 04/28/2
Compact profiles were added in JDK 8, and superceded by modules in JDK
9. The build logic for compact profiles was left in place in 9, but as
we head into 11 it is time to remove this. This patch removes all the
build logic related to that.
Bug: https://bugs.openjdk.java.net/browse/JDK-8196113
Erik:
Compact profiles were added in JDK 8, and superceded by modules in JDK
9. The build logic for compact profiles was left in place in 9, but as
we head into 11 it is time to remove this. This patch removes all the
build logic related to that.
Bug: https://bugs.openjdk.java.net/browse/JDK-81
> On Apr 27, 2018, at 7:25 PM, David Holmes wrote:
>
> We discussed this offline and Gary pointed out that, at least in the VMError
> case the attempt to SEGV by dereferencing zero is one of a specific number of
> crash inducing cases, others of which include trying to trigger SEGV at
> non-ze
On 30/04/2018 21:19, Erik Joelsson wrote:
Compact profiles were added in JDK 8, and superceded by modules in JDK
9. The build logic for compact profiles was left in place in 9, but as
we head into 11 it is time to remove this. This patch removes all the
build logic related to that.
Bug: https
13 matches
Mail list logo
