Re: [OpenJDK 2D-Dev] [11] RFR for JDK-8202476: ImageLib is broken in 32 bit Windows

Hi Phil, Just to confirm: do you approve the change? Thank you, Alexey On 02/05/2018 19:24, Alexey Ivanov wrote: Hi Phil, Thank you for your review. On 02/05/2018 17:28, Phil Race wrote: So ... the original change that removed the mapfiles broke the 32 bit build because of inconsistency

Re: RFR : JDK-8202387: javac --release 11 not supported

Build change looks good. /Erik On 2018-05-04 06:48, Jan Lahoda wrote: [+build-dev] On 4.5.2018 03:27, Jonathan Gibbons wrote: OK. It would be even better, perhaps in a subsequent update, if make/gendata/Gendata-jdk.compiler.gmk did not have to be updated for each release ... i.e. by

Re: RFR: 8179887 - Build failure with glibc >= 2.24: error: 'int readdir_r(DIR*, dirent*, dirent**)' is deprecated

On 3 May 2018 at 21:43, Kim Barrett wrote: >> On May 3, 2018, at 1:52 PM, B. Blaser wrote: >> >> Hi, >> >> On 2 May 2018 at 22:40, Kim Barrett wrote: On May 2, 2018, at 5:10 AM, Michal Vala wrote:

Re: RFR: 8179887 - Build failure with glibc >= 2.24: error: 'int readdir_r(DIR*, dirent*, dirent**)' is deprecated

> On May 4, 2018, at 11:42 AM, Alan Bateman wrote: > > On 04/05/2018 16:31, B. Blaser wrote: >> : >> >> I'll create a new JBS issue (unless you want to) since the fix is >> mostly located in core-libs and only intended to make the build >> complete. >> But I'll still

Re: RFR : JDK-8202387: javac --release 11 not supported

Hi Jan, there is several occurences of Arrays.asList() that can be replaced by List.of() to make them really immutable. in CreateSymbols.java in dumpCurrentClasses, while ((read = in.read()) != (-1)) { baos.write(read); } should be replaced by in.transferTo(baos); in

Re: RFR(L) : 8199382 : [TESTBUG] Open source VM testbase JDI tests

Build change looks good. /Erik On 2018-05-03 21:14, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev/8199382/webrev.00/index.html 577169 lines changed: 577169 ins; 0 del; 0 mod; Hi all, could you please review the patch which open sources JDI tests from vm testbase? These tests

Re: RFR: 8201429: Support AIX Input Method Editor (IME) for AWT Input Method Framework (IMF)

Hello, It looks like what you are trying to achieve is to override awt_InputMethod.c with an OS specific version of that file. We have a construct for this in SetupNativeCompilation that should handle it automatically, if you just list the source dirs in priority order. I would suggest

Re: [OpenJDK 2D-Dev] [11] RFR for JDK-8202476: ImageLib is broken in 32 bit Windows

Yes, your confirmation on the testing was all that was needed. -phil. On 5/4/2018 10:45 AM, Alexey Ivanov wrote: Hi Phil, Just to confirm: do you approve the change? Thank you, Alexey On 02/05/2018 19:24, Alexey Ivanov wrote: Hi Phil, Thank you for your review. On 02/05/2018 17:28, Phil

Re: RFR: 8179887 - Build failure with glibc >= 2.24: error: 'int readdir_r(DIR*, dirent*, dirent**)' is deprecated

On 04/05/2018 16:31, B. Blaser wrote: : I'll create a new JBS issue (unless you want to) since the fix is mostly located in core-libs and only intended to make the build complete. But I'll still need someone to review and push the fix, would you be interested in doing this? I think someone

Re: [OpenJDK 2D-Dev] [11] RFR for JDK-8202476: ImageLib is broken in 32 bit Windows

Thank you! -- Alexey On 04/05/2018 18:53, Phil Race wrote: Yes, your confirmation on the testing was all that was needed. -phil. On 5/4/2018 10:45 AM, Alexey Ivanov wrote: Hi Phil, Just to confirm: do you approve the change? Thank you, Alexey On 02/05/2018 19:24, Alexey Ivanov wrote: Hi

Re: RFR: 8201274: Launch Single-File Source-Code Programs

Here's an update to the previously proposed patch for JEP 330: Launch Single-File Source-Code Programs. It includes all review feedback so far. The changes are mostly minor, but with the addition of more test cases. The webrev includes a delta-webrev for those that just want to see what has

Re: RFR : JDK-8202387: javac --release 11 not supported

I like the Makefile improvement. +1 -- Jon On 05/04/2018 06:48 AM, Jan Lahoda wrote: [+build-dev] On 4.5.2018 03:27, Jonathan Gibbons wrote: OK. It would be even better, perhaps in a subsequent update, if make/gendata/Gendata-jdk.compiler.gmk did not have to be updated for each release ...

Re: RFR: JDK-8202319: Fix compilation warnings in Solaris debug builds for DevStudio 12.6

Patch looks good. I will sponsor.

Re: RFR : JDK-8202387: javac --release 11 not supported

[+build-dev] On 4.5.2018 03:27, Jonathan Gibbons wrote: OK. It would be even better, perhaps in a subsequent update, if make/gendata/Gendata-jdk.compiler.gmk did not have to be updated for each release ... i.e. by changing A to B, and soon to C etc. The version letter can surely be inferred by

RFR: 8201429: Support AIX Input Method Editor (IME) for AWT Input Method Framework (IMF)

Hi, please help reviewing the contribution of the support for the AIX Input Method Editor (IME) in AWT's Input Method Framework. Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8201429.1/ Bug: https://bugs.openjdk.java.net/browse/JDK-8201429 I took Ichiroh's initial proposal [1] and tried

Re: Windows: problem with msvxxx.dll locations containing spaces

Hi Erik, that worked on both machines for all builds. Thanks, Thomas On Thu, May 3, 2018 at 10:13 PM, Erik Joelsson wrote: > Hello, > > In my case, VCINSTALLDIR is in short form already. Could you try changing > line 543 from BASIC_WINDOWS_REWRITE_AS_UNIX_PATH to