Re: Build failure on Fedora 28

2018-05-09 Thread Yasumasa Suenaga
Hi David, 2018-05-09 16:26 GMT+09:00 David Holmes : > On 9/05/2018 5:19 PM, Yasumasa Suenaga wrote: >> >> Hi David, >> >> I uploaded trace log: >>http://cr.openjdk.java.net/~ysuenaga/openjdk-fc28/trace-all.log >> >> It seems to open module file, but any class is not

Re: Build failure on Fedora 28

2018-05-09 Thread Thomas Stüfe
Hi Yasumasa, On Wed, May 9, 2018 at 10:03 AM, Yasumasa Suenaga wrote: > Hi Thomas, > > Build was succeeded with --with-build-jdk= configure > option, but JDK image does not work as below: > > ``` > [ysuenaga@f4i jdk]$ >

Re: Build failure on Fedora 28

2018-05-09 Thread David Holmes
On 9/05/2018 5:40 PM, Yasumasa Suenaga wrote: Hi David, 2018-05-09 16:26 GMT+09:00 David Holmes : On 9/05/2018 5:19 PM, Yasumasa Suenaga wrote: Hi David, I uploaded trace log: http://cr.openjdk.java.net/~ysuenaga/openjdk-fc28/trace-all.log It seems to open

Re: Build failure on Fedora 28

2018-05-09 Thread Yasumasa Suenaga
Hi David, I uploaded trace log: http://cr.openjdk.java.net/~ysuenaga/openjdk-fc28/trace-all.log It seems to open module file, but any class is not loaded from there. Thanks, Yasumasa 2018-05-09 15:31 GMT+09:00 David Holmes : > On 9/05/2018 1:46 PM, Yasumasa

Re: Build failure on Fedora 28

2018-05-09 Thread Severin Gehwolf
Hi, Note that slowdebug builds work: $ ./build/linux-x86_64-normal-server-slowdebug/images/jdk/bin/java -version openjdk version "11-internal" 2018-09-25 OpenJDK Runtime Environment (slowdebug build 11-internal+0-adhoc.sgehwolf.openjdk-hs) OpenJDK 64-Bit Server VM (slowdebug build

Re: Build failure on Fedora 28

2018-05-09 Thread David Holmes
On 9/05/2018 5:19 PM, Yasumasa Suenaga wrote: Hi David, I uploaded trace log: http://cr.openjdk.java.net/~ysuenaga/openjdk-fc28/trace-all.log It seems to open module file, but any class is not loaded from there. The last line I see is: [0.266s][trace][gc,tlab ] TLAB: fill

Re: Build failure on Fedora 28

2018-05-09 Thread Yasumasa Suenaga
Hi Thomas, Build was succeeded with --with-build-jdk= configure option, but JDK image does not work as below: ``` [ysuenaga@f4i jdk]$ ./build/linux-x86_64-normal-server-fastdebug/images/jdk/bin/java --version Error occurred during initialization of VM java/lang/NoClassDefFoundError:

Re: Build failure on Fedora 28

2018-05-09 Thread David Holmes
On 9/05/2018 1:46 PM, Yasumasa Suenaga wrote: Hi David, I uploaded build.log: http://cr.openjdk.java.net/~ysuenaga/openjdk-fc28/build.log Is it enough? It's all there is. :) But no errors. It all is fine right up to the part that it isn't. Can you run:

Re: RFR(xxs): 8202822: Add .git to .hgignore

2018-05-09 Thread Thomas Stüfe
Thanks! On Wed, May 9, 2018 at 5:52 PM, Erik Joelsson wrote: > Looks good to me. > > /Erik > > > > On 2018-05-08 21:59, Thomas Stüfe wrote: >> >> Hi all, >> >> could we add .git to .hgignore? >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8202822 >> >> Diff: >> >>

Re: [11] RFR for JDK-8202544: Hide unused exports in libzip

2018-05-09 Thread Alexey Ivanov
Any volunteers from core-libs and/or hotspot? Thank you, Alexey On 02/05/2018 13:02, Magnus Ihse Bursie wrote: Looks good to me, FWIW. /Magnus 2 maj 2018 kl. 13:52 skrev Alexey Ivanov : Hi, Could you please review the following fix for jdk11? bug:

Re: RFR(xxs): 8202822: Add .git to .hgignore

2018-05-09 Thread Erik Joelsson
Looks good to me. /Erik On 2018-05-08 21:59, Thomas Stüfe wrote: Hi all, could we add .git to .hgignore? Bug: https://bugs.openjdk.java.net/browse/JDK-8202822 Diff: --- a/.hgignore Wed May 09 06:51:41 2018 +0200 +++ b/.hgignore Wed May 09 06:55:10 2018 +0200 @@ -13,3 +13,4 @@

Re: RFR(xxs): 8202822: Add .git to .hgignore

2018-05-09 Thread John Paul Adrian Glaubitz
Shouldn't we also add .hg to .gitignore? :-) On 05/09/2018 05:52 PM, Erik Joelsson wrote: Looks good to me. /Erik On 2018-05-08 21:59, Thomas Stüfe wrote: Hi all, could we add .git to .hgignore? Bug: https://bugs.openjdk.java.net/browse/JDK-8202822 Diff: --- a/.hgignore Wed May 09

Re: RFR(xxs): 8202822: Add .git to .hgignore

2018-05-09 Thread Thomas Stüfe
Feel free :) On Wed, May 9, 2018 at 5:56 PM, John Paul Adrian Glaubitz wrote: > Shouldn't we also add .hg to .gitignore? :-) > > > On 05/09/2018 05:52 PM, Erik Joelsson wrote: >> >> Looks good to me. >> >> /Erik >> >> >> On 2018-05-08 21:59, Thomas Stüfe wrote: >>>

Re: RFR(L) : 8199384 : [TESTBUG] Open source VM testbase MLVM tests

2018-05-09 Thread Erik Joelsson
Build changes look good. /Erik On 2018-05-09 14:09, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8199384/webrev.00/index.html 61414 lines changed: 61414 ins; 0 del; 0 mod; Hi all, could you please review this patch which open sources MLVM tests from VM testbase? these

Re: RFR: 8201274: Launch Single-File Source-Code Programs

2018-05-09 Thread mandy chung
On 5/4/18 2:59 PM, Jonathan Gibbons wrote: Here's an update to the previously proposed patch for JEP 330: Launch Single-File Source-Code Programs. It includes all review feedback so far. The changes are mostly minor, but with the addition of more test cases. The webrev includes a

Re: RFR(xxs): 8202822: Add .git to .hgignore

2018-05-09 Thread Thomas Stüfe
Thanks Erik! I'll push this now under the trivial rule. Thanks, Thomas On Wed, May 9, 2018 at 5:52 PM, Erik Joelsson wrote: > Looks good to me. > > /Erik > > > > On 2018-05-08 21:59, Thomas Stüfe wrote: >> >> Hi all, >> >> could we add .git to .hgignore? >> >> Bug:

RFR(L) : 8199384 : [TESTBUG] Open source VM testbase MLVM tests

2018-05-09 Thread Igor Ignatyev
http://cr.openjdk.java.net/~iignatyev//8199384/webrev.00/index.html > 61414 lines changed: 61414 ins; 0 del; 0 mod; Hi all, could you please review this patch which open sources MLVM tests from VM testbase? these tests were developed in early days of JSR292 to test different aspects of