RE: RFR(XL): 8199712: Flight Recorder

2018-05-15 Thread Markus Gronlund
Thanks Magnus, About JFR_DEPS, it is somewhat of a remnant from the previous system. Looks like the previous system eventually took the local variable and appended it to DEPS (is this a global where all dependencies are tracked?) Can we do the following instead to ensure file edits trigger rec

Re: RFR(XL): 8199712: Flight Recorder

2018-05-15 Thread Erik Gahlin
On 2018-05-14 18:05, Erik Joelsson wrote: Oh, I missed the new makefiles last time I looked at this. in Copy-jdk.jfr.gmk, everything looks like it's indented an extra 4 steps. I'm assuming this is because it used to be conditional in the previous closed file. Will fix! GensrcJfr.gmk, line

Re: Build failure on Fedora 28

2018-05-15 Thread Severin Gehwolf
Hi, On Fri, 2018-05-11 at 12:55 +0900, Yasumasa Suenaga wrote: > Hi, > > I found 1 GCC optimization issue, but it is not enough. > > http://cr.openjdk.java.net/~ysuenaga/openjdk-fc28/gcc8-opt/gdb-before.txt > > I traced class loading from `modules`. Above log is copy of GDB > console in ImageFi

Re: Build failure on Fedora 28

2018-05-15 Thread Yasumasa Suenaga
Hi Severin, Looks like another case of UB in the JDK. This time libjimage.so with a signed integer overflow: https://bugs.openjdk.java.net/browse/JDK-8203223 Thanks! Can you fix pointer increment issue (I reported) at the same time? Yasumasa On 2018/05/15 23:07, Severin Gehwolf wrote: Hi

Re: Build failure on Fedora 28

2018-05-15 Thread Severin Gehwolf
Hi Yasumasa, On Tue, 2018-05-15 at 23:56 +0900, Yasumasa Suenaga wrote: > Hi Severin, > > > Looks like another case of UB in the JDK. This time libjimage.so with a > > signed integer overflow: > > > > https://bugs.openjdk.java.net/browse/JDK-8203223 > > Thanks! > Can you fix pointer increment i

Re: RFR(L) : 8199370: [TESTBUG] Open source vm testbase GC tests

2018-05-15 Thread Igor Ignatyev
Hi Erik, please see my answers inline. can I consider this RFR as reviewed by you? Thanks, -- Igor > On May 14, 2018, at 4:23 AM, Erik Helin wrote: > > On 05/08/2018 12:35 AM, Igor Ignatyev wrote: >> Hi all, > > Hi Igor, > > On 05/08/2018 12:35 AM, Igor Ignatyev wrote: >> could you please

RFR: JDK-8203221 Makefile fixes after Flight Recorder

2018-05-15 Thread Magnus Ihse Bursie
Cleanups of the build system after Flight Recorder. Bug: https://bugs.openjdk.java.net/browse/JDK-8203221 WebRev: http://cr.openjdk.java.net/~ihse/JDK-8203221-makefile-fixes-after-flight-recorder/webrev.01 /Magnus

Re: RFR: JDK-8203221 Makefile fixes after Flight Recorder

2018-05-15 Thread Erik Joelsson
Hello, In GensrcJfr, JFR_TOOLS_OUTPUTDIR is defined twice. Other build tools are in make/{jdk,hotspot}/src/classes. Do you think we should be moving them to one place? Regardless, I think we need an INCLUDE in the SetupJavaCompilation so that we only build the tool we need. There is currently

RE: RFR: JDK-8203221 Makefile fixes after Flight Recorder

2018-05-15 Thread Markus Gronlund
Magnus and Erik, Big thanks in regards to your ongoing assistance and follow-up on this. Best regards Markus and Erik (G) -Original Message- From: Magnus Ihse Bursie Sent: den 16 maj 2018 01:14 To: build-dev ; hotspot-jfr-...@openjdk.java.net Subject: RFR: JDK-8203221 Makefile fixes aft

Re: Build failure on Fedora 28

2018-05-15 Thread Yasumasa Suenaga
Hi Severin, >> > Looks like another case of UB in the JDK. This time libjimage.so with a >> > signed integer overflow: >> > >> > https://bugs.openjdk.java.net/browse/JDK-8203223 It works on my Fedora 28. I hope your change will be merged ASAP. Thanks again! Yasumasa 2018-05-16 0:09 GMT+09:00