Re: RFR: 8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)

Hi Per, Please always include build-dev when proposing build changes. The changes in make/autoconf/hotspot.m4 looks a bit suspect. Since you are adding zgc to disabled jvm features, which always override enabled features, it will never be possible to enable zgc on any other platform. Is this

Re: RFR: 8204210: Implementation: JEP 333: ZGC: A Scalable Low-Latency Garbage Collector (Experimental)

Hi Magnus, Thanks for reviewing. On 06/04/2018 01:20 PM, Magnus Ihse Bursie wrote: Hi Per, Please always include build-dev when proposing build changes. The changes in make/autoconf/hotspot.m4 looks a bit suspect. Since you are adding zgc to disabled jvm features, which always override enabl

RE: RFR: JDK-8204211: windows : handle potential C++ exception in GDIRenderer -was : RE: [OpenJDK 2D-Dev] java2d coding using SAFE_SIZE_ARRAY_ALLOC / safe_Malloc

Hello, I prepared a second webrev. - use now const-reference in the catch-statements as suggested by Thomas - reenabled the cl warning showing the exception issues in make/lib/Awt2dLibraries.gmk - found a second place in WPrinterJob.cpp with similar issues after reenabling the warni

RE: RFR: JDK-8204211: windows : handle potential C++ exception in GDIRenderer -was : RE: [OpenJDK 2D-Dev] java2d coding using SAFE_SIZE_ARRAY_ALLOC / safe_Malloc

Hi Matthias, looks good to me. Don't forget the Copyright years. Best regards Christoph > -Original Message- > From: Baesken, Matthias > Sent: Montag, 4. Juni 2018 16:20 > To: Thomas Stüfe ; 'build- > d...@openjdk.java.net' ; awt- > d...@openjdk.java.net > Cc: 2d-dev <2d-...@openjdk.jav

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

Hello, On 2018-06-01 14:00, Aleksey Shipilev wrote: On 06/01/2018 10:53 PM, Erik Joelsson wrote: This patch defines flags for disabling speculative execution for GCC and Visual Studio and applies them to all binaries except libjvm when available in the compiler. It defines a new jvm feature n

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

> On 4 Jun 2018, at 17:52, Erik Joelsson wrote: > > Hello, > > On 2018-06-01 14:00, Aleksey Shipilev wrote: >> On 06/01/2018 10:53 PM, Erik Joelsson wrote: >>> This patch defines flags for disabling speculative execution for GCC and >>> Visual Studio and applies >>> them to all binaries except

Re: [8] RFR (XS) 8204053 : libsaproc.so not linked with -z,noexecstack

Looks ok. /Erik On 2018-06-02 16:17, David Buck wrote: Hi! Please review this very small fix. It only applies to JDK 8. bug report: https://bugs.openjdk.java.net/browse/JDK-8204053 webrev: http://cr.openjdk.java.net/~dbuck/8204053.0/ JPRT hotspot testset run and passed. Efficacy of fix man

Re: RFR: JDK-8200132: Remove jre images and bundles

If we do this, shouldn’t we provide an aggregator module to allow developers to easily create a Java runtime with the same list of modules? AFAIK, this doesn’t exists. The java.se module is not the same. It’s missing many modules. Bob. > On Jun 2, 2018, at 1:01 PM, Alan Bat

Re: RFR: JDK-8200132: Remove jre images and bundles

On 04/06/2018 20:45, Bob Vandette wrote: If we do this, shouldn’t we provide an aggregator module to allow developers to easily create a Java runtime with the same list of modules?  AFAIK, this doesn’t exists. The java.se  module is not the same.  It’s missing many modules. Th

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

New webrev: http://cr.openjdk.java.net/~erikj/8202384/webrev.02/ Renamed the new jvm variant to "hardened". /Erik On 2018-06-04 09:54, jesper.wilhelms...@oracle.com wrote: On 4 Jun 2018, at 17:52, Erik Joelsson wrote: Hello, On 2018-06-01 14:00, Aleksey Shipilev wrote: On 06/01/2018 10:53

Re: RFR: JDK-8200132: Remove jre images and bundles

On 06/02/2018 12:20 AM, Alan Bateman wrote: On 02/06/2018 08:05, Aleksey Shipilev wrote: : Unfortunately, in the age of containers, distribution size matters. It makes the whole sense to ship JRE in Docker containers to provide the execution environment for the upper layers. Remember, hardl

Re: RFR: JDK-8200132: Remove jre images and bundles

> On Jun 4, 2018, at 4:32 PM, Jonathan Gibbons > wrote: > > > > On 06/02/2018 12:20 AM, Alan Bateman wrote: >> On 02/06/2018 08:05, Aleksey Shipilev wrote: >>> : >>> Unfortunately, in the age of containers, distribution size matters. It >>> makes the whole sense to ship >>> JRE in Docker co

Re: RFR: JDK-8200132: Remove jre images and bundles

Given the feedback, I have revised the patch to restore the ability to produce a legacy jre image, but it is still removed from the default "product-images" and "images" targets. To build it you need to specify it explicitly as "legacy-jre-image" (or mac-legacy-jre-bundle for the macosx specifi

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

Looks good to me. /Jesper > On 4 Jun 2018, at 22:10, Erik Joelsson wrote: > > New webrev: http://cr.openjdk.java.net/~erikj/8202384/webrev.02/ > > Renamed the new jvm variant to "hardened". > > /Erik > > > On 2018-06-04 09:54, jesper.wilhelms...@oracle.com wrote: >>> On 4 Jun 2018, at 17:52,

Re: RFR: JDK-8202384: Introduce altserver jvm variant with speculative execution disabled

Sorry to be late to this party ... On 5/06/2018 6:10 AM, Erik Joelsson wrote: New webrev: http://cr.openjdk.java.net/~erikj/8202384/webrev.02/ Renamed the new jvm variant to "hardened". As it is a hardened server build I'd prefer if that were somehow reflected in the name. Though really I do

RE: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

Hello Matthias and Christoph. Thank you for your explanations. I did not have enough knowledge about "visibility". I created following patches. diff -r 02934b0d661b src/java.base/share/native/libjimage/NativeImageBuffer.cpp --- a/src/java.base/share/native/libj