Openjdk build problem

2018-06-21 Thread pilot constatinus
Hi, i recently tried to compile openjdk 9. Fedora x86_64 28 gcc 8.1.1. I think gcc is causing this problem. I did a default bash get_source.sh and bash ./configure. Now make is the problem. https://pastebin.com/VhmStrYP

Re: Openjdk build problem

2018-06-21 Thread Patrick Reinhart
Hi Constaninus See http://mail.openjdk.java.net/pipermail/build-dev/2018-June/022427.html for a work-around and the follow up issue raised to solve it correctly. -Patrick On 2018-06-21 10:03, pilot constatinus wrote: Hi, i recently tried to compile openjdk 9. Fedora x86_64 28 gcc 8.1.1. I

Re: Openjdk build problem

2018-06-21 Thread Andrew Haley
On 06/21/2018 09:03 AM, pilot constatinus wrote: > Hi, i recently tried to compile openjdk 9. Fedora x86_64 28 gcc 8.1.1. I > think gcc is causing this problem. I did a default bash get_source.sh and > bash ./configure. Now make is the problem. > > https://pastebin.com/VhmStrYP Configure with --d

Re: [Fwd: Re: Build breakage with system jpeg and lcms and jdk-11+18]

2018-06-21 Thread John Paul Adrian Glaubitz
Hi Fridrich! Is this still an issue? Shall I open a bug report in JBS? Adrian On 06/15/2018 06:02 PM, Fridrich Strba wrote: > Hello, Magnus, > > Your original patch had a problem, since the second statement overwrote > the $1_SRC_HEADER_FLAGS instead of appending to it. With that, things > like

RFR 8205445: Add RSASSA-PSS Signature support to SunMSCAPI

2018-06-21 Thread Weijun Wang
Please take a review on this change http://cr.openjdk.java.net/~weijun/8205445/webrev.00/ and the release note at https://bugs.openjdk.java.net/browse/JDK-8205471 The code change adds RSASSA-PSS signature support to the SunMSCAPI provider. Several notes: 1. CryptoAPI (which SunMSCAPI i

Re: RFR: 8186780: clang-4.0 fastdebug assertion failure in os_linux_x86:os::verify_stack_alignment()

2018-06-21 Thread David Holmes
On 21/06/2018 10:05 AM, Martin Buchholz wrote: On Wed, Jun 20, 2018 at 4:03 PM, Martin Buchholz > wrote: Hi David and build-dev folk, After way too much build/hotspot hacking, I have a better fix: clang inlined os::current_stack_pointer into its caller _

Re: [Fwd: Re: Build breakage with system jpeg and lcms and jdk-11+18]

2018-06-21 Thread Fridrich Strba
Yes, I have tested this consolidated version and it builds just fine for me. Cheers F. On 21/06/18 11:57, John Paul Adrian Glaubitz wrote: > Hi Fridrich! > > Is this still an issue? Shall I open a bug report in JBS? > > Adrian > > On 06/15/2018 06:02 PM, Fridrich Strba wrote: >> Hello, Magnus

Re: RFR: 8186780: clang-4.0 fastdebug assertion failure in os_linux_x86:os::verify_stack_alignment()

2018-06-21 Thread Thomas Stüfe
On Thu, Jun 21, 2018 at 1:27 PM, David Holmes wrote: > On 21/06/2018 10:05 AM, Martin Buchholz wrote: >> >> On Wed, Jun 20, 2018 at 4:03 PM, Martin Buchholz > > wrote: >> >> Hi David and build-dev folk, >> >> After way too much build/hotspot hacking, I have a be

RE: RFR: 8179887 - Build failure with glibc >= 2.24: error: 'int readdir_r(DIR*, dirent*, dirent**)' is deprecated

2018-06-21 Thread Pengfei Li
Hi Bernard, Yes, your fix is good but would be nicer if the comment in line 733 is modified as well since it might be misleading. > 733 /* On AIX, readdir() returns EBADF ... I only have Linux machines to test. But I suggest that your patch being merged soon as the deprecated use breaks th

Re: RFR 8205445: Add RSASSA-PSS Signature support to SunMSCAPI

2018-06-21 Thread Xuelei Fan
Hi Weijun, The release note and the following notes look reasonable to me. For the implementation part, could it be a little bit more straightforward if wrapping the new attributes (pss/pssParams/fallbackSignature) and codes (if pss/fallbackSignature, etc) in the PSS subclass? Did you want

Re: RFR 8205445: Add RSASSA-PSS Signature support to SunMSCAPI

2018-06-21 Thread Weijun Wang
> On Jun 21, 2018, at 11:07 PM, Xuelei Fan wrote: > > Hi Weijun, > > The release note and the following notes look reasonable to me. > > For the implementation part, could it be a little bit more straightforward if > wrapping the new attributes (pss/pssParams/fallbackSignature) and codes (i

Re: RFR 8205445: Add RSASSA-PSS Signature support to SunMSCAPI

2018-06-21 Thread Erik Joelsson
Build change looks good. /Erik On 2018-06-21 04:12, Weijun Wang wrote: Please take a review on this change http://cr.openjdk.java.net/~weijun/8205445/webrev.00/ and the release note at https://bugs.openjdk.java.net/browse/JDK-8205471 The code change adds RSASSA-PSS signature sup

Re: RFR: 8186780: clang-4.0 fastdebug assertion failure in os_linux_x86:os::verify_stack_alignment()

2018-06-21 Thread Martin Buchholz
I see: Don't use // os::current_stack_pointer(), as its result can be slightly below current // stack pointer, causing us to not alloca enough to reach "bottom". If you really really want to get the stack pointer of the current frame, you can't put it in a function! Use magic compiler extens

RFR: 8205494: Convert or remove all AWT applet demos

2018-06-21 Thread Phil Race
Bug: https://bugs.openjdk.java.net/browse/JDK-8205494 Webrev : http://cr.openjdk.java.net/~prr/8205494/ This removes all the old 1990's vintage applet demos which can't be run anymore. If any are interesting enough to turn into main programs then they can be retrieved from the mercurial history

Re: RFR: 8205494: Convert or remove all AWT applet demos

2018-06-21 Thread Erik Joelsson
Looks good. /Erik On 2018-06-21 15:09, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8205494 Webrev : http://cr.openjdk.java.net/~prr/8205494/ This removes all the old 1990's vintage applet demos which can't be run anymore. If any are interesting enough to turn into main pr

Re: RFR: 8205494: Convert or remove all AWT applet demos

2018-06-21 Thread Sergey Bylokhov
+1 On 21/06/2018 16:04, Erik Joelsson wrote: Looks good. /Erik On 2018-06-21 15:09, Phil Race wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8205494 Webrev : http://cr.openjdk.java.net/~prr/8205494/ This removes all the old 1990's vintage applet demos which can't be run anymore. If

Re: RFR 8205445: Add RSASSA-PSS Signature support to SunMSCAPI

2018-06-21 Thread Weijun Wang
Webrev updated at http://cr.openjdk.java.net/~weijun/8205445/webrev.01 I think I found a bug in SunRsaSign of the RSASSA-PSS signature. Fixed and added a test. BTW, I commented out the debug code in security.cpp. Once there is a bug I can use it. Thanks Max > On Jun 21, 2018, at 11:23 PM,