Re: RFR: Update build documentation to reflect compiler upgrades at Oracle

2018-07-24 Thread Erik Joelsson
Hello, We will most likely need to drop support for older VS in JDK 12 as there is much interest to move to a later C++ standard in Hotspot. That change has not happened yet though and will certainly require a JEP (the C++ standard change part). In the meantime, if you need JDK 12 to work on

RFR: 8208157: requires.VMProps throws NPE for missing properties in "release" file

2018-07-24 Thread Alexandre (Shura) Iline
Hi, Could you please tale a quick look on this simple fix? diff --git a/test/jtreg-ext/requires/VMProps.java b/test/jtreg-ext/requires/VMProps.java --- a/test/jtreg-ext/requires/VMProps.java +++ b/test/jtreg-ext/requires/VMProps.java @@ -432,7 +432,8 @@ System.getProperty("java.

Re: RFR: 8208157: requires.VMProps throws NPE for missing properties in "release" file

2018-07-24 Thread Igor Ignatyev
looks good to me. -- Igor > On Jul 24, 2018, at 3:48 PM, Alexandre (Shura) Iline > wrote: > > Hi, > > Could you please tale a quick look on this simple fix? > > diff --git a/test/jtreg-ext/requires/VMProps.java > b/test/jtreg-ext/requires/VMProps.java > --- a/test/jtreg-ext/requires/VMProps

Re: RFR: 8208157: requires.VMProps throws NPE for missing properties in "release" file

2018-07-24 Thread Lance Andersen
Looks fine shura > On Jul 24, 2018, at 6:48 PM, Alexandre (Shura) Iline > wrote: > > Hi, > > Could you please tale a quick look on this simple fix? > > diff --git a/test/jtreg-ext/requires/VMProps.java > b/test/jtreg-ext/requires/VMProps.java > --- a/test/jtreg-ext/requires/VMProps.java > +++

Re: RFR: 8208157: requires.VMProps throws NPE for missing properties in "release" file

2018-07-24 Thread Erik Joelsson
Looks good. /Erik On 2018-07-24 15:48, Alexandre (Shura) Iline wrote: Hi, Could you please tale a quick look on this simple fix? diff --git a/test/jtreg-ext/requires/VMProps.java b/test/jtreg-ext/requires/VMProps.java --- a/test/jtreg-ext/requires/VMProps.java +++ b/test/jtreg-ext/requires/