Re: custom extension for make/SourceRevision.gmk

> On Jul 19, 2018, at 9:17 PM, Christian Thalinger > wrote: > > > >> On Jul 19, 2018, at 2:31 PM, Erik Joelsson > > wrote: >> >> I can do that. Do you have a bug? >> > No. Sorry, was on vacation… I don’t see the change in the repo. Did you file one? >> /

[12] RFR JDK-8167314: Enable the check to detect duplicate provides in in GenModuleInfoSource

A simple patch to enable the check to enforce no duplicate provides in module-info.java.extra, same checks as javac. This check was disabled in the fix for JDK-8202941 because of duplicated provides generated for jdk.internal.vm.compiler. Since JDK-8208463 is now resolved [1], we can enable this

RFR(M/L) : 8209611 : use C++ compiler for hotspot tests

http://cr.openjdk.java.net/~iignatyev//8209611/webrev.01/index.html > 11160 lines changed: 879 ins; 61 del; 10220 mod; Hi all, could you please review the patch which moves all hotspot native test code to C++? this will guarantee that we always use C++ compilers for them (as an opposite to eith

RFR (XS): 8209760 merge error: restore ea in make/conf/jib-profiles.js

All- Please review this change to restore ea in make/conf/jib-profiles.js. This is a file we use to control some internal build and release infrastructure. Since it is in the open repository, I am circulating the RFR here. Bug #8209760: https://bugs.openjdk.java.net/browse/JDK-8209760 Webr

Re: RFR (XS): 8209760 merge error: restore ea in make/conf/jib-profiles.js

Looks good, thanks for fixing and sorry for getting it wrong to start with. Cheers, Mikael > On Aug 20, 2018, at 4:11 PM, Tim Bell wrote: > > All- > > Please review this change to restore ea in make/conf/jib-profiles.js. > > This is a file we use to control some internal build and release

Re: Linux + Clang + execstack

Hi Arthur, cc'ing build-dev as this is currently a build issue. On 21/08/2018 3:11 AM, Arthur Eubanks wrote: Hi, At Google we're trying to build hotspot on Linux with clang. One thing that happens is that the resulting libjvm.so is stack executable. When running hotspot we get warnings about t

Re: [12] RFR JDK-8167314: Enable the check to detect duplicate provides in in GenModuleInfoSource

looks good Mandy On Aug 20, 2018, at 6:35 PM, mandy chung wrote: > A simple patch to enable the check to enforce no duplicate provides > in module-info.java.extra, same checks as javac. This check > was disabled in the fix for JDK-8202941 because of duplicated > provides generated for jdk.intern

Re: Linux + Clang + execstack

On 21/08/2018 9:39 AM, Arthur Eubanks wrote: On Mon, Aug 20, 2018 at 4:18 PM David Holmes > wrote: Hi Arthur, cc'ing build-dev as this is currently a build issue. On 21/08/2018 3:11 AM, Arthur Eubanks wrote: > Hi, > > At Google we're t

Re: RFR(M/L) : 8209611 : use C++ compiler for hotspot tests

Hi Igor, On 21/08/2018 8:59 AM, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8209611/webrev.01/index.html 11160 lines changed: 879 ins; 61 del; 10220 mod; Hi all, could you please review the patch which moves all hotspot native test code to C++? this will guarantee that we al

Re: RFR(M/L) : 8209611 : use C++ compiler for hotspot tests

Hi David, It is necessary for vmTestbase tests (if we of course want to clean them up) as they are coupled, and moving only part of them will require (non trivial) updates in the rest of code (or at least in the shared part) to properly serve both compilers. It absolutely not necessary for othe

Re: RFR(M/L) : 8209611 : use C++ compiler for hotspot tests

Hi Igor, On 21/08/2018 1:58 PM, Igor Ignatev wrote: Hi David, It is necessary for vmTestbase tests (if we of course want to clean them up) as they are coupled, and moving only part of them will require (non trivial) updates in the rest of code (or at least in the shared part) to properly ser

Re: RFR(M/L) : 8209611 : use C++ compiler for hotspot tests

> On Aug 20, 2018, at 10:06 PM, David Holmes wrote: > > Hi Igor, > > On 21/08/2018 1:58 PM, Igor Ignatev wrote: >> Hi David, >> It is necessary for vmTestbase tests (if we of course want to clean them up) >> as they are coupled, and moving only part of them will require (non trivial) >> upd

Re: Linux + Clang + execstack

> On Aug 20, 2018, at 5:03 PM, David Holmes wrote: > > On 21/08/2018 9:39 AM, Arthur Eubanks wrote: >> On Mon, Aug 20, 2018 at 4:18 PM David Holmes > > wrote: >>Hi Arthur, >>cc'ing build-dev as this is currently a build issue. >>On 21/08/2018 3:11 AM

Re: Linux + Clang + execstack

On 21/08/2018 4:29 PM, Mikael Vidstedt wrote: On Aug 20, 2018, at 5:03 PM, David Holmes > wrote: On 21/08/2018 9:39 AM, Arthur Eubanks wrote: On Mon, Aug 20, 2018 at 4:18 PM David Holmes > wrote:   

Re: RFR(M/L) : 8209611 : use C++ compiler for hotspot tests

On 21/08/2018 4:07 PM, Igor Ignatyev wrote: On Aug 20, 2018, at 10:06 PM, David Holmes wrote: Hi Igor, On 21/08/2018 1:58 PM, Igor Ignatev wrote: Hi David, It is necessary for vmTestbase tests (if we of course want to clean them up) as they are coupled, and moving only part of them will requ

Re: RFR(M/L) : 8209611 : use C++ compiler for hotspot tests

Because we would like to clean them up, which includes , but not limited to, removing JNI_ENV* and the like macros, other instances of ifndef __cplusplus. — Igor > On Aug 20, 2018, at 11:39 PM, David Holmes wrote: > > Okay, but why do we need to change any of these existing tests to be compil