With JDK-8210988, the foundation is in place for a more systematic way
of handling warnings across all native libraries (hotspot and the JDK
libraries alike).
With this patch, make sure we enable all warnings equally for all
libaries. If an individual library triggers a specific warning, disab
For historical reasons, we have exported all symbols on macosx. This was
an issue that probably arise with the very first macosx port, and the
complication that we then used map files with a format that Xcode did
not support.
Now we don't use mapfiles anymore, and there's no reason to keep
ex
Hi compiler folks!
Could anyone possibly help me with having a look at
https://bugs.openjdk.java.net/browse/JDK-8211057? The CompileProperties
build tool helper is not generating reproducible output, that is, if you
run it multiple times one after another, with no source code changes, it
will
Hi Magnus,
it's true that CompileProperties relies on Properties, which rely on
Hashtable (not HashMap) which is likely NOT to have predictable
iteration order (although I haven't been able to make it spit things in
different orders on my Linux box). That said, it seems like the code
keeps tha
Looks good.
/Erik
On 2018-09-24 01:18, Magnus Ihse Bursie wrote:
With JDK-8210988, the foundation is in place for a more systematic way
of handling warnings across all native libraries (hotspot and the JDK
libraries alike).
With this patch, make sure we enable all warnings equally for all
Looks good.
/Erik
On 2018-09-24 02:00, Magnus Ihse Bursie wrote:
For historical reasons, we have exported all symbols on macosx. This
was an issue that probably arise with the very first macosx port, and
the complication that we then used map files with a format that Xcode
did not support.
Bob,
Thank you for doing this. In the meanwhile, some of my fixes were pushed
that invalidated your diff, for which I apologize. Here is an updated
version of your patch which applies cleanly:
http://cr.openjdk.java.net/~avoitylov/webrev.8209093.02/
-Aleksei
On 23/09/2018 18:45, Boris Ulas
On 2018-09-24 17:43, Erik Joelsson wrote:
Looks good.
Thanks. I realized there's one more part where we still export all
symbols on macosx, and that's the launchers. Here's an updated webrev
that handles them too:
http://cr.openjdk.java.net/~ihse/JDK-8210705-stop-exporting-all-symbols-on-ma
Looks even better.
/Erik
On 2018-09-24 10:33, Magnus Ihse Bursie wrote:
On 2018-09-24 17:43, Erik Joelsson wrote:
Looks good.
Thanks. I realized there's one more part where we still export all
symbols on macosx, and that's the launchers. Here's an updated webrev
that handles them too:
ht
The -Wextra option to gcc enables a bunch of useful warnings.[1] Some of
them, but not all, can be individually enabled or disabled. All other
libraries in OpenJDK are compiled with -Wextra, but not Hotspot.
Enabling -Wextra on Hotspot triggers a couple of warnings for zero that
can be individu
On 2018-09-22 02:42, Erik Joelsson wrote:
Thanks for noticing! How about this:
http://cr.openjdk.java.net/~erikj/8211037/webrev.02/
LGTM.
/Magnus
/Erik
On 2018-09-21 17:03, Jonathan Gibbons wrote:
Erik,
Note the following API note for Files.list
https://docs.oracle.com/javase/10/docs/api
Build change looks ok. I will leave it for someone better versed in C++
for the code changes.
/Erik
On 2018-09-24 13:31, Magnus Ihse Bursie wrote:
The -Wextra option to gcc enables a bunch of useful warnings.[1] Some
of them, but not all, can be individually enabled or disabled. All
other li
12 matches
Mail list logo
