Re: RFR(S): 8211145: [ppc] [s390]: Build fails due to -Werror=switch (introduced with JDK-8211029)

2018-10-01 Thread Volker Simonis
Hi Lutz, the change looks good. Thanks for cleaning this up, Volker On Fri, Sep 28, 2018 at 12:30 PM Aleksey Shipilev wrote: > > On 09/27/2018 04:28 PM, Schmidt, Lutz wrote: > > re break vs. ShouldNotReachHere(), I tried to change semantics as little as > > possible. After > > discussion with

Re: [aarch64-port-dev ] RFR(XS): 8211207: AArch64: Fix build failure after JDK-8211029

2018-10-01 Thread Andrew Haley
On 09/29/2018 11:01 AM, Pengfei Li (Arm Technology China) wrote: > Anyone can help push Andrew Haley's fix ASAP since current master cannot > build? > http://cr.openjdk.java.net/~aph/8211207/ It's in. -- Andrew Haley Java Platform Lead Engineer Red Hat UK Ltd. EAC8 43E

Re: RFR(S): 8211145: [ppc] [s390]: Build fails due to -Werror=switch (introduced with JDK-8211029)

2018-10-01 Thread Schmidt, Lutz
Thank you, Aleksey and Volker! Pushed. Regards, Lutz On 01.10.18, 09:39, "Volker Simonis" wrote: Hi Lutz, the change looks good. Thanks for cleaning this up, Volker On Fri, Sep 28, 2018 at 12:30 PM Aleksey Shipilev wrote: > > On 09/27/2018 04:28 PM

Re: [12]RFR: [JDK-8074824]: Resolve disabled warnings for libawt_xawt

2018-10-01 Thread Philip Race
Hi, 1) Has this been built on all platforms ? 2) I can't find the list of warnings that you are seeing and fixing and they are all over the place. So adding 2d-dev and build-dev. For each of these changes, please show what was the warning that you received from the compiler This might sound l

Re: [12]RFR: [JDK-8074824]: Resolve disabled warnings for libawt_xawt

2018-10-01 Thread Philip Race
You really do need to explain *each* of the changes better. This one .. why not NULL ? http://cr.openjdk.java.net/~kaddepalli/8074824/webrev01/src/java.desktop/share/native/libawt/java2d/loops/ProcessPath.c.udiff.html -phil On 10/1/18, 9:19 AM, Philip Race wrote: Hi, 1) Has this been built on

Re: RFR: 8211296: Remove HotSpot deprecation warning suppression for Mac/clang

2018-10-01 Thread Kim Barrett
> On Oct 1, 2018, at 2:27 AM, David Holmes wrote: > > On 1/10/2018 1:21 PM, Kim Barrett wrote: >> The current library may have been previously only dlopen’ed with RTLD_LAZY. >> Reopening with RTLD_NOW >> forces resolution of all undefined symbols in that shared object, which >> appears to be t

Re: [12]RFR: [JDK-8074824]: Resolve disabled warnings for libawt_xawt

2018-10-01 Thread Philip Race
I suspect I understand this one now .. the array is stack allocated so we don't want NULL but the compiler probably complained about possible uninitialised use of the values ? -phil. On 10/1/18, 9:38 AM, Philip Race wrote: You really do need to explain *each* of the changes better. This one .

Re: RFR: 8211296: Remove HotSpot deprecation warning suppression for Mac/clang

2018-10-01 Thread David Holmes
On 2/10/2018 4:35 AM, Kim Barrett wrote: On Oct 1, 2018, at 2:27 AM, David Holmes wrote: On 1/10/2018 1:21 PM, Kim Barrett wrote: The current library may have been previously only dlopen’ed with RTLD_LAZY. Reopening with RTLD_NOW forces resolution of all undefined symbols in that shared obje