Re: RFR: 8210459: Add support for generating compile_commands.json

2018-10-05 Thread Robin Westberg
Hi Erik & Magnus, Thanks for the final reviews, pushed it with the suggested changes. Best regards, Robin > On 4 Oct 2018, at 18:24, Erik Joelsson wrote: > > Looks good. > > Minor style issue, the broken find line should be indented 4 spaces for > continuation. Strictly speaking so should th

Re: RFC: JEP JDK-8208089: Implement C++14 Language Features

2018-10-05 Thread Erik Helin
On 10/4/18 2:31 PM, Magnus Ihse Bursie wrote:>> 4 okt. 2018 kl. 10:57 skrev Martijn Verburg : I like this initiative. I'm wondering if some of these rules can be easily codified or written into a jcheck style checker (ccheck?) so that Authors can adhere to the conventions and not rely on a Human

RE: JEP JDK-8208089: Implement C++14 Language Features

2018-10-05 Thread Lindenmaier, Goetz
Hi Kim, > for XLC 16. Any information about "some C++14 features"? I haven't > found any detail on that. we will user our internal connections to IBM to find out :) Best regards, Goetz. > -Original Message- > From: Kim Barrett > Sent: Donnerstag, 4. Oktober 2018 23:01 > To: Lindenma

Re: RFR: JDK-8202951: Implementation of JEPJDK-8204247: Include default CDS (Class Data Sharing) archive in JDK binary

2018-10-05 Thread Jiangli Zhou
Dear all, JEP 341, Default CDS Archive has been targeted to JDK 12 (please see Mark's email from yesterday, Re: JEP proposed to target JDK 12: 341: Default CDS Archives). Code review, testing and performance runs are completed for the default CDS archive changes. I've started the final pre-in

RFR: JDK-8211724: Change mkdir -p to MakeDir macro where possible

2018-10-05 Thread Erik Joelsson
As a followup to JDK-8211677, here is an attempt at fixing most other instances of $(MKDIR) -p to instead of the MakeDir or MakeTargetDir macros. Since fixing the previous bug, we have hit the race in other recipes as well so this is really needed. There are some situations where the macro wou