RFR: XXS: JDK-8213102: Oracle Unilinks are [301 Moved Permanently] to https://docs.oracle.com

2018-10-29 Thread Jonathan Gibbons
Please review the following simple fix to change the host for Oracle Unilinks from www.oracle.com to docs.oracle.com to avoid unnecessary redirects. JBS: https://bugs.openjdk.java.net/browse/JDK-8213102 The fix was done with the following command: grep -rl oracle.com/pls open/make | xargs sed

Re: RFR: XXS: JDK-8213102: Oracle Unilinks are [301 Moved Permanently] to https://docs.oracle.com

2018-10-29 Thread Lance Andersen
looks fine jon > On Oct 29, 2018, at 2:57 PM, Jonathan Gibbons > wrote: > > Please review the following simple fix to change the host for Oracle Unilinks > from www.oracle.com to docs.oracle.com to avoid unnecessary redirects. > > JBS: https://bugs.openjdk.java.net/browse/JDK-8213102 > > The

Re: RFR: XXS: JDK-8213102: Oracle Unilinks are [301 Moved Permanently] to https://docs.oracle.com

2018-10-29 Thread Mandy Chung
+1 Mandy On 10/29/18 11:57 AM, Jonathan Gibbons wrote: Please review the following simple fix to change the host for Oracle Unilinks from www.oracle.com to docs.oracle.com to avoid unnecessary redirects. JBS: https://bugs.openjdk.java.net/browse/JDK-8213102 The fix was done with the followi

Re: RFR: XXS: JDK-8213102: Oracle Unilinks are [301 Moved Permanently] to https://docs.oracle.com

2018-10-29 Thread Erik Joelsson
Looks good. /Erik On 2018-10-29 11:57, Jonathan Gibbons wrote: Please review the following simple fix to change the host for Oracle Unilinks from www.oracle.com to docs.oracle.com to avoid unnecessary redirects. JBS: https://bugs.openjdk.java.net/browse/JDK-8213102 The fix was done with th

Re: RFR(M) 8152988: [AOT] Update test batch definitions to include aot-ed java.base module mode into hs-comp testing

2018-10-29 Thread Ekaterina Pavlova
Vladimir, I added "-XX:+UseAOTStrictLoading" to "java -version", see make/RunTests.gmk. Also added "--compile-with-assertion" to jaotc flags in case "-ea" flag was present in vm options (otherwise AOTed library will warn that it does not have java assertions in compiled code). I will add -XX:+U

Re: RFR(M) 8152988: [AOT] Update test batch definitions to include aot-ed java.base module mode into hs-comp testing

2018-10-29 Thread Vladimir Kozlov
Looks good to me. thanks, Vladimir On 10/29/18 1:24 PM, Ekaterina Pavlova wrote: Vladimir, I added "-XX:+UseAOTStrictLoading" to "java -version", see make/RunTests.gmk. Also added "--compile-with-assertion" to jaotc flags in case "-ea" flag was present in vm options (otherwise AOTed library wi