Re: compiling openJdk 11 on windows 7 32bits fail

2018-11-03 Thread Magnus Ihse Bursie
Have you tried running /cygdrive/c/progra~1/micros~1/2017/commun~1/vc/tools/msvc/1415~1.267/bin/hostx86/x86/cl from the same prompt you ran configure to see what happens? It seems to have located a compiler but fails to run it. There is also a second log file, config.log, generated by

RFR: JDK-8213339 Update precompiled.hpp with headers based on current frequency

2018-11-03 Thread Magnus Ihse Bursie
The reasons for the current set of files included in precompiled.hpp is somewhat lost in the mists of history. However, it is clear that it is not optimal. This patch replaces the current set with a new set, based on how often a header file is included in a C++ file. This selection contains

Re: RFR: JDK-8213339 Update precompiled.hpp with headers based on current frequency

2018-11-03 Thread David Holmes
Looks okay - thanks for doing all the experiments! (Though I'm still curious what happens if you recompile individual header files :) ). 25 // Precompiled headers are turned off for Sun Studio, May as well change to Solaris Studio if you're going to fix the typo :) Thanks. David On

Re: Stop using precompiled headers for Linux?

2018-11-03 Thread Magnus Ihse Bursie
On 2018-10-30 20:21, Erik Joelsson wrote: Last I checked, it did provide significant build speed improvements when building just hotspot, but that could need revisiting. We do have verification of --disable-precompiled-headers (in slowdebug) in builds-tier2 so we normally get notified if

Re: RFR: JDK-8213339 Update precompiled.hpp with headers based on current frequency

2018-11-03 Thread Aleksey Shipilev
On 11/03/2018 10:06 AM, Magnus Ihse Bursie wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8213339 > WebRev: > http://cr.openjdk.java.net/~ihse/JDK-8213339-update-precompiled-headers/webrev.01 This looks good to me. Thanks, -Aleksey

Re: RFR: JDK-8213339 Update precompiled.hpp with headers based on current frequency

2018-11-03 Thread David Holmes
On 3/11/2018 10:09 PM, David Holmes wrote: Looks okay - thanks for doing all the experiments! (Though I'm still curious what happens if you recompile individual header files :) ). s/recompile/precompile/ :) David  25 // Precompiled headers are turned off for Sun Studio, May as well

Re: compiling openJdk 11 on windows 7 32bits fail

2018-11-03 Thread Franco Gastón Pellegrini
I used this command: *bash ./configure --enable-debug --with-target-bits=32 --with-toolchain-version=2017 --with-jvm-variants=client --with-boot-jdk="/home/Franco/Java/jdk10/build/windows-x86-normal-client-fastdebug/jdk/";* I tried Visual studio 2015 and 2017 (with-toolchain-version). I attached