RE: [OpenJDK 2D-Dev] RFR(XS): 8213944: Fix AIX build after the removal of Xrandr.h and add a configure check for it

2018-11-20 Thread Lindenmaier, Goetz
Hi Volker, I had a look at your change. It looks good. I appreciate a lot you added a check in configure. Maybe it would be better to pass a WITHOUT_XRANDR or the like to the build, and check for such a define in the code. But I think we should push this change for now to fix the build. A follow

Re: [12] Gcc 8.1 HarfBuzz library compilation issues

2018-11-20 Thread Magnus Ihse Bursie
On 2018-11-19 22:22, Simon Tooke wrote: Hello, I've been looking at compiling the JDK with GCC 8.1, and trying to fix issues upstream as I find them. Nice! If you find issues in the JDK source code per se, please let us know. :) Sooner or later, we'll have to support gcc 8 properly anyway, mi

Re: [OpenJDK 2D-Dev] RFR(XS): 8213944: Fix AIX build after the removal of Xrandr.h and add a configure check for it

2018-11-20 Thread Magnus Ihse Bursie
On 2018-11-19 18:56, Volker Simonis wrote: Hi Phil, I'd like to kindly ask you to suggest how we can proceed with this issue. As I wrote before, Xrandr is not officially supported on AIX and there are no official packages available for it. There are some OpenSource sites for AIX which provid

Re: RFR 4947890 : Minimize JNI upcalls in system property initialization

2018-11-20 Thread Magnus Ihse Bursie
On 2018-11-20 00:37, Roger Riggs wrote: Hi, Webrev updated in place: http://cr.openjdk.java.net/~rriggs/webrev-props-only-raw Build changes still look fine. But please, in the future, avoid updating webrevs in place, but create new ones instead. It's hopeless to figure out what has chang

Re: [PATCH] Add optimization flags for ARM926EJ-S

2018-11-20 Thread Magnus Ihse Bursie
On 2018-11-13 11:14, Boris Ulasevich wrote: Hi Jakub, I am not against this patch, but I have a few concerns. (1) For me motivation "might increase performance a little bit" is not quite clear. It would be better to have some confidence. (2) Is the particular CPU highly distributed? I am n

Re: is ccache working effectively?

2018-11-20 Thread Magnus Ihse Bursie
On 2018-11-09 11:09, Maurizio Cimadamore wrote: That does the trick, thanks. If ccache and PCH is so bad in combination, maybe we should not allow it? Like turning off PCH by default of --enacle-ccache is given? Or at least *warn* that this combination is no good? /Magnus I take a very smal

Re: bash completion for make targets

2018-11-20 Thread Magnus Ihse Bursie
On 2018-11-08 12:20, Thomas Stüfe wrote: On Thu, Nov 8, 2018 at 12:13 PM Magnus Ihse Bursie wrote: On 2018-11-08 12:10, Thomas Stüfe wrote: Hi all, This may be a stupid question, and not that important, but bash completion for targets like "clean" and "images" stopped working for me. "reconf

jamvm-2.0.0 with openjdk 8

2018-11-20 Thread Somshekar C Kadam
Hi All, Please guide me or please provide pointers on this I am able to successfully compile and use zero JVM using below Using icedtea-3.9.0 ./configure --with-jdk-home="/usr/lib/jvm/java-8-openjdk-amd64" --enable-zero make and make install it works no problem I use icedtea-3.9.0 to build JamVM

Re: jamvm-2.0.0 with openjdk 8

2018-11-20 Thread Magnus Ihse Bursie
JamVM is out of scope for the OpenJDK project. You need to talk to the IcedTea folks. /Magnus On 2018-11-20 13:20, Somshekar C Kadam wrote: Hi All, Please guide me or please provide pointers on this I am able to successfully compile and use zero JVM using below Using icedtea-3.9.0 ./configur

Re: RFR(S): 8213698: Improve devkit creation and add support for linux/ppc64/ppc64le/s390x

2018-11-20 Thread Magnus Ihse Bursie
Hi Volker, Glad to see you fix and clean up the devkit scripts! And you're more than welcome to add documentation to the building.md. I think all your changes are good, and can go in as-is, but I see some further potential for cleanup, so if you feel like some more fixes while you're at it,

Re: bash completion for make targets

2018-11-20 Thread Thomas Stüfe
Hi Magnus, The problem did vanish for me. Tab completion works again in all my configurations. On zero, which I do not build that often, I had to run reconfigure. Sorry, I lost track of this one. I am not sure when it started working again. I even synced before Severins change, but it worked with

Re: [12] Gcc 8.1 HarfBuzz library compilation issues

2018-11-20 Thread Philip Race
I have removed awt-dev and replaced it with the CORRECT 2d-dev list. Please reply to this one .. to get awt-dev out of the loop. I already have an open bug to upgrade harfbuzz I will be handling soon. If the necessary changes are there we are all good. We do not much like at all locally modifying

Re: [PATCH] JDK-8214122 Prevent name mangling of jdwpTransport_OnLoad in Windows 32-bit DLL name decoration

2018-11-20 Thread Alexey Ivanov
Hi Ali, I have submitted a JBS issue for you: https://bugs.openjdk.java.net/browse/JDK-8214122 “Prevent name mangling of jdwpTransport_OnLoad in dt_socket and dt_shell dynamic link libraries” Let me know if I got any details wrong. I've left the bug unassigned. Once reviewed, I can sponsor yo

Re: [PATCH] JDK-8214122 Prevent name mangling of jdwpTransport_OnLoad in Windows 32-bit DLL name decoration

2018-11-20 Thread Alexey Ivanov
Hi Ali, Magnus, I absolutely agree this change has to be reviewed by someone from serviceability. There are several options: 1. Add -export:jdwpTransport_OnLoad to LDFLAGS for Windows http://mail.openjdk.java.net/pipermail/build-dev/2018-November/023935.html so it partially reverts the change

Re: [12] Gcc 8.1 HarfBuzz library compilation issues

2018-11-20 Thread Simon Tooke
On 2018-11-20 5:31 a.m., Magnus Ihse Bursie wrote: > On 2018-11-19 22:22, Simon Tooke wrote: > >> Hello, >> >> I've been looking at compiling the JDK with GCC 8.1, and trying to fix >> issues upstream as I find them. > Nice! If you find issues in the JDK source code per se, please let us > know. :)

RFR(XS): 8214120: [REDO] Fix sun.awt.nativedebug on X11 platforms

2018-11-20 Thread Volker Simonis
Hi, so here's a reworked version of my previous change: http://cr.openjdk.java.net/~simonis/webrevs/2018/8214120/ https://bugs.openjdk.java.net/browse/JDK-8214120 In addition to my initial change (which unfortunately broke the Solaris build) the new version has to JNIEXPORT the following methods

Re: RFR(XS): 8214120: [REDO] Fix sun.awt.nativedebug on X11 platforms

2018-11-20 Thread Thomas Stüfe
Hi Volker, looks good to me. Lets wait for jdk-submit though - especially since you changed linking on Windows too by adding JNIEXPORT. Gruss Thomas On Tue, Nov 20, 2018 at 6:13 PM Volker Simonis wrote: > > Hi, > > so here's a reworked version of my previous change: > > http://cr.openjdk.java.ne

Re: [PATCH] JDK-8214122 Prevent name mangling of jdwpTransport_OnLoad in Windows 32-bit DLL name decoration

2018-11-20 Thread Ali Ince
Hi Alexey, Magnus, Thanks for all of your comments on the possible options. Another option would be to use def files which contain an EXPORTS section that lists the exported functions ( https://docs.microsoft.com/en-gb/cpp/build/reference/exports?view=vs-2017). These files can lie next to the nat

Re: [OpenJDK 2D-Dev] RFR(XS): 8213944: Fix AIX build after the removal of Xrandr.h and add a configure check for it

2018-11-20 Thread Volker Simonis
elated to my change which only touches the X11 implementation on Unix. Can somebody please confirm that? [Mach5] mach5-one-simonis-JDK-8213944-20181120-1629-11082: FAILED, Failed tests: 1 runtime/modules/JVMDefineModule.java tier1 windows-x64-debug othervm driver ExitCode: -1073741819 Ma

Re: [12] Gcc 8.1 HarfBuzz library compilation issues

2018-11-20 Thread Simon Tooke
On 2018-11-20 10:04 a.m., Philip Race wrote: > I have removed awt-dev and replaced it with the CORRECT 2d-dev list. > Please reply to this one .. to get awt-dev out of the loop. > I already have an open bug to upgrade harfbuzz I will be handling soon. > If the necessary changes are there we are all

RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

2018-11-20 Thread Nick Gasson
Hi, Can someone please help me review this small makefile patch to fix an issue with java.io.File::setLastModified on 32-bit systems? https://bugs.openjdk.java.net/browse/JDK-8214077 http://cr.openjdk.java.net/~njian/8214077/webrev.0/ If the file size is > 2GB so that the size won't fit in a sig

Re: RFR: 8214077: test java/io/File/SetLastModified.java fails on ARM32

2018-11-20 Thread David Holmes
Hi Nick, I'll leave it for core-libs and build folk to review this, but just for some background ... This is a bit of a recurring issue. We have the all encompassing: https://bugs.openjdk.java.net/browse/JDK-8165620 "Entire JDK should be built with -D_FILE_OFFSET_BITS=64" then we had the lon

Re: jamvm-2.0.0 with openjdk 8

2018-11-20 Thread Somshekar C Kadam
Thanks Magnus for the reply. Regards Somshekar C Kadam 9036660538 On Tue, Nov 20, 2018 at 5:52 PM Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > JamVM is out of scope for the OpenJDK project. You need to talk to the > IcedTea folks. > > /Magnus > > > On 2018-11-20 13:20, Somshekar