Re: RFR (round 1), JDK-8214259: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

Hi, On 11/28/18 3:24 PM, Roman Kennke wrote: Hi Per, Hi Roman, On 11/26/18 10:39 PM, Roman Kennke wrote: [...]    *) shared-serviceability   - The usual code to support another GC Just had a quick l

Re: RFR(XS): 8214534: Setting of THIS_FILE in the build is broken

On 2018-11-30 19:03, Volker Simonis wrote: On Fri, Nov 30, 2018 at 6:37 PM Erik Joelsson wrote: Hello Volker, The fix looks good. Thanks for finding and fixing it! Thanks! Now for some history on why THIS_FILE. The short story is that it's for more reproducible and comparable builds. When

RFR: JDK-8214311 dtrace gensrc has missing dependencies

Building with JOBS=1 on solaris discovered that the dtrace gensrc has not all dependencies properly declared. This has not been discovered until now, since Solaris machines is typically very parallel, and the needed prerequisites has just happened to have been generated before. Bug: https://bu

Re: [PATCH v2] Add support for SoftFloat library on ARM

Comment inline. On 2018-11-30 14:38, Jakub Vaněk wrote: Hi David, I'm sending an alternative patch for handling the problem with __aeabi_*_glibc on arm softfloat builds. This patch adds integration code for SoftFloat-3e library. It adds appropriate configure options and a switchable implementat

Re: RFR (round 4), JDK-8214259: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

Hi Jini, Thanks for your suggestions. I've added this to Shenandoah's dev: http://cr.openjdk.java.net/~rkennke/shenandoah-sa/webrev.01/ and it will show up in next round of webrevs. Thanks, Roman > A few comments on the SA changes: > > ==> Could you please add the following lines in > src/jd

Re: RFR (round 4), JDK-8214259: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

Hi Roman, On 11/30/18 10:00 PM, Roman Kennke wrote: Hi all, here comes round 4 of Shenandoah upstreaming review: This includes fixes for the issues that Per brought up: - Verify and gracefully reject dangerous flags combinations that disables required barriers - Revisited @requires filters in

Re: RFR (round 4), JDK-8214259: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

Hi Per, Thanks for looking again. I've fixed the ordering in shenandoah-dev: http://cr.openjdk.java.net/~rkennke/fix-macro-order/webrev.00/ and it will apear in the next round of webrevs. Thanks, Roman > Hi Roman, > > On 11/30/18 10:00 PM, Roman Kennke wrote: >> Hi all, >> >> here comes rou

Re: RFR(XS): 8214534: Setting of THIS_FILE in the build is broken

Hi Magnus, Erik, do I understand you correctly that you both are fine with my proposed fix and that we leave all the other enhancements/discussion for the future? Thank you and best regards, Volker On Mon, Dec 3, 2018 at 12:27 PM Magnus Ihse Bursie wrote: > > On 2018-11-30 19:03, Volker Simonis

Re: RFR(XS): 8214534: Setting of THIS_FILE in the build is broken

On 2018-12-03 14:31, Volker Simonis wrote: Hi Magnus, Erik, do I understand you correctly that you both are fine with my proposed fix and that we leave all the other enhancements/discussion for the future? Yes, sorry I was not clear. Your fix looks good to me. We can save the rest of the discu

Re: RFR(XS): 8214534: Setting of THIS_FILE in the build is broken

Cool, thanks! I'll push then... On Mon, Dec 3, 2018 at 2:37 PM Magnus Ihse Bursie wrote: > > On 2018-12-03 14:31, Volker Simonis wrote: > > Hi Magnus, Erik, > > do I understand you correctly that you both are fine with my proposed > fix and that we leave all the other enhancements/discussion for t

RFR: JDK-8214710 Fix hg log in update_copyright_year.sh

The commands for hg log is missing -l1, which will limit the log to just the revision specified. Instead, all revisions from repo creation will now be included, and the script fails to work. I will publish a separate changeset with missed copyright year updates in the build system. Bug: http

RFR: JDK-8214710 Fix hg log in update_copyright_year.sh

The commands for hg log is missing -l1, which will limit the log to just the revision specified. Instead, all revisions from repo creation will now be included, and the script fails to work. I will publish a separate changeset with missed copyright year updates in the build system. Bug: http

RFR: JDK-8214710 Fix hg log in update_copyright_year.sh

The commands for hg log is missing -l1, which will limit the log to just the revision specified. Instead, all revisions from repo creation will now be included, and the script fails to work. I will publish a separate changeset with missed copyright year updates in the build system. Bug: https:

Re: RFR: JDK-8214710 Fix hg log in update_copyright_year.sh

On 03/12/2018 16:10, Magnus Ihse Bursie wrote: The commands for hg log is missing -l1, which will limit the log to just the revision specified. Instead, all revisions from repo creation will now be included, and the script fails to work. I will publish a separate changeset with missed copyr

RFR: JDK-8214718 Update missing copyright year in build system

Not all changes in 2018 in the build system were accompanied by updates of the copyright year. Add 2018 to files that were actually modified in 2018, but did not get the copyright line updated. I have found this list by running the update_copyright_year script, and then manually verified that

Re: RFR: JDK-8214710 Fix hg log in update_copyright_year.sh

On 2018-12-03 17:16, Alan Bateman wrote: On 03/12/2018 16:10, Magnus Ihse Bursie wrote: The commands for hg log is missing -l1, which will limit the log to just the revision specified. Instead, all revisions from repo creation will now be included, and the script fails to work. I will publi

Re: RFR: JDK-8214311 dtrace gensrc has missing dependencies

Magnus: Building with JOBS=1 on solaris discovered that the dtrace gensrc has not all dependencies properly declared. This has not been discovered until now, since Solaris machines is typically very parallel, and the needed prerequisites has just happened to have been generated before. Bug: htt

Re: RFR: JDK-8214710 Fix hg log in update_copyright_year.sh

Magnus: On 12/03/18 08:16, Alan Bateman wrote: On 03/12/2018 16:10, Magnus Ihse Bursie wrote: The commands for hg log is missing -l1, which will limit the log to just the revision specified. Instead, all revisions from repo creation will now be included, and the script fails to work. I will

Re: RFR: JDK-8214710 Fix hg log in update_copyright_year.sh

Looks good. /Erik On 2018-12-03 06:19, Magnus Ihse Bursie wrote: The commands for hg log is missing -l1, which will limit the log to just the revision specified. Instead, all revisions from repo creation will now be included, and the script fails to work. I will publish a separate changeset

Re: RFR: JDK-8214718 Update missing copyright year in build system

Looks good. /Erik On 2018-12-03 08:30, Magnus Ihse Bursie wrote: Not all changes in 2018 in the build system were accompanied by updates of the copyright year. Add 2018 to files that were actually modified in 2018, but did not get the copyright line updated. I have found this list by running

Re: RFR: JDK-8214311 dtrace gensrc has missing dependencies

Looks good. /Erik On 2018-12-03 08:45, Tim Bell wrote: Magnus: Building with JOBS=1 on solaris discovered that the dtrace gensrc has not all dependencies properly declared. This has not been discovered until now, since Solaris machines is typically very parallel, and the needed prerequisites

Re: RFR: JDK-8214718 Update missing copyright year in build system

Magnus: Looks good to me as well. Tim On 12/03/18 09:35, Erik Joelsson wrote: Looks good. /Erik On 2018-12-03 08:30, Magnus Ihse Bursie wrote: Not all changes in 2018 in the build system were accompanied by updates of the copyright year. Add 2018 to files that were actually modified in 2018

RFR: JDK-8213187 Handle libwindowsaccessbridge need to access MSVCRT functions

From the bug report: As a follow-up to JDK-8210944, find the best way to handle the needs of libwindowsaccessbridge to access the MSVCRT functions. Options include reverting JDK-8210944, and copying the MSVCRT*.DLL when needed, and/or possible other solutions. I chose to revert JDK-8210944.

RFR: JDK-8214720 Add pandoc filter to improve html man page output

The html output of man pages looks weird due to the metadata header required by pandoc to generate proper man pages. We should add a pandoc filter for html output as well. The actual javascript filter implementation was graciously provided to me by Jon. Bug: https://bugs.openjdk.java.net/bro

Re: RFR: JDK-8213187 Handle libwindowsaccessbridge need to access MSVCRT functions

Looks good. /Erik On 2018-12-03 09:38, Magnus Ihse Bursie wrote: From the bug report: As a follow-up to JDK-8210944, find the best way to handle the needs of libwindowsaccessbridge to access the MSVCRT functions. Options include reverting JDK-8210944, and copying the MSVCRT*.DLL when needed

Re: RFR (round 4), JDK-8214259: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

Round 5 of Shenandoah review includes: - A fix for the @requires tag in TestFullGCCountTest.java. It should be correct now. We believe the CMS @requires was also not quite right and fixed it the same. It reads now: Don't run this test if: - Actual GC set by harness is CMS *and* ExplicitGCInvokesC

Re: [12] Review Request: 8212680 (JDK12b14/Solaris-sparc) SplashScreen::getSplashScreen call fails with ULE: "libsplashscreen.so: ld.so.1: java: fatal: libz.so.1: open failed: No such file o

Hi, Magnus. This looks good to me too, but as I said before, I still think you should write a note about this change in UPDATING.txt, so this fix is not lost if pnglibconf.h were to be re-generated. All lines which started by "/*#undef " in the "pnglibconf.h" are commented manually and this

Re: [12] Review Request: 8212680 (JDK12b14/Solaris-sparc) SplashScreen::getSplashScreen call fails with ULE: "libsplashscreen.so: ld.so.1: java: fatal: libz.so.1: open failed: No such file o

Fair enough, that warning is enough. You don't need to add anything else. I'm ok with the patch. /Magnus > 3 dec. 2018 kl. 20:37 skrev Sergey Bylokhov : > > Hi, Magnus. > >> This looks good to me too, but as I said before, I still think you should >> write a note about this change in UPDATIN

Re: RFR: 8212794 IBM-964 is required for AIX default charset

Hi Ichiroh, src/jdk.charsets/share/classes/sun/nio/cs/ext/IBM33722.java:     I think this is no longer needed since it only has imports.     By the way, the style is to import each specific class and avoid wild card imports. TestIBMBugs:   - Please use a style consistent with other methods in

Re: RFR: 8212794 IBM-964 is required for AIX default charset

Hello Roger. Thank you for your suggestion. src/jdk.charsets/share/classes/sun/nio/cs/ext/IBM33722.java: I think this is no longer needed since it only has imports. By the way, the style is to import each specific class and avoid wild card imports. "import sun.nio.cs.*;" is required be

RFR (round 5), JDK-8214259: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

Round 5 of Shenandoah review includes: - A fix for the @requires tag in TestFullGCCountTest.java. It should be correct now. We believe the CMS @requires was also not quite right and fixed it the same. It reads now: Don't run this test if: - Actual GC set by harness is CMS *and* ExplicitGCInvokesC

Re: RFR (round 4), JDK-8214259: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

> 3 dec. 2018 kl. 20:27 skrev Roman Kennke : > > Round 5 of Shenandoah review includes: > - A fix for the @requires tag in TestFullGCCountTest.java. It should be > correct now. We believe the CMS @requires was also not quite right and > fixed it the same. > > It reads now: Don't run this test i

Re: RFR (round 4), JDK-8214259: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

Hi Roman, Thank you for making the changes. The SA portion looks good to me. One nit though: In src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/HeapSummary.java, in printGCAlgorithm(), does displaying the nbr of Parallel GC threads not make sense for Shenandoah (like it is for G1,