Hi Magnus,
>> I got reviews for shared-build, but an earlier version, so maybe makes
>> sense to look over this again. Erik J, Magnus?
>
> Build changes look good.
Thanks, Magnus!
Roman
Hi Roman,
On 12/3/18 8:27 PM, Roman Kennke wrote:
Round 5 of Shenandoah review includes:
- A fix for the @requires tag in TestFullGCCountTest.java. It should be
correct now. We believe the CMS @requires was also not quite right and
fixed it the same.
It reads now: Don't run this test if:
-
Hi Adam,
I've just pushed the change:
http://hg.openjdk.java.net/jdk/jdk/rev/fc54d27e58d8
Best regards,
Volker
On Thu, Nov 29, 2018 at 5:54 PM Adam Farley8 wrote:
>
> Hi All,
>
> The build passed on xlC 13.1 with the makefile patch I proposed (good catch
> on the comments Volkar!).
>
> With
On 2018-12-04 04:30, Ichiroh Takiguchi wrote:
Hello Roger.
Thank you for your suggestion.
src/jdk.charsets/share/classes/sun/nio/cs/ext/IBM33722.java:
I think this is no longer needed since it only has imports.
By the way, the style is to import each specific class and
avoid wild
Hi Jini,
> Thank you for making the changes. The SA portion looks good to me.
Thank you!
> One
> nit though:
>
> In
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/HeapSummary.java,
> in printGCAlgorithm(), does displaying the nbr of Parallel GC threads
> not make sense for
Hi Per,
>> Round 5 of Shenandoah review includes:
>> - A fix for the @requires tag in TestFullGCCountTest.java. It should be
>> correct now. We believe the CMS @requires was also not quite right and
>> fixed it the same.
>>
>> It reads now: Don't run this test if:
>> - Actual GC set by harness
Hello Magnus.
IBM33722 should be in sun.nio.cs.ext package on jdk.charset module
Because it's not used for default encoding on AIX platform.
In case of template file, build tool checks
make/data/charsetmapping/stdcs-aix file for this case.
If class name is there, it will be migrated to
Hi Ichiroh,
On 12/03/2018 10:30 PM, Ichiroh Takiguchi wrote:
Hello Roger.
Thank you for your suggestion.
src/jdk.charsets/share/classes/sun/nio/cs/ext/IBM33722.java:
I think this is no longer needed since it only has imports.
By the way, the style is to import each specific class
Thanks Volker. :)
Best Regards
Adam Farley
IBM Runtimes
Volker Simonis wrote on 04/12/2018 08:30:58:
> From: Volker Simonis
> To: adam.far...@uk.ibm.com
> Cc: build-dev , Magnus Ihse Bursie
> , ppc-aix-port-...@openjdk.java.net
> Date: 04/12/2018 08:31
> Subject: Re: RFR(XS): 8214063:
As requested in JDK-8179917, we should create a jib package for pandoc
on Windows.
Bug: https://bugs.openjdk.java.net/browse/JDK-8214780
WebRev:
http://cr.openjdk.java.net/~ihse/JDK-8214780-create-pandoc-package-for-windows/webrev.01
/Magnus
with jdk-12+22, bootcycle builds fail at least on x86_64-linux-gnu. Is there
some place where I can check if this kind of build succeeds for others?
thanks, Matthias
On 12/4/18 2:24 PM, Matthias Klose wrote:
> with jdk-12+22, bootcycle builds fail at least on x86_64-linux-gnu. Is there
> some place where I can check if this kind of build succeeds for others?
Just did this on jdk/jdk tip, and it passed:
$ CONF=linux-x86_64-server-fastdebug make
On 12/4/18 8:16 AM, Roger Riggs wrote:
Please review correctly setting the java.specification.version property
with only the major version number. A test is added to ensure the
java spec version agrees with the major version.
The symptoms are that jtreg would fail with a full version
Hi Roger,
Looks fine.
Brian
> On Dec 4, 2018, at 8:23 AM, Roger Riggs wrote:
>
> Including build-dev for the change to GensrcMisc.gmk.
>
> thx.
>
> On 12/04/2018 11:16 AM, Roger Riggs wrote:
>> Please review correctly setting the java.specification.version property
>> with only the major
Hello Roger.
Thank you for your suggestion.
Could you review the fix again ?
Bug:https://bugs.openjdk.java.net/browse/JDK-8212794
Change: https://cr.openjdk.java.net/~itakiguchi/8212794/webrev.04/
Thanks,
Ichiroh Takiguchi
On 2018-12-04 23:36, Roger Riggs wrote:
Hi Ichiroh,
On
Hi Ichiroh,
Looks fine.
I can sponsor that for you. Tomorrow, though, to allow time for any
other comments.
Thanks, Roger
On 12/04/2018 10:21 AM, Ichiroh Takiguchi wrote:
Hello Roger.
Thank you for your suggestion.
Could you review the fix again ?
Bug:
Looks good.
/Erik
On 2018-12-04 04:34, Magnus Ihse Bursie wrote:
As requested in JDK-8179917, we should create a jib package for pandoc
on Windows.
Bug: https://bugs.openjdk.java.net/browse/JDK-8214780
WebRev:
Including build-dev for the change to GensrcMisc.gmk.
thx.
On 12/04/2018 11:16 AM, Roger Riggs wrote:
Please review correctly setting the java.specification.version property
with only the major version number. A test is added to ensure the
java spec version agrees with the major version.
The
The revised webrev looks okay.
Mandy
On 12/4/18 11:32 AM, Roger Riggs wrote:
Hi Mandy, Martin,
The new test is unnecessary, the case is covered by
java/lang/System/Versions test
and uses the stronger comparison for the version numbers.
It would not detect the problem unless the version
Hi Mandy, Martin,
The new test is unnecessary, the case is covered by
java/lang/System/Versions test
and uses the stronger comparison for the version numbers.
It would not detect the problem unless the version included more than
the major version.
Webrev:
Looks good.
/Erik
On 2018-12-04 11:32, Roger Riggs wrote:
Hi Mandy, Martin,
The new test is unnecessary, the case is covered by
java/lang/System/Versions test
and uses the stronger comparison for the version numbers.
It would not detect the problem unless the version included more than
Looks good to me, too.
/Magnus
> 4 dec. 2018 kl. 20:34 skrev Mandy Chung :
>
> The revised webrev looks okay.
>
> Mandy
>
>> On 12/4/18 11:32 AM, Roger Riggs wrote:
>> Hi Mandy, Martin,
>>
>> The new test is unnecessary, the case is covered by
>> java/lang/System/Versions test
>> and uses
On 4/12/2018 11:24 pm, Matthias Klose wrote:
with jdk-12+22, bootcycle builds fail at least on x86_64-linux-gnu. Is there
some place where I can check if this kind of build succeeds for others?
They don't fail for us, we run them regularly.
Cheers,
David
thanks, Matthias
Hi
The shared tests changes looks good for me. Thank you for fixing and testing
different combinations.
Leonid
> On Dec 3, 2018, at 11:10 PM, Roman Kennke wrote:
>
> Round 5 of Shenandoah review includes:
> - A fix for the @requires tag in TestFullGCCountTest.java. It should be
> correct
Thanks, Leonid, for reviewing!
Roman
> Hi
>
> The shared tests changes looks good for me. Thank you for fixing and testing
> different combinations.
>
> Leonid
>
>> On Dec 3, 2018, at 11:10 PM, Roman Kennke wrote:
>>
>> Round 5 of Shenandoah review includes:
>> - A fix for the @requires
>
> LGTM
26 matches
Mail list logo
