Re: RFR (round 5), JDK-8214259: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

2018-12-07 Thread Aleksey Shipilev
On 12/4/18 8:10 AM, Roman Kennke wrote: > Webrevs: > http://cr.openjdk.java.net/~rkennke/shenandoah-upstream/05/ > > [ ] shenandoah-gc > [ ] shenandoah-tests These two parts look good. -Aleksey

RFR (round 6), JDK-8214259: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

2018-12-07 Thread Roman Kennke
Here comes round 6, possibly/hopefully the last round of webrevs for upstreaming Shenandoah: http://cr.openjdk.java.net/~rkennke/shenandoah-upstream/06/ It incorporates: - renames vm_operations_shenandoah* to shenandoahVMOperations*, as suggested by Coleen - reshuffles gcCause in shared-gc SA as

Re: [PATCH] Windows 32-bit DLL name decoration

2018-12-07 Thread Alexey Ivanov
Hi Andrew, Sorry for my belated reply. Yes, it's also an option… however, this solution seems to be overcomplicated to export one function or two. The calling convention of exported functions for JVM cannot be changed, they can be called from third-party software. If the function is used int

Re: RFR: 8214533 IBM-29626C is required for AIX default charset

2018-12-07 Thread Roger Riggs
Hi, It is a nice feature that charsets are selected at build time using the stdcs-xxx files. This change breaks that pattern and embeds os specific information in more than one place. That does not seem like an improvement.  Is there any alternative? Thanks, Roger On 12/06/2018 12:05 PM, Ic

Re: [PATCH] JDK-8214122 Prevent name mangling of jdwpTransport_OnLoad in Windows 32-bit DLL name decoration

2018-12-07 Thread Alexey Ivanov
Hi Ali, On 06/12/2018 22:49, Ali İnce wrote: Hi Magnus, Alexey, I believe we won’t be able to get further opinions from serviceability-dev. Unfortunately, no one has replied as of now. Have you found any issues with jdwpTransport_OnLoad after removing JNICALL? Andrew Luo suggested using a s

RFR: JDK-8215030: Disable shenandoah in Oracle builds

2018-12-07 Thread Erik Joelsson
Hello, This patch disables Shenandoah for Oracle builds of OpenJDK. I intend to push it shortly after JEP 189 is integrated. Bug: https://bugs.openjdk.java.net/browse/JDK-8215030 Webrev: http://cr.openjdk.java.net/~erikj/8215030/webrev.01/ /Erik

Re: RFR: JDK-8215030: Disable shenandoah in Oracle builds

2018-12-07 Thread Kim Barrett
> On Dec 7, 2018, at 3:30 PM, Erik Joelsson wrote: > > Hello, > > This patch disables Shenandoah for Oracle builds of OpenJDK. I intend to push > it shortly after JEP 189 is integrated. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8215030 > > Webrev: http://cr.openjdk.java.net/~erikj/821

Re: [PATCH] Windows 32-bit DLL name decoration

2018-12-07 Thread Simon Tooke
Looking at the code, it seems (to me) the "correct" thing to do is to is to create a Windows-specific version of dbgsysBuildFunName() in linker_md.c, and have it decorate the function name as appropriate for 32-bit windows.  Note that in transport.c, you'd need to pass in the parameter stack size (

RE: [PATCH] Windows 32-bit DLL name decoration

2018-12-07 Thread Andrew Luo
By the way, in hotspot we are generating a .def file dynamically while keeping the JNICALL calling convention (for symbols such as JNI_CreateJavaVM) I believe (just by looking through the code in http://hg.openjdk.java.net/jdk/jdk/file/44fe5fab538a/make/hotspot/lib/JvmMapfile.gmk, unless this c

Re: RFR (round 5), JDK-8214259: Implementation: JEP 189: Shenandoah: A Low-Pause Garbage Collector

2018-12-07 Thread Roland Westrelin
> http://cr.openjdk.java.net/~rkennke/shenandoah-upstream/05/ C2 changes look good to me. Roland.