Re: RFR: JDK-8215445: Enable building for Windows in WSL

2018-12-29 Thread Magnus Ihse Bursie
Looks good to me. /Magnus > 21 dec. 2018 kl. 10:57 skrev Erik Joelsson : > > Hello, > > Here is an updated webrev: > http://cr.openjdk.java.net/~erikj/8215445/webrev.03/ > > I updated the build doc. > > * require 1809 > * Changed to say the drive must be mounted case-insensitive > * Reorder

Re: RFR: JDK-8215952: NetBeans pre-build failed due to the incorrect configuration

2018-12-29 Thread Magnus Ihse Bursie
It's difficult to really review such a patch, but I skimmed through it and it looks reasonable. If it makes netbeans work for you, I'm ok with it. /Magnus > 28 dec. 2018 kl. 07:34 skrev Fu Jie : > > Hi, > > Please review this patch for a build failure with NetBeans: > > Bug: https://bugs.ope

Re: RFR: JDK-8215952: NetBeans pre-build failed due to the incorrect configuration

2018-12-29 Thread Fu Jie
Thanks Magnus. Best regards, Jie On 2018年12月30日 04:12, Magnus Ihse Bursie wrote: It's difficult to really review such a patch, but I skimmed through it and it looks reasonable. If it makes netbeans work for you, I'm ok with it. /Magnus 28 dec. 2018 kl. 07:34 skrev Fu Jie : Hi, Please rev