Re: RFR: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-02-08 Thread Alan Bateman
On 07/02/2019 17:09, Severin Gehwolf wrote: Hi, Could I please get reviews for this enhancement? It adds a debug symbols stripping plug-in to jlink for Linux and Unix platforms. It's the first platform specific jlink plugin and the approach taken for keeping it contained is to use a plugin speci

Re: RFR: 8214796: Create a jlink plugin for stripping debug info symbols from native libraries

2019-02-08 Thread Mandy Chung
On 2/8/19 2:08 AM, Alan Bateman wrote: I agree with Mandy that the CLI options need examination. The proposed `--strip-native-debug-symbols` seems reasonable but it will be inconsistent with the existing `--strip-debug` option. Mandy - what you would think about renaming the existing option

RFR: JDK-8218692 Switch to JCov build which supports byte code version 57

2019-02-08 Thread Alexandre (Shura) Iline
Hi. Can you take a look on quick change to enable JCov runs for jdk/jdk. The fix is to use a custom build of JCov: diff -r 6268e0cdb008 make/conf/jib-profiles.js --- a/make/conf/jib-profiles.js Wed Feb 06 16:25:58 2019 + +++ b/make/conf/jib-profiles.js Fri Feb 08 05:19:34 2019 -0900 @@ -944,

Re: RFR: JDK-8218692 Switch to JCov build which supports byte code version 57

2019-02-08 Thread Erik Joelsson
Looks good. /Erik On 2019-02-08 13:26, Alexandre (Shura) Iline wrote: Hi. Can you take a look on quick change to enable JCov runs for jdk/jdk. The fix is to use a custom build of JCov: diff -r 6268e0cdb008 make/conf/jib-profiles.js --- a/make/conf/jib-profiles.js Wed Feb 06 16:25:58 2019 +00