Hi,
sorry, just sniping in from the side.
About the motivation: the original intent of Yasumasas patch was to reduce
the length of the event log messages.
I have a patch out there for RFR, since ~2 weeks or so, which largely
solves this problem:
https://bugs.openjdk.java.net/browse/JDK-8220762
p.s.: Review is at hs-runtime-dev:
https://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2019-March/033150.html
.
On Fri, Apr 5, 2019 at 10:23 AM Thomas Stüfe
wrote:
> Hi,
>
> sorry, just sniping in from the side.
>
> About the motivation: the original intent of Yasumasas patch was to redu
Hi Thomas,
On 5/04/2019 6:23 pm, Thomas Stüfe wrote:
Hi,
sorry, just sniping in from the side.
About the motivation: the original intent of Yasumasas patch was to
reduce the length of the event log messages.
I have a patch out there for RFR, since ~2 weeks or so, which largely
solves this
On Fri, Apr 5, 2019 at 10:51 AM David Holmes
wrote:
> Hi Thomas,
>
> On 5/04/2019 6:23 pm, Thomas Stüfe wrote:
> > Hi,
> >
> > sorry, just sniping in from the side.
> >
> > About the motivation: the original intent of Yasumasas patch was to
> > reduce the length of the event log messages.
> >
> >
On 4/4/19 8:56 PM, Erik Joelsson wrote:
> I found the issue. It was broken before too, but the old piping
> construct just ignored the error (but it was still printed). Fixed by
> making sure the bootcycle-build directory exists before calling the
> bootcycle build.
>
> Bug: https://bugs.openjd
On 2019-04-04 22:23, Ioi Lam wrote:
On 4/4/19 10:08 PM, David Holmes wrote:
Adding back build-dev
On 5/04/2019 2:41 pm, Ioi Lam wrote:
#define THIS_FILE (__FILE__ + FILE_MACRO_OFFSET)
This make me a little uneasy, as it could potential point past the
end of the string.
The intent of co
Hello,
On 2019-04-05 06:56, Erik Joelsson wrote:
On 2019-04-04 22:23, Ioi Lam wrote:
I am sure the build system is correct . but it's complicated.
BTW, we actually have generated sources that can live outside of the
source repo. And with luck, their names can actually be shorter than
> On Apr 5, 2019, at 11:09 AM, Erik Joelsson wrote:
> So to make it clear. This patch now does the following:
>
> * Removes the setting of -DTHIS_FILE=... from all compilation units involved
> in building Hotspot.
>
> * Introduces THIS_FILE as a macro in Hotspot src which gets just the filename
