Hi,
Some comments, a initial batch...
Having support for the ToolProvider is great.
However, there is no indication about whether it is valid to use it from
multiple threads.
The implementation is structured to be deliberately single thread use only
with the invocation being via a static metho
Some findings:
http://cr.openjdk.java.net/~herrick/8212780/webrev.ea6/raw_files/new/make/launcher/Launcher-jdk.jpackage.gmk:
I think definitions of BUILD_JPACKAGE_APPLAUNCHEREXE and
BUILD_JPACKAGE_APPLAUNCHERWEXE targets should be moved to
http://cr.openjdk.java.net/~herrick/8212780/webrev.ea6/
Alexey:
Please file Bugs for these two issues.
/Andy
On 5/2/2019 1:49 PM, Alexey Semenyuk wrote:
Some findings:
http://cr.openjdk.java.net/~herrick/8212780/webrev.ea6/raw_files/new/make/launcher/Launcher-jdk.jpackage.gmk:
I think definitions of BUILD_JPACKAGE_APPLAUNCHEREXE and
BUILD_JPAC
Ideally the wix code should be generated by running the heat.exe tool on the
application image.
Scott
> On May 2, 2019, at 5:08 PM, Andy Herrick wrote:
>
> Alexey:
>
> Please file Bugs for these two issues.
>
> /Andy
>
>
>> On 5/2/2019 1:49 PM, Alexey Semenyuk wrote:
>> Some findings:
>>
