RFR: JDK-8223464: Improve version string for Oracle CI builds

2019-05-07 Thread Erik Joelsson
This change changes how the version string will look in Oracle CI builds. A string that current looks like this: 13-internal+0-jdk13-jdk.844 Will instead look like this: 13-ea+0-844 For projects, the $PRE string will be used to identify the project, like this: 13-panama+0-844 While in the

RE: [11u] RFR 8210782: Upgrade HarfBuzz to the latest 2.3.1

2019-05-07 Thread Langer, Christoph
Ping: Can I please get a review for this? From: Langer, Christoph Sent: Dienstag, 30. April 2019 11:26 To: jdk-updates-...@openjdk.java.net Cc: 2d-dev <2d-...@openjdk.java.net>; build-dev@openjdk.java.net; Baesken, Matthias Subject: [11u] RFR 8210782: Upgrade HarfBuzz to the latest 2.3.1 Hi, p

RE: [11u] RFR 8210782: Upgrade HarfBuzz to the latest 2.3.1

2019-05-07 Thread Lindenmaier, Goetz
Hi Christoph, I had a look at this change. The integration is good. I thought about the adaptions you had to do. They look good for the compilers you mention, and I would assume they also work with more recent ones. I guess nobody uses more recent compilers on Solaris. On AIX I know further

RE: gcc FORTIFY_SOURCE application security flags

2019-05-07 Thread Baesken, Matthias
Hello, I looked at JDK-8050803 . There are build issues reported when using the _FORTIFY_SOURCE flag . However I only noticed one build issue, this is related to an additional warning ("no result checking of fwrite call") , most likely generated by the added compile time checks of -

Re: RFR: JDK-8223464: Improve version string for Oracle CI builds

2019-05-07 Thread Tim Bell
Erik: Looks good. Thanks for doing this. Tim On 05/07/19 07:21, Erik Joelsson wrote: This change changes how the version string will look in Oracle CI builds. A string that current looks like this: 13-internal+0-jdk13-jdk.844 Will instead look like this: 13-ea+0-844 For projects, the $PRE

Re: [11u] java/awt/FontMetrics/MaxAdvanceIsMax.java test failure (was: [11u] RFR 8210782: Upgrade HarfBuzz to the latest 2.3.1)

2019-05-07 Thread Severin Gehwolf
On Tue, 2019-05-07 at 14:51 +, Lindenmaier, Goetz wrote: > I checked the tests, and the only somewhat related > failing one is java/awt/FontMetrics/MaxAdvanceIsMax.java, > but that is also failing without your patch. How is it failing and has a bug been create for this failure if it's not a te

Re: RFR: JDK-8223464: Improve version string for Oracle CI builds

2019-05-07 Thread Sergey Bylokhov
Hi, Erik. I remember that some of the code uses the "internal" as a mark which enables additional assertions. Will this "internal" mark be used for the local builds? On 07/05/2019 07:21, Erik Joelsson wrote: This change changes how the version string will look in Oracle CI builds. A string th

Re: RFR: JDK-8223464: Improve version string for Oracle CI builds

2019-05-07 Thread Erik Joelsson
Hello Sergey, On 2019-05-07 10:12, Sergey Bylokhov wrote: Hi, Erik. I remember that some of the code uses the "internal" as a mark which enables additional assertions. Will this "internal" mark be used for the local builds? Yes, the change only applies to CI builds. Local builds and any bui

RE: [11u] java/awt/FontMetrics/MaxAdvanceIsMax.java test failure (was: [11u] RFR 8210782: Upgrade HarfBuzz to the latest 2.3.1)

2019-05-07 Thread Lindenmaier, Goetz
Hi Severin, Thanks for looking at the issue! I can reproduce the issue starting the test stand alone. So it's not a problem of our test infrastructure. But I can only reproduce it on a limited set of OSes: linuxppc64le: Red Hat Enterprise Linux Server release 7.2 (Maipo) Red Hat Enterprise Linu