Hi Erik, while setting -O and -O (with x != y ) in one gcc/g++
command line call works ,
setting together -D_FORTIFY_SOURCE=2 and -D_FORTIFY_SOURCE=0 in one
command line call generates a warning , so I think we cannot do that .
Best regards, Matthias
> Hello Matthias,
>
> O
Ping?
On Fri, 2019-05-03 at 18:35 +0200, Severin Gehwolf wrote:
> Hi,
>
> Could I please get reviews for this 8u backport of an optimization fix
> pertaining to the hotspot copy of fdlibm? Historically,
> sharedRuntimeTrans.cpp and sharedRuntimeTrig.cpp have been compiled
> with optimization turn
Hello,
I just tried this and you are correct. However, it does seem to work if
you instead use -U_FORTIFY_SOURCE.
/Erik
On 2019-05-09 05:36, Baesken, Matthias wrote:
Hi Erik, while setting -O and -O (with x != y ) in one gcc/g++
command line call works ,
setting together -D_FORT
In JDK-8223464 I managed to introduce a bug. The reference to the new
property for the PRE string is misspelled in one location.
Bug: https://bugs.openjdk.java.net/browse/JDK-8223627
Webrev: http://cr.openjdk.java.net/~erikj/8223627/webrev.01/
/Erik
Looks good.
David
-
On 9/05/2019 11:44 pm, Erik Joelsson wrote:
In JDK-8223464 I managed to introduce a bug. The reference to the new
property for the PRE string is misspelled in one location.
Bug: https://bugs.openjdk.java.net/browse/JDK-8223627
Webrev: http://cr.openjdk.java.net/~erikj
Hi Matthias,
the change looks good to me.
According to an old redbook [1], this flag makes stacks and r/w sections of the
lib non-executable. This makes sense.
Best regards,
Martin
[1] AIX 5L Differences Guide Version 5.3 Edition
-Original Message-
From: Erik Joelsson mailto:erik.joe
Thanks !
Great you found more info in the good old redbook.
Best regards , Matthias
From: Doerr, Martin
Sent: Donnerstag, 9. Mai 2019 16:04
To: Baesken, Matthias ;
ppc-aix-port-...@openjdk.java.net; build-dev@openjdk.java.net
Cc: Steve Groeger
Subject: RE: FW: RFR: 8223307: enable the Stack Ex
Hello,
I tried setting
"-U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0"
And this seems indeed to work , no warning any more .
Let's hope gcc does not change the command line parsing .
Btw. is there a gcc version that a) still compiles jdk/jdkand b)
would show the issue ?
(with our inter
Configure will protest if GCC version is less than 4.8 (see toolchain.m4
*_MINIMUM_VERSION variables).
That said, as long as we conditionally set the FDLIBM_CFLAGS like this,
I would say we need to continue honoring the result of that check. You
could also remove the check altogether since it
Erik:
Looks good to me as well.
Tim
On 05/09/19 07:02, David Holmes wrote:
Looks good.
David
-
On 9/05/2019 11:44 pm, Erik Joelsson wrote:
In JDK-8223464 I managed to introduce a bug. The reference to the new
property for the PRE string is misspelled in one location.
Bug: https://bugs.
Hello, here is the new webrev with the
"-U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0"
Set for the lower level optimization flags :
http://cr.openjdk.java.net/~mbaesken/webrevs/8130017.1/
I would suggest to leave the pre-gcc4.8 cleanup to a separate change.
Best regards, Matthias
>
> Confi
11 matches
Mail list logo
