Re: Failure buiilding OPEN JDK 11 on windows cygwin with VC 2017

2019-05-28 Thread Moshe Zuisman
I configure with default options: *sh ./configure --with-boot-jdk=/cygdrive/c/jdk-11.0.3* By the way - ordinary VC solutions - compiles form MSVC IDE with no problem вт, 28 мая 2019 г. в 19:34, Aleksey Shipilev : > On 5/28/19 6:15 PM, Moshe Zuisman wrote: > > warning C4577: 'noexcept' used

Re: RFR (XXS) 8224790: Remove Xusage.txt file

2019-05-28 Thread David Holmes
Thanks Erik! David On 28/05/2019 11:35 pm, Erik Joelsson wrote: Looks good! /Erik On 2019-05-24 22:49, David Holmes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8224790 webrev: http://cr.openjdk.java.net/~dholmes/8224790/webrev/ Before Java 7 the Xusage.txt file was used to print

Re: RFR(L/XS) : 8222414 : bring googlemock v1.8.1

2019-05-28 Thread David Holmes
Hi Igor, FYI this seems to have broken the arm32 build. I've filed: https://bugs.openjdk.java.net/browse/JDK-8224945 David On 28/05/2019 12:47 pm, Igor Ignatyev wrote: thanks Robin! pushed. -- Igor On May 27, 2019, at 12:54 AM, Robin Westberg wrote: Hi Igor, Looks good to me, I tried

Re: Failure buiilding OPEN JDK 11 on windows cygwin with VC 2017

2019-05-28 Thread David Holmes
Hi Moshe, On 29/05/2019 2:15 am, Moshe Zuisman wrote: I am trying to build OPEN jdk 11 on cygwin with MSVC 2017 _ VS 2017 is the official supported compiler for building OpenJDK 11 [1] and we don't see any issues. What

Re: RFR: 8223678: Add Visual Studio Code workspace generation support (for native code)

2019-05-28 Thread Erik Joelsson
Hello Robin, Looks good. Adding of ide.md is very nice, but could you try to format it like testing.md and building.md in regards to line lengths? I believe we are trying for 80 chars in those to make them read reasonably in a standard editor. /Erik On 2019-05-27 09:03, Robin Westberg

Re: RFR (XXS) 8224790: Remove Xusage.txt file

2019-05-28 Thread Erik Joelsson
Looks good! /Erik On 2019-05-24 22:49, David Holmes wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8224790 webrev: http://cr.openjdk.java.net/~dholmes/8224790/webrev/ Before Java 7 the Xusage.txt file was used to print the "java -X" help information in English. From Java 7 this

Re: [OpenJDK 2D-Dev] RFR: 8224778: test/jdk/demo/jfc/J2Ddemo/J2DdemoTest.java cannot find J2Ddemo.jar

2019-05-28 Thread Erik Joelsson
Looks good, thanks! /Erik On 2019-05-24 16:36, Philip Race wrote: No other comments so far so here's that update : http://cr.openjdk.java.net/~prr/8224778.1/ -phil. On 5/24/19, 2:41 PM, Philip Race wrote: Yes, I just copied that line + edited it. I can update both lines if that is what you

Re: RFR: 8223678: Add Visual Studio Code workspace generation support (for native code)

2019-05-28 Thread Volker Simonis
Hi Robin, thanks a lot for doing this! I have just a quick question. Do you know if any of the VSC indexers (default, clangd) support call hierarchies (i.e. "called by", "callers" of a function/method) and "used by" for variables/class fields? Regards, Volker On Mon, May 27, 2019 at 6:03 PM

Failure buiilding OPEN JDK 11 on windows cygwin with VC 2017

2019-05-28 Thread Moshe Zuisman
I am trying to build OPEN jdk 11 on cygwin with MSVC 2017 _ *c:\progra~2\mib055~1\2017\profes~1\vc\tools\msvc\1410~1.250\include\exception(366): warning C4577: 'noexcept' used with no exception handling

Re: Failure buiilding OPEN JDK 11 on windows cygwin with VC 2017

2019-05-28 Thread Aleksey Shipilev
On 5/28/19 6:15 PM, Moshe Zuisman wrote: > warning C4577: 'noexcept' used with no exception handling mode specified; Somebody else can chime in if this is a legit warning. > error C2220: warning treated as error - no 'object' file ...but this tells that you might try to configure with