Re: RFR: JDK-8225392: Comparison builds are failing due to cacerts file

2019-06-14 Thread Sean Mullan
On 6/14/19 1:49 AM, Weijun Wang wrote: BTW, something not related but similar: Do you like me to also sort aliases alphabetically in the output of "keytool -list"? Yes, I think that is useful. --Sean

[13] RFR: JDK-8225392: Comparison builds are failing due to cacerts file

2019-06-14 Thread Weijun Wang
Here is the updated webrev http://cr.openjdk.java.net/~weijun/8225392/webrev.01/ The only change is ordering in 'keytool -list' and its test. Thanks, Max > On Jun 14, 2019, at 7:55 PM, Sean Mullan wrote: > > On 6/14/19 1:49 AM, Weijun Wang wrote: >> BTW, something not related but similar: D

Re: [13] RFR: JDK-8225392: Comparison builds are failing due to cacerts file

2019-06-14 Thread Erik Joelsson
I'm happy with this. /Erik On 2019-06-14 08:33, Weijun Wang wrote: Here is the updated webrev http://cr.openjdk.java.net/~weijun/8225392/webrev.01/ The only change is ordering in 'keytool -list' and its test. Thanks, Max On Jun 14, 2019, at 7:55 PM, Sean Mullan wrote: On 6/14/19 1:49

Re: RFR: 8224851: AArch64: fix warnings and errors with Clang and GCC 8.3

2019-06-14 Thread Andrew Haley
Hi, On 6/12/19 10:35 AM, Nick Gasson wrote: > Sorry for the delay, I've put an updated webrev here: > > http://cr.openjdk.java.net/~ngasson/8224851/webrev.1/ > > Changes since the last patch: > > * Replaced ~((1<<12) - 1) with -1u<<12 > > * Use __atomic_add_fetch in Atomic::PlatformAdd #ifdef

jdk 14 version string scheme changed?

2019-06-14 Thread Martin Buchholz
The first jdk14 build reports: openjdk full version "14-ea+1-1" while jdk13 has: openjdk full version "13-ea+25" The trailing "-1" looks like a bug - is it intentional?

Re: jdk 14 version string scheme changed?

2019-06-14 Thread Erik Joelsson
Hello Martin, It is intentional. The extra number is our internal CI build number. From JDK 14 we have decided to stop rebuilding for promotion and instead use a build already built and tested in our CI. The new number is part of the $OPT string as defined in JEP-223 [1]. "$OPT, matching|([-

Re: jdk 14 version string scheme changed?

2019-06-14 Thread Martin Buchholz
Thanks! (OPT is harder to parse out than I expected ...) On Fri, Jun 14, 2019 at 12:57 PM Erik Joelsson wrote: > Hello Martin, > > It is intentional. The extra number is our internal CI build number. From > JDK 14 we have decided to stop rebuilding for promotion and instead use a > build alread

Re: jdk 14 version string scheme changed?

2019-06-14 Thread Erik Joelsson
The configure script has parsing logic for interpreting a full version string and splitting it into all the parts if you need inspiration. /Erik On 2019-06-14 13:51, Martin Buchholz wrote: Thanks! (OPT is harder to parse out than I expected ...) On Fri, Jun 14, 2019 at 12:57 PM Erik Joelsson

Re: [13] RFR: JDK-8225392: Comparison builds are failing due to cacerts file

2019-06-14 Thread Sean Mullan
On 6/14/19 11:33 AM, Weijun Wang wrote: Here is the updated webrev http://cr.openjdk.java.net/~weijun/8225392/webrev.01/ The only change is ordering in 'keytool -list' and its test. Looks fine. --Sean Thanks, Max On Jun 14, 2019, at 7:55 PM, Sean Mullan wrote: On 6/14/19 1:49 AM, W